[STANBOL-651] EventJobManager does not finish if an Engine fails that is not the last Engine in the EnhancementChain

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.0-incubating
• Fix Version/s: enhancer-0.10.0
• Component/s: Enhancer
• Assignee: Rupert Westenthaler
• Reporter: Rupert Westenthaler
• Created: 04/Jun/12 07:00
• Updated: 17/Jul/13 15:16
• Resolved: 04/Jun/12 07:21

Description

The EventJobManager does not complete an EnhancementJob if the following Situation occurs

• An EnhancementEngine fails
• The failed engine is not the last on in the EnhancementChain
• No other engines are executed in parallel

The reason for that is the the EnhancementJobHander (asyc execution using osgi.service.event framework) needs to notify the EventJobManagerImpl if an EnhancementJob completes. However in the above situation this does not occur and because of the the EventJobManagerImpl waits "forever" for the completion of the job - similar to a deadlock.

To solve this the EnhancementJob#isFinished() needs to be adopted to correctly report an Job as "finished" if EnhancementJob#isFailed() == true and not other engines are executed in parallel.