[STANBOL-1443] FastLRUCacheManager of the FST Linking Engine is not thread save

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 1.0.0, 0.12.1
• Component/s: Enhancement Engines
• Assignee: Rupert Westenthaler
• Reporter: Rupert Westenthaler
• Created: 19/Oct/15 11:51
• Updated: 20/Oct/15 10:57
• Resolved: 20/Oct/15 10:55

Description

The FastLRUCacheManager is the implementation of the EntityCacheManager. The EntityCacheManager interface uses the o.a.solr.util.RefCounted for getting the EntityCache object.

However the management of the RefCount of the FastLRUCacheManager implementation is not thread save. So under high load the actual ref count can get wrong values. Based on logs I observed negative values (resulting in close operations in the Cache) and also very high values (potentially resulting in Caches not being correctly garbage collected).

To fix this issue the FastLRUCacheManager.getCache(Object version) needs to be implemented in a thread save manner. Also the #close() method needs to be thread save.