[SSHD-970] transferTo function of SftpRemotePathChannel will loop if count parameter is greater than file size

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.5.0
• Labels: patch
• Flags: Patch
• Assignee: Guillaume Nodet
• Reporter: Michele Milesi
• Created: 27/Feb/20 09:01
• Updated: 27/Feb/20 09:27
• Resolved: 27/Feb/20 09:20

Description

The method transferTo of SftpRemotePathChannel does not checks eof condition.

• The exit condition from the reading loop is that totalRead variable is not less than count parameter.
• At eof the value the method does not increment the totalRead variable
• If count parameter value is greater than source file size the value of totalRead will never reach the count value

In order to exit from the loop we need to check the eof condition.

The attached patch contains:

• A junit test (added to SftpRemotePathChannelTest.java)
• A simple fix to the exit condition

The problem was found on:

• 2.4.0 released version
• current git head

Issue Links

• duplicates: SSHD-967 transferTo function of SftpRemotePathChannel always add some extra bytes in the end of file