[SSHD-865] Use lazy-loading for keys specified in the HostConfigEntry

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.2.0
• Flags: Important
• Assignee: Lyor Goldstein
• Reporter: Lyor Goldstein
• Created: 15/Nov/18 06:27
• Updated: 08/Jun/20 13:34
• Resolved: 19/Nov/18 12:50

Description

Following SSHD-860 key loading occurs lazily - thus encrypted keys password is not requested until the key is actually needed. The exception to this rule are keys specified as part of a HostConfigEntry specified in an ssh_config file.

Implementation details

• Need to change SshClient#loadClientIdentities to return a KeyPairProvider that is propagated all the way to SshClient#onConnectOperationComplete.
• The code in SshClient#onConnectOperationComplete should check after setupDefaultSessionIdentities if there is a non-empty KeyPairProvider propagated and aggregate it with any already set such provider on the session

Issue Links

• is part of: SSHD-860 org.apache.sshd.client.auth.pubkey.UserAuthPublicKeyIterator pre-loads client identities (private key files)