[SSHD-792] Remote Port-Forwarding uses invalid "original host" values

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6.0
• Fix Version/s: 2.2.0
• Labels: needs-test
• Environment: Java 8 ; OSX
• Assignee: Lyor Goldstein
• Reporter: Andreas Haufler
• Created: 07/Jan/18 13:19
• Updated: 08/Jun/20 13:35
• Resolved: 17/Dec/18 11:27

Description

When starting a server which accepts all kinds of port forwarding:

sshd.setTcpipForwardingFilter(new StaticDecisionForwardingFilter(true));

remote port-forwarding doesn't work (at least when connecting from OSX) unless a specific address is given:
ssh localhost p 2222 -R10001:localhost:80 < doesn't work
ssh localhost p 2222 -R127.0.0.1:10001:localhost:80 < does work

As far as I can tell, TcpipClientChannel.java:98 uses the underlying socket-address
of the effective connection and transmit the host (which is either 127.0.0.1 or ::1) on OSX.

However, the client (ssh) would want to see "localhost" as original host in order to permit tunneling.

Is there anything I am missing? Otherwise I could provide a PR which fixes this (by remembering the originally requested host and reporting that back).