[SSHD-79] ChannelPipedInputStream returns improper negative values for some bytes.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.1.0, 0.2.0, 0.3.0, 0.4.0
• Fix Version/s: 0.4.0
• Assignee: Guillaume Nodet
• Reporter: Bill Kuker
• Created: 11/Mar/10 23:30
• Updated: 28/Apr/10 18:29
• Resolved: 28/Apr/10 18:29

Description

The function:

public int read() throws IOException {
synchronized (b) {
int l = read(b, 0, 1);
if (l == -1)

{ return -1; }
return b[0];
}
}

Will return negative values for negative bytes. It must read:

public int read() throws IOException {
synchronized (b) {
int l = read(b, 0, 1);
if (l == -1) { return -1; }

return ((int)b[0] & 0xff);
}
}

instead to return values in the range of 0-255 per java.io.InputStream read()

Issue Links

• is duplicated by: SSHD-84 ChannelPipedInputStream.read() incorrect sign extension in result