[SSHD-78] PEMGeneratorHostKeyProvider doesn't close PEMWriter

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.3.0
• Fix Version/s: 0.4.0
• Assignee: Guillaume Nodet
• Reporter: Philippe Laflamme
• Created: 06/Mar/10 01:49
• Updated: 21/May/12 15:27
• Resolved: 28/Apr/10 18:22

Description

When using PEMGeneratorHostKeyProvider to read and write generated key in PEM format, the class does not properly close the instance of PEMWriter. This results in the key not being written to the file.

protected void doWriteKeyPair(KeyPair kp, OutputStream os) throws Exception {
PEMWriter w = new PEMWriter(new OutputStreamWriter(os));
w.writeObject(kp);
// This is missing (and should be in a finally block)
w.close();
}

Issue Links

• is duplicated by: SSHD-103 SimpleGeneratorHostKeyProvider fails to read files it wrote "StreamCorruptedException: unexpected block data"