MINA SSHD
  1. MINA SSHD
  2. SSHD-78

PEMGeneratorHostKeyProvider doesn't close PEMWriter

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.4.0
    • Labels:
      None

      Description

      When using PEMGeneratorHostKeyProvider to read and write generated key in PEM format, the class does not properly close the instance of PEMWriter. This results in the key not being written to the file.

      protected void doWriteKeyPair(KeyPair kp, OutputStream os) throws Exception

      { PEMWriter w = new PEMWriter(new OutputStreamWriter(os)); w.writeObject(kp); // This is missing (and should be in a finally block) w.close(); }

        Issue Links

          Activity

          Hide
          Guillaume Nodet added a comment -

          Committing to https://svn.apache.org/repos/asf/mina/sshd/trunk ...
          M sshd-core/src/main/java/org/apache/sshd/server/keyprovider/PEMGeneratorHostKeyProvider.java
          Committed r939040

          Flush instead of close. The output stream is closed by the caller.

          Show
          Guillaume Nodet added a comment - Committing to https://svn.apache.org/repos/asf/mina/sshd/trunk ... M sshd-core/src/main/java/org/apache/sshd/server/keyprovider/PEMGeneratorHostKeyProvider.java Committed r939040 Flush instead of close. The output stream is closed by the caller.
          Hide
          Guillaume Nodet added a comment -

          Committing to https://svn.apache.org/repos/asf/mina/sshd/trunk ...
          M sshd-core/src/main/java/org/apache/sshd/server/keyprovider/PEMGeneratorHostKeyProvider.java
          Committed r939038

          Show
          Guillaume Nodet added a comment - Committing to https://svn.apache.org/repos/asf/mina/sshd/trunk ... M sshd-core/src/main/java/org/apache/sshd/server/keyprovider/PEMGeneratorHostKeyProvider.java Committed r939038

            People

            • Assignee:
              Guillaume Nodet
              Reporter:
              Philippe Laflamme
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development