[SSHD-739] A call to resolvePropertyValue can be very inefficient

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Assignee: Guillaume Nodet
• Reporter: Guillaume Nodet
• Created: 11/Apr/17 18:49
• Updated: 29/Jun/17 09:34
• Resolved: 12/Apr/17 19:20

Description

Each time a property is retrieved, all system properties names are iterated.
This is because PropertyResolverUtil#resolvePropertyValue is calling GenericUtils.isEmpty(props) on a SyspropsMapWrapper.

This can be solved by using isNull(props) instead of isEmpty(props) as there's no need to check if the map is empty.
In the same call, there's also a call to System.getProperty which seems to be redundant with the SyspropsMapWrapper. I think it should be removed.

Issue Links

• relates to: SSHD-740 Add default methods on PropertyResolver to actually do the property resolution