[SSHD-724] Fix errors flagged by infer static analyzer

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 1.4.0
• Labels: findbugs static-analysis
• Assignee: Lyor Goldstein
• Reporter: David Ostrovsky
• Created: 24/Dec/16 21:16
• Updated: 14/Feb/17 07:01
• Resolved: 14/Feb/17 07:01

Description

Running infer static analyzer: [1] on latest master produces 113 errors:

[davido@wizball sshd]$ git describe
sshd-1.3.0-51-g4f0f4dc

[davido@wizball sshd]$ uname -a
Linux wizball 4.8.6-300.fc25.x86_64 #1 SMP Tue Nov 1 12:36:38 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

[davido@wizball sshd]$ java -version
openjdk version "1.8.0_111"
OpenJDK Runtime Environment (build 1.8.0_111-b16)
OpenJDK 64-Bit Server VM (build 25.111-b16, mixed mode)

[davido@localhost sshd]$ infer – mvn package

[...]

...too many issues to display (limit=10 exceeded), please see /home/davido/projects/sshd/infer-out/bugs.txt or run `inferTraceBugs` for the remaining issues.

Summary of the reports

NULL_DEREFERENCE: 82
RESOURCE_LEAK: 31

The full report can be found here: [2].

[1] http://fbinfer.com
[2] http://paste.openstack.org/show/593308

Issue Links

• links to: GitHub Pull Request #28