[SSHD-595] MINA-CORE does not remove sessions if exceptions occur while closing

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.14.0
• Environment: mina-ssh 0.14.0; mina-core 2.0.8; Multiple OSes / Java configurations:; * Mac OS X El Capitan on Java 8 (1.8.0_60); * CentOS 6.4 on Java 8 (1.8.0_60); * CentOS 6.5 on Java 8 (1.8.0_20-b26).
• Flags: Patch
• Assignee: Unassigned
• Reporter: Doug Kelly
• Created: 20/Nov/15 20:56
• Updated: 02/Sep/16 06:43
• Resolved: 02/Sep/16 06:43

Description

MINA SSHD isn't removing sessions when using the MINA/NIO backend if an exception as received as the session is closing (such as a connection reset is received with data still in the write buffer). When this case happens, it seems that NioProcessor.getState returns the state as CLOSING (I'm assuming since the underlying channel is now closed), which means that the AbstractPollingIoProcessor.removeSessions() won't ever prune the session, since a CLOSING state is simply ignored. The result is a resource leak over time, since these sessions are never pruned (it's a slow leak, since entering this condition is racy – on my workstation, I can produce it through randomly interrupting connections anywhere from 1/6 to 1/10th of the time). (This may either be major or critical; reprioritize as necessary.)

I specifically see this error with Gerrit 2.10.4 and Gerrit 2.11.5 (using mina-sshd 0.14.0 / mina-core 2.0.8), and it looks like the code path is unchanged in mina-sshd 1.0.0 / mina-core 2.0.9. I was unsure if this is specifically a bug in mina-core or, if it's something unique to mina-sshd. My local development system runs Mac OS X El Capitan on Java 8 (1.8.0_60), but I've also seen this on Linux (CentOS 6.4, again Java 1.8.0_60 and CentOS 6.5 on Java 1.8.0_20-b26).

The fix may be as simple as attempting to remove the session if OPENED or CLOSING, but I'm unsure what side-effects this may have with other backends. I'll be happy to test it locally, but I'm fairly ignorant when it comes to MINA's code.

Issue Links

• depends upon: DIRMINA-1021 MINA-CORE does not remove sessions if exceptions occur while closing
• is cloned by: DIRMINA-1021 MINA-CORE does not remove sessions if exceptions occur while closing
• is duplicated by: SSHD-650 Session objects may stuck
• requires: SSHD-418 Upgrade to mina 3