[SSHD-347] Sftplet.onConnect(...) does not obtain access to ServerSession

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.0
• Assignee: Guillaume Nodet
• Reporter: Dmitri Priimak
• Created: 08/Sep/14 06:15
• Updated: 10/Sep/14 10:46
• Resolved: 10/Sep/14 10:46

Description

Using Sftplet I encountered one small problem.
In current git repo in file

sshd-sftp/src/main/java/org/apache/sshd/sftp/subsyste/SftpSubsystem.java

in lines 138 through 141 there is following code

public void setSession(ServerSession session) {
sftpLet.onConnect(this);
this.session = session;
}

This calls sftpLet.onConnect(...) before session is set, which means that at that stage information from the session such as user name of the
person who logged in or the remote ip address is not available in inside of onConnect(...) call even though ServerServer already has this information.

A simple swapping of just two lines should fix that, like so

public void setSession(ServerSession session) {
this.session = session;
sftpLet.onConnect(this);
}

Can such change be made in your code?