[SSHD-231] Failed authentication method isnt removed from list of allowed methods

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.7.0
• Fix Version/s: 0.9.0
• Assignee: Guillaume Nodet
• Reporter: Neil Culver
• Created: 03/Jul/13 13:56
• Updated: 17/Jul/13 14:31
• Resolved: 17/Jul/13 14:31

Description

Hi,
Whilst investigating an authentication problem with a client connection I've noticed that the code which removes failed authentication methods from the list of allowed methods always specifies "none", instead of the actual method which failed.

Code from ServerSession.userAuth method :

NamedFactory.Utils.remove(userAuthFactories, "none"); // 'none' MUST NOT be listed

instead I would expect the actual method to be removed, i.e. :

NamedFactory.Utils.remove(userAuthFactories, method);

I'm not sure if this is by design or not ?

Thanks

Issue Links

• is part of: SSHD-234 Support partial authentication