[SSHD-219] DefaultSshFuture.awaitUninterruptibly() uses incorrect timeout

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8.0
• Fix Version/s: 0.9.0
• Assignee: Guillaume Nodet
• Reporter: Mark Peters
• Created: 12/Mar/13 14:45
• Updated: 18/Jul/13 07:49
• Resolved: 18/Jul/13 07:49

Description

DefaultSshFuture.awaitInterruptibly() works by setting a timeout of Long.MAX_VALUE. When you add this to System.currentTimeMillis(), you get a time very much in the past, since the value wraps to the negatives.

Later, to detect timeout, await0() does this upon being woken up:

if (ready)

{ return true; }

else {
if (endTime < System.currentTimeMillis())

{ //THIS WILL ALWAYS BE TRUE return ready; }

}

Thus the ready check, which prevents spurious wakeups, never prevents spurious wakeups in the case that no timeout is specified.

To fix this, endTime itself could simply be set to Long.MAX_VALUE rather than ADDING Long.MAX_VALUE to the current time.