[SSHD-153] Improve handling of SSH_MSG_CHANNEL_WINDOW_ADJUST message

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 0.7.0
• Labels: patch
• Environment: All
• Assignee: Guillaume Nodet
• Reporter: Simon Paradis
• Created: 16/Dec/11 21:00
• Updated: 21/May/12 08:24
• Resolved: 21/May/12 08:24

Description

I posted about this issue in the users mailing list...

The consumeAndCheck() method of channel/Window.java is used to enlarge the receive window of channel. While tracing a libssh2 based application with tracing enabled talking to a SSHD-Core Java app, I found out it sends too many of these adjustment message. It was sending one every 3 packet size which is quite too much considering the default packet size of 32kb.

The RFC 4254 is unclear about proper handling but sending one when the current window size reaches half of its maximum look common. This is what OpenSSH

I've attached a patch taken from the trunk http://svn.apache.org/repos/asf/mina/sshd/trunk