MINA SSHD
  1. MINA SSHD
  2. SSHD-153

Improve handling of SSH_MSG_CHANNEL_WINDOW_ADJUST message

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Labels:
    • Environment:
      All

      Description

      I posted about this issue in the users mailing list...

      The consumeAndCheck() method of channel/Window.java is used to enlarge the receive window of channel. While tracing a libssh2 based application with tracing enabled talking to a SSHD-Core Java app, I found out it sends too many of these adjustment message. It was sending one every 3 packet size which is quite too much considering the default packet size of 32kb.

      The RFC 4254 is unclear about proper handling but sending one when the current window size reaches half of its maximum look common. This is what OpenSSH

      I've attached a patch taken from the trunk http://svn.apache.org/repos/asf/mina/sshd/trunk

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        156d 11h 24m 1 Guillaume Nodet 21/May/12 09:24
        Guillaume Nodet made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Guillaume Nodet [ gnt ]
        Resolution Fixed [ 1 ]
        Hide
        Guillaume Nodet added a comment -

        Fixed, thx for the patch Simon.

        Show
        Guillaume Nodet added a comment - Fixed, thx for the patch Simon.
        Simon Paradis made changes -
        Field Original Value New Value
        Attachment ssh_window_adjustment_patch.diff [ 12507723 ]
        Simon Paradis created issue -

          People

          • Assignee:
            Guillaume Nodet
            Reporter:
            Simon Paradis
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development