[SSHD-145] InvertedShellWrapper may not send process output back if process exits too fast

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.5.0
• Fix Version/s: 0.7.0
• Environment: Usually does not reproduce on windows, often on linux (Ubuntu 11.04)
• Assignee: Guillaume Nodet
• Reporter: Denis Tulskiy
• Created: 09/Sep/11 12:18
• Updated: 19/May/12 12:35
• Resolved: 19/May/12 12:35

Description

In InvertedShellWrapper, pumpStreams() method first checks if the process is alive, and only then pumps streams. It could happen that after the process has already exited, some information is left out in out or err streams. Moving the check for shell.isAlive() after all pumpStream() calls seems to resolve the issue.

I've uploaded a patch for your convenience here https://gist.github.com/1206056

steps to reproduce:

1. create a default server
2. set command factory as described at http://mina.apache.org/sshd/tips.html
3. run `ssh localhost -p 8000 echo test`

expected result:
command output is `test`

actual result:
usually nothing is printed even though the command is executed

Issue Links

• is duplicated by: SSHD-125 InvertedShellWrapper won't pump end of stream