[SSHD-1330] keep-alive handler on client

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.10.0
• Fix Version/s: 2.10.1, 2.11.0
• Assignee: Lyor Goldstein
• Reporter: Florian Hof
• Created: 15/Jun/23 08:06
• Updated: 09/Oct/23 20:21
• Resolved: 26/Sep/23 16:28

Description

After a connection using the default SFTP client, I get lot's of WARN logs like the following:
handleUnknownRequest(ClientConnectionService[ClientSessionImpl[[e-mail]/xx.xx.xx.xx:993]]) unknown global request: [e-mail]

It seems that the server send keep-alive messages to the client. The KeepAliveHandler handles this properly. It is per default in the server handlers. I propose to add it per default in the client handlers. This shouldn't have negative effect, should it? Adding it afterwards avoids the WARN logs.

Implementation on ClientBuilder.DEFAULT_GLOBAL_REQUEST_HANDLERS would be trivial:

    public static final List<RequestHandler<ConnectionService>> DEFAULT_GLOBAL_REQUEST_HANDLERS
            = List.of(OpenSshHostKeysHandler.INSTANCE, KeepAliveHandler.INSTANCE);
 

(and eventually move the KeepAliveHandler from org.apache.sshd.server.global to org.apache.sshd.common.global).

Issue Links

• links to: GitHub Pull Request #416
• links to: PR#416