[SSHD-1261] Sometimes async write listener is not called

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.9.0
• Assignee: Lyor Goldstein
• Reporter: Evgeny Pasynkov
• Created: 06/Apr/22 13:38
• Updated: 13/May/22 15:44
• Resolved: 13/May/22 15:44

Description

Hello,

I have discovered the case when the async write listener is not called.

Imagine the case: The `ChannelAsyncOutputStream::doWriteIfPossible` method discover that window size is too small (lines 160-167). It setup new future and exit the doWriteIfPossible method, relying on `onWindowExpanded` will be called shortly. But if the channel is disconnected, the method will never be invoked, thus future won't be completed.

 I suggest adding the following override to ChannelAsyncOutputStream class:

    @Override
    protected void doCloseImmediately() {
        abortCurrentWrite();
        super.doCloseImmediately();
    }

    protected synchronized void abortCurrentWrite() {
        IoWriteFutureImpl future = pendingWrite.get();
        if (future != null) {
            future.setValue(new ClosedChannelException());
        }        
    }