Uploaded image for project: 'MINA SSHD'
  1. MINA SSHD
  2. SSHD-123

TcpipForward race condition & deadlock on client disconnect.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.3.0, 0.5.0, 0.6.0
    • Fix Version/s: 0.7.0
    • Labels:
      None
    • Environment:
      I am able to reproduce this every single time on my quad core windows 7 machine.

      Description

      If a client with an active remote port forward disconnects at about the same time a new connection comes in to that port forward two NioProcessor threads end up deadlocked in TcpipForwardSupport, at the following spots:

      NioProcessor-14 stuck at org.apache.sshd.server.session.TcpipForwardSupport.sessionCreated(...):
      OpenFuture future = channel.open().await();

      NioProcessor-2 stuck at org.apache.sshd.server.session.TcpipForwardSupport.close():
      acceptor.dispose();

      It appears that the new connection to the port forward is trying to create a new channel over a session that is currently trying to close. Both threads end up waiting on different objects, and are never notified.

        Attachments

        1. SSHD_123_Test.java
          9 kB
          Bill Kuker
        2. SSHD-123-Stacks.test.txt
          4 kB
          Bill Kuker
        3. SSHD-123.patch
          1 kB
          Bill Kuker

          Activity

            People

            • Assignee:
              gnt Guillaume Nodet
              Reporter:
              bkuker1 Bill Kuker
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: