Uploaded image for project: 'MINA SSHD'
  1. MINA SSHD
  2. SSHD-117

Ignore "keepalive@jcraft.com" in addition to "keepalive@openssh.com"

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.6.0
    • Labels:
      None
    • Environment:
      Any environment, JSch based client.

      Description

      It would be nice to also ignore jcraft keepalive messages.
      I think it is silly that this is how keepalive is done, but if MINA SSHD ignores one it may as well ignore the other.

      sshd-core/src/main/java/org/apache/sshd/server/session/ServerSession.java

      • if (req.equals("keepalive@openssh.com")) {
        + if (req.equals("keepalive@openssh.com") || req.equals("keepalive@jcraft.com")) {

      Personally I'd also like to see:

      • log.error("Unknown global request: {}", req);
        + log.warn("Unknown global request: {}", req);

        Attachments

          Activity

            People

            • Assignee:
              spearce Shawn Pearce
              Reporter:
              bkuker1 Bill Kuker
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: