MINA SSHD
  1. MINA SSHD
  2. SSHD-117

Ignore "keepalive@jcraft.com" in addition to "keepalive@openssh.com"

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.6.0
    • Labels:
      None
    • Environment:
      Any environment, JSch based client.

      Description

      It would be nice to also ignore jcraft keepalive messages.
      I think it is silly that this is how keepalive is done, but if MINA SSHD ignores one it may as well ignore the other.

      sshd-core/src/main/java/org/apache/sshd/server/session/ServerSession.java

      • if (req.equals("keepalive@openssh.com")) {
        + if (req.equals("keepalive@openssh.com") || req.equals("keepalive@jcraft.com")) {

      Personally I'd also like to see:

      • log.error("Unknown global request: {}", req);
        + log.warn("Unknown global request: {}", req);

        Activity

        Bill Kuker created issue -
        Hide
        Bobby Powers added a comment -

        we ignore keepalive@lag.net on trunk as well, so this seems like a good idea

        Show
        Bobby Powers added a comment - we ignore keepalive@lag.net on trunk as well, so this seems like a good idea
        Hide
        Bobby Powers added a comment -

        does it make sense to match the request against the regex '^keepalive@' instead of these 3 (possibly more in the future) cases?

        Show
        Bobby Powers added a comment - does it make sense to match the request against the regex '^keepalive@' instead of these 3 (possibly more in the future) cases?
        Hide
        Guillaume Nodet added a comment -

        I think that sounds reasonable.

        Show
        Guillaume Nodet added a comment - I think that sounds reasonable.
        Hide
        Bill Kuker added a comment -

        Here is a patch including these changes. I do not expect it is really needed for this change, but I hope to offer more substantial patches in the future and may as well find out if I have done it right.

        Show
        Bill Kuker added a comment - Here is a patch including these changes. I do not expect it is really needed for this change, but I hope to offer more substantial patches in the future and may as well find out if I have done it right.
        Bill Kuker made changes -
        Field Original Value New Value
        Attachment SSHD-117.patch [ 12476779 ]
        Hide
        Shawn Pearce added a comment -

        Committed r1095809
        M sshd-core/src/main/java/org/apache/sshd/server/session/ServerSession.java

        Show
        Shawn Pearce added a comment - Committed r1095809 M sshd-core/src/main/java/org/apache/sshd/server/session/ServerSession.java
        Guillaume Nodet made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Shawn Pearce [ spearce ]
        Fix Version/s 0.6.0 [ 12315514 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Shawn Pearce
            Reporter:
            Bill Kuker
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development