Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.0
    • Labels:

      Description

      Allow to add listener for major event (such as when |close| method is fired) about SSH Session instance.

      Currently I've worked around by implementing my own SessionFactory, which itself return custom Session instances supporting such listener.
      With a listener on standard/provided Session instance may not require user to to do such custom implementations.

      1. slistener.patch
        5 kB
        Cédric Chantepie

        Issue Links

          Activity

          Hide
          Bernd Fondermann added a comment -

          Cédric, do you want to contribute a patch?

          Show
          Bernd Fondermann added a comment - Cédric, do you want to contribute a patch?
          Hide
          Cédric Chantepie added a comment -

          I can try

          Show
          Cédric Chantepie added a comment - I can try
          Hide
          Cédric Chantepie added a comment -

          Quick patch

          Show
          Cédric Chantepie added a comment - Quick patch
          Hide
          Guillaume Nodet added a comment -

          Hi Cédric,
          While reviewing this patch, it occured to me that it may be better to add the listeners for sessions at a upper level so that the listeners could be informed when sessions are created. I think that would be more symetric and would allow a single listener to be registered instead of having to register it for each session.

          Show
          Guillaume Nodet added a comment - Hi Cédric, While reviewing this patch, it occured to me that it may be better to add the listeners for sessions at a upper level so that the listeners could be informed when sessions are created. I think that would be more symetric and would allow a single listener to be registered instead of having to register it for each session.
          Hide
          Cédric Chantepie added a comment -

          In current patch, listeners are also added at SessionFactory level. As far as I understand it could match your expectation.
          As for listeners at Session level, I have thought that some people would prefer to "monitor" not all session but just some of them.
          It could be removed if no one think it could be useful.

          Show
          Cédric Chantepie added a comment - In current patch, listeners are also added at SessionFactory level. As far as I understand it could match your expectation. As for listeners at Session level, I have thought that some people would prefer to "monitor" not all session but just some of them. It could be removed if no one think it could be useful.
          Hide
          Guillaume Nodet added a comment -

          Thx for the patch Cédric.

          Show
          Guillaume Nodet added a comment - Thx for the patch Cédric.

            People

            • Assignee:
              Guillaume Nodet
              Reporter:
              Cédric Chantepie
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 48h
                48h
                Remaining:
                Remaining Estimate - 48h
                48h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development