Uploaded image for project: 'MINA SSHD'
  1. MINA SSHD
  2. SSHD-109

Pass server session to FileSystemFactory.createFileSystemView

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.6.0
    • Labels:
      None

      Description

      In the integration of sshd with our application we have a PasswordAuthenticator implementation which authenticates against our internal user database. From this we derive an internal user object which is needed for further permissions checking, etc in the file system view. However the createFileSystemView call takes a user name only. If the ServerSession was passed to createFileSystemView also, the user object could be stored in the session and retrieved when the file system view is created. In the current system I have to store the user object in a ThreadLocal and get it from there in createFileSystemView.

      This would require a custom session factory and session object - if the session had some internal storage for private attributes, etc (rather like an HttpSession) this would not be necessary.

        Issue Links

          Activity

          Hide
          richard.evans@datanomic.com Richard Evans added a comment -

          Yes, I've verified the functionality in HEAD. It's fine.

          Richard

          Show
          richard.evans@datanomic.com Richard Evans added a comment - Yes, I've verified the functionality in HEAD. It's fine. Richard
          Hide
          gnt Guillaume Nodet added a comment -

          @Richard: should we close this issue?

          Show
          gnt Guillaume Nodet added a comment - @Richard: should we close this issue?
          Hide
          kleij Frank van der Kleij added a comment -

          This is already part of 0.5.1-SNAPSHOT; please checkout the trunk.

          Show
          kleij Frank van der Kleij added a comment - This is already part of 0.5.1-SNAPSHOT; please checkout the trunk.

            People

            • Assignee:
              Unassigned
              Reporter:
              richard.evans@datanomic.com Richard Evans
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development