Uploaded image for project: 'MINA SSHD'
  1. MINA SSHD
  2. SSHD-102

Add error logging to org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.4.0, 0.5.0
    • Fix Version/s: 0.6.0
    • Labels:
      None
    • Environment:
      sshd JAAS used with LDAP based authentication.

      Description

      The JaasPasswordAuthenticator.authenticate() method currently silently ignores any exceptions being raised and simply returns false in case of any authentication erorrs.
      In environments where sshd is used in other frameworks like OSGi, it becomes very difficult to trouble shoot the reasons for the authentication failure.
      Rather than simply returning false, I propose to print a logging statement at the least.

      catch (Exception e)

      { log.error("Authentication failed with error: " + e.getMessage() + ", cause: " + e.getCause() ); return false; }

        Attachments

          Activity

            People

            • Assignee:
              gnt Guillaume Nodet
              Reporter:
              tmielke Torsten Mielke
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: