MINA SSHD
  1. MINA SSHD
  2. SSHD-101

[PATCH] [sftp] send correct amount of data in SSH_FXP_READ

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.0
    • Labels:
      None

      Description

      Pretty sure this was just a typo, but the SFTP spec, draft 13, specifies
      in section 8.2.1 that "The server MUST not respond with more data than
      is specified by the 'length' parameter". We were always responding with
      0-32k's worth of data, but (at least) the Mac transmit client was asking
      for only 16k chunks. This confused it, as I believe it got the length
      via stat, and then would get an early (from its point of view EOF).
      Instead of closing the file and moving on, it would hang the transfer.

      (see attached patch)

        Activity

        Guillaume Nodet made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Guillaume Nodet [ gnt ]
        Fix Version/s 0.6.0 [ 12315514 ]
        Resolution Fixed [ 1 ]
        Hide
        Guillaume Nodet added a comment -

        Thx for reporting and patching this!

        Show
        Guillaume Nodet added a comment - Thx for reporting and patching this!
        Bobby Powers made changes -
        Field Original Value New Value
        Attachment 0001-sftp-send-correct-amount-of-data-in-SSH_FXP_READ.patch [ 12466237 ]
        Bobby Powers created issue -

          People

          • Assignee:
            Guillaume Nodet
            Reporter:
            Bobby Powers
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development