Sqoop
  1. Sqoop
  2. SQOOP-933

Properly log SQLExceptions using getNextException() method for chaining exceptions

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.2
    • Fix Version/s: 1.4.4
    • Component/s: None
    • Labels:
      None

      Description

      We're not using the SQLException::getNextException in Sqoop code base, however some of the JDBC drivers do and we're not correctly logging their exceptions. I think that we should improve that.

      1. bugSQOOP-933.patch
        38 kB
        Jarek Jarcec Cecho
      2. bugSQOOP-933.patch
        35 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Hide
          Abhijeet Gaikwad added a comment -

          Thanks for the patch Jarcec.

          Show
          Abhijeet Gaikwad added a comment - Thanks for the patch Jarcec.
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop23 #800 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/800/)
          SQOOP-933: Properly log SQLExceptions using getNextException() method for chaining exceptions (Revision 05976e709df17436f8df90ee94b5e91b7f6853a2)

          Result = SUCCESS
          abhijeet : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05976e709df17436f8df90ee94b5e91b7f6853a2
          Files :

          • src/java/org/apache/sqoop/util/ResultSetPrinter.java
          • src/java/org/apache/sqoop/util/LoggingUtils.java
          • src/java/org/apache/sqoop/manager/Db2Manager.java
          • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java
          • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
          • src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          • src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
          • src/java/org/apache/sqoop/manager/OracleManager.java
          • src/java/org/apache/sqoop/manager/SqlManager.java
          • src/java/org/apache/sqoop/manager/MySQLManager.java
          • src/java/org/apache/sqoop/manager/CatalogQueryManager.java
          • src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop23 #800 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/800/ ) SQOOP-933 : Properly log SQLExceptions using getNextException() method for chaining exceptions (Revision 05976e709df17436f8df90ee94b5e91b7f6853a2) Result = SUCCESS abhijeet : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05976e709df17436f8df90ee94b5e91b7f6853a2 Files : src/java/org/apache/sqoop/util/ResultSetPrinter.java src/java/org/apache/sqoop/util/LoggingUtils.java src/java/org/apache/sqoop/manager/Db2Manager.java src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java src/java/org/apache/sqoop/mapreduce/ExportJobBase.java src/java/org/apache/sqoop/manager/OracleManager.java src/java/org/apache/sqoop/manager/SqlManager.java src/java/org/apache/sqoop/manager/MySQLManager.java src/java/org/apache/sqoop/manager/CatalogQueryManager.java src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop200 #583 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/583/)
          SQOOP-933: Properly log SQLExceptions using getNextException() method for chaining exceptions (Revision 05976e709df17436f8df90ee94b5e91b7f6853a2)

          Result = SUCCESS
          abhijeet : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05976e709df17436f8df90ee94b5e91b7f6853a2
          Files :

          • src/java/org/apache/sqoop/util/LoggingUtils.java
          • src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          • src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java
          • src/java/org/apache/sqoop/manager/SqlManager.java
          • src/java/org/apache/sqoop/manager/OracleManager.java
          • src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java
          • src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
          • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
          • src/java/org/apache/sqoop/util/ResultSetPrinter.java
          • src/java/org/apache/sqoop/manager/CatalogQueryManager.java
          • src/java/org/apache/sqoop/manager/MySQLManager.java
          • src/java/org/apache/sqoop/manager/Db2Manager.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop200 #583 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/583/ ) SQOOP-933 : Properly log SQLExceptions using getNextException() method for chaining exceptions (Revision 05976e709df17436f8df90ee94b5e91b7f6853a2) Result = SUCCESS abhijeet : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05976e709df17436f8df90ee94b5e91b7f6853a2 Files : src/java/org/apache/sqoop/util/LoggingUtils.java src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java src/java/org/apache/sqoop/manager/SqlManager.java src/java/org/apache/sqoop/manager/OracleManager.java src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java src/java/org/apache/sqoop/mapreduce/ExportJobBase.java src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java src/java/org/apache/sqoop/util/ResultSetPrinter.java src/java/org/apache/sqoop/manager/CatalogQueryManager.java src/java/org/apache/sqoop/manager/MySQLManager.java src/java/org/apache/sqoop/manager/Db2Manager.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop100 #600 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/600/)
          SQOOP-933: Properly log SQLExceptions using getNextException() method for chaining exceptions (Revision 05976e709df17436f8df90ee94b5e91b7f6853a2)

          Result = SUCCESS
          abhijeet : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05976e709df17436f8df90ee94b5e91b7f6853a2
          Files :

          • src/java/org/apache/sqoop/util/LoggingUtils.java
          • src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java
          • src/java/org/apache/sqoop/manager/MySQLManager.java
          • src/java/org/apache/sqoop/util/ResultSetPrinter.java
          • src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java
          • src/java/org/apache/sqoop/manager/SqlManager.java
          • src/java/org/apache/sqoop/manager/OracleManager.java
          • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
          • src/java/org/apache/sqoop/manager/CatalogQueryManager.java
          • src/java/org/apache/sqoop/manager/Db2Manager.java
          • src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java
          • src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop100 #600 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/600/ ) SQOOP-933 : Properly log SQLExceptions using getNextException() method for chaining exceptions (Revision 05976e709df17436f8df90ee94b5e91b7f6853a2) Result = SUCCESS abhijeet : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05976e709df17436f8df90ee94b5e91b7f6853a2 Files : src/java/org/apache/sqoop/util/LoggingUtils.java src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java src/java/org/apache/sqoop/manager/MySQLManager.java src/java/org/apache/sqoop/util/ResultSetPrinter.java src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java src/java/org/apache/sqoop/manager/SqlManager.java src/java/org/apache/sqoop/manager/OracleManager.java src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java src/java/org/apache/sqoop/manager/CatalogQueryManager.java src/java/org/apache/sqoop/manager/Db2Manager.java src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop20 #585 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/585/)
          SQOOP-933: Properly log SQLExceptions using getNextException() method for chaining exceptions (Revision 05976e709df17436f8df90ee94b5e91b7f6853a2)

          Result = SUCCESS
          abhijeet : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05976e709df17436f8df90ee94b5e91b7f6853a2
          Files :

          • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
          • src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          • src/java/org/apache/sqoop/manager/Db2Manager.java
          • src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
          • src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java
          • src/java/org/apache/sqoop/util/LoggingUtils.java
          • src/java/org/apache/sqoop/util/ResultSetPrinter.java
          • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java
          • src/java/org/apache/sqoop/manager/OracleManager.java
          • src/java/org/apache/sqoop/manager/MySQLManager.java
          • src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java
          • src/java/org/apache/sqoop/manager/SqlManager.java
          • src/java/org/apache/sqoop/manager/CatalogQueryManager.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop20 #585 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/585/ ) SQOOP-933 : Properly log SQLExceptions using getNextException() method for chaining exceptions (Revision 05976e709df17436f8df90ee94b5e91b7f6853a2) Result = SUCCESS abhijeet : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=05976e709df17436f8df90ee94b5e91b7f6853a2 Files : src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java src/java/org/apache/sqoop/manager/Db2Manager.java src/java/org/apache/sqoop/mapreduce/ExportJobBase.java src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java src/java/org/apache/sqoop/util/LoggingUtils.java src/java/org/apache/sqoop/util/ResultSetPrinter.java src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java src/java/org/apache/sqoop/manager/OracleManager.java src/java/org/apache/sqoop/manager/MySQLManager.java src/java/org/apache/sqoop/mapreduce/db/DBOutputFormat.java src/java/org/apache/sqoop/manager/SqlManager.java src/java/org/apache/sqoop/manager/CatalogQueryManager.java

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development