Sqoop
  1. Sqoop
  2. SQOOP-901

Allow user to override hardcoded boolean strings in direct PostgreSQL connector

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.2
    • Fix Version/s: 1.4.3
    • Component/s: None
    • Labels:
      None

      Description

      Direct PostgreSQL connector have hard coded values for boolean type (TRUE and FALSE). I believe that we should allow user to change them if needed.

      1. bugSQOOP-901.patch
        13 kB
        Jarek Jarcec Cecho
      2. bugSQOOP-901.patch
        11 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Jarek Jarcec Cecho created issue -
          Jarek Jarcec Cecho made changes -
          Field Original Value New Value
          Remote Link This issue links to "Review board (Web Link)" [ 12033 ]
          Jarek Jarcec Cecho made changes -
          Attachment bugSQOOP-901.patch [ 12569749 ]
          Jarek Jarcec Cecho made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jarek Jarcec Cecho made changes -
          Attachment bugSQOOP-901.patch [ 12570622 ]
          Hide
          Cheolsoo Park added a comment -

          +1.

          Committed to trunk. Thanks Jarcec!

          Show
          Cheolsoo Park added a comment - +1. Committed to trunk. Thanks Jarcec!
          Cheolsoo Park made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop200 #568 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/568/)
          SQOOP-901: Allow user to override hardcoded boolean strings in direct PostgreSQL connector (Revision 8c3c78b11cb5c2330e31cbf867d32974a011f268)

          Result = SUCCESS
          cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=8c3c78b11cb5c2330e31cbf867d32974a011f268
          Files :

          • src/docs/user/connectors.txt
          • src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java
          • src/java/org/apache/sqoop/manager/PostgresqlManager.java
          • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop200 #568 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/568/ ) SQOOP-901 : Allow user to override hardcoded boolean strings in direct PostgreSQL connector (Revision 8c3c78b11cb5c2330e31cbf867d32974a011f268) Result = SUCCESS cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=8c3c78b11cb5c2330e31cbf867d32974a011f268 Files : src/docs/user/connectors.txt src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java src/java/org/apache/sqoop/manager/PostgresqlManager.java src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop20 #573 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/573/)
          SQOOP-901: Allow user to override hardcoded boolean strings in direct PostgreSQL connector (Revision 8c3c78b11cb5c2330e31cbf867d32974a011f268)

          Result = SUCCESS
          cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=8c3c78b11cb5c2330e31cbf867d32974a011f268
          Files :

          • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          • src/java/org/apache/sqoop/manager/PostgresqlManager.java
          • src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java
          • src/docs/user/connectors.txt
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop20 #573 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/573/ ) SQOOP-901 : Allow user to override hardcoded boolean strings in direct PostgreSQL connector (Revision 8c3c78b11cb5c2330e31cbf867d32974a011f268) Result = SUCCESS cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=8c3c78b11cb5c2330e31cbf867d32974a011f268 Files : src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java src/java/org/apache/sqoop/manager/PostgresqlManager.java src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java src/docs/user/connectors.txt
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop23 #778 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/778/)
          SQOOP-901: Allow user to override hardcoded boolean strings in direct PostgreSQL connector (Revision 8c3c78b11cb5c2330e31cbf867d32974a011f268)

          Result = SUCCESS
          cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=8c3c78b11cb5c2330e31cbf867d32974a011f268
          Files :

          • src/docs/user/connectors.txt
          • src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java
          • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          • src/java/org/apache/sqoop/manager/PostgresqlManager.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop23 #778 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/778/ ) SQOOP-901 : Allow user to override hardcoded boolean strings in direct PostgreSQL connector (Revision 8c3c78b11cb5c2330e31cbf867d32974a011f268) Result = SUCCESS cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=8c3c78b11cb5c2330e31cbf867d32974a011f268 Files : src/docs/user/connectors.txt src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java src/java/org/apache/sqoop/manager/PostgresqlManager.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop100 #580 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/580/)
          SQOOP-901: Allow user to override hardcoded boolean strings in direct PostgreSQL connector (Revision 8c3c78b11cb5c2330e31cbf867d32974a011f268)

          Result = SUCCESS
          cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=8c3c78b11cb5c2330e31cbf867d32974a011f268
          Files :

          • src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java
          • src/docs/user/connectors.txt
          • src/java/org/apache/sqoop/manager/PostgresqlManager.java
          • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop100 #580 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/580/ ) SQOOP-901 : Allow user to override hardcoded boolean strings in direct PostgreSQL connector (Revision 8c3c78b11cb5c2330e31cbf867d32974a011f268) Result = SUCCESS cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=8c3c78b11cb5c2330e31cbf867d32974a011f268 Files : src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java src/docs/user/connectors.txt src/java/org/apache/sqoop/manager/PostgresqlManager.java src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development