Sqoop
  1. Sqoop
  2. SQOOP-840

Inconsistent java generics declaration for exportwriter classes

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.2
    • Fix Version/s: 1.4.3
    • Component/s: None
    • Labels:

      Description

      Several of the export writer classes have inconsistent generic declarations. This shows up with Eclipse project having a problem with SQLServer related classes. While I could simply cast the SQLServer specific class, it is good to fix the underlying issue.

      Will attach a patch

      1. SQOOP-840.patch
        6 kB
        Venkat Ranganathan

        Issue Links

          Activity

          Venkat Ranganathan created issue -
          Venkat Ranganathan made changes -
          Field Original Value New Value
          Assignee Venkat Ranganathan [ venkatnrangan ]
          Venkat Ranganathan made changes -
          Attachment SQOOP-840.patch [ 12566032 ]
          Hide
          Venkat Ranganathan added a comment -

          Attached patch

          Show
          Venkat Ranganathan added a comment - Attached patch
          Venkat Ranganathan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Affects Version/s 1.4.2 [ 12320141 ]
          Labels patch
          Hide
          Jarek Jarcec Cecho added a comment -

          Hi Venkat,
          could you please upload your patch to Apache Review board (https://reviews.apache.org)?

          Jarcec

          Show
          Jarek Jarcec Cecho added a comment - Hi Venkat, could you please upload your patch to Apache Review board ( https://reviews.apache.org)? Jarcec
          Venkat Ranganathan made changes -
          Remote Link This issue links to "Link to review board (Web Link)" [ 11977 ]
          Hide
          Venkat Ranganathan added a comment -

          Hi Jarcec

          I updated the patch to review board

          Show
          Venkat Ranganathan added a comment - Hi Jarcec I updated the patch to review board
          Hide
          Jarek Jarcec Cecho added a comment -
          Show
          Jarek Jarcec Cecho added a comment - The patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=9de589e83cc23314df215d5713848c95b6ebaf1a Thank you Venkat for your time and effort! Jarcec
          Jarek Jarcec Cecho made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 1.4.3 [ 12322644 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop20 #522 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/522/)
          SQOOP-840: Inconsistent java generics declaration for exportwriter classes (Revision 9de589e83cc23314df215d5713848c95b6ebaf1a)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=9de589e83cc23314df215d5713848c95b6ebaf1a
          Files :

          • src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java
          • src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop20 #522 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/522/ ) SQOOP-840 : Inconsistent java generics declaration for exportwriter classes (Revision 9de589e83cc23314df215d5713848c95b6ebaf1a) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=9de589e83cc23314df215d5713848c95b6ebaf1a Files : src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop23 #718 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/718/)
          SQOOP-840: Inconsistent java generics declaration for exportwriter classes (Revision 9de589e83cc23314df215d5713848c95b6ebaf1a)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=9de589e83cc23314df215d5713848c95b6ebaf1a
          Files :

          • src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java
          • src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop23 #718 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/718/ ) SQOOP-840 : Inconsistent java generics declaration for exportwriter classes (Revision 9de589e83cc23314df215d5713848c95b6ebaf1a) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=9de589e83cc23314df215d5713848c95b6ebaf1a Files : src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop200 #524 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/524/)
          SQOOP-840: Inconsistent java generics declaration for exportwriter classes (Revision 9de589e83cc23314df215d5713848c95b6ebaf1a)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=9de589e83cc23314df215d5713848c95b6ebaf1a
          Files :

          • src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java
          • src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop200 #524 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/524/ ) SQOOP-840 : Inconsistent java generics declaration for exportwriter classes (Revision 9de589e83cc23314df215d5713848c95b6ebaf1a) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=9de589e83cc23314df215d5713848c95b6ebaf1a Files : src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop100 #516 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/516/)
          SQOOP-840: Inconsistent java generics declaration for exportwriter classes (Revision 9de589e83cc23314df215d5713848c95b6ebaf1a)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=9de589e83cc23314df215d5713848c95b6ebaf1a
          Files :

          • src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java
          • src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java
          • src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop100 #516 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/516/ ) SQOOP-840 : Inconsistent java generics declaration for exportwriter classes (Revision 9de589e83cc23314df215d5713848c95b6ebaf1a) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=9de589e83cc23314df215d5713848c95b6ebaf1a Files : src/java/org/apache/sqoop/mapreduce/OracleExportOutputFormat.java src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java src/java/org/apache/sqoop/mapreduce/ExportBatchOutputFormat.java src/java/org/apache/sqoop/mapreduce/SQLServerExportOutputFormat.java
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          4m 17s 1 Venkat Ranganathan 22/Jan/13 22:17
          Patch Available Patch Available Resolved Resolved
          19h 28m 1 Jarek Jarcec Cecho 23/Jan/13 17:46

            People

            • Assignee:
              Venkat Ranganathan
              Reporter:
              Venkat Ranganathan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development