Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-829

Error Messages For --map-column-java Should Be More Useful

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.2
    • Fix Version/s: 1.4.3
    • Component/s: build
    • Labels:

      Description

      Currently, if --map-column-java is given an invalid type the Codegen tool just generates some mangled Java code, which javac then refuses to compile. The attached patch fails faster, and with a clearer error message.

        Activity

        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        The patch is quite simple, so I'm giving my +1 here.

        Jarcec

        Show
        jarcec Jarek Jarcec Cecho added a comment - The patch is quite simple, so I'm giving my +1 here. Jarcec
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        The patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=2b0456d6ce4b1e20bdd292c992efe231965372ae
        (I've removed unnecessary reordering of import statements prior committing)

        Thank you Nick for your contribution!

        Jarcec

        Show
        jarcec Jarek Jarcec Cecho added a comment - The patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=2b0456d6ce4b1e20bdd292c992efe231965372ae (I've removed unnecessary reordering of import statements prior committing) Thank you Nick for your contribution! Jarcec
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop200 #504 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/504/)
        SQOOP-829: Error Messages For --map-column-java Should Be More Useful (Revision 2b0456d6ce4b1e20bdd292c992efe231965372ae)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=2b0456d6ce4b1e20bdd292c992efe231965372ae
        Files :

        • src/test/com/cloudera/sqoop/orm/TestClassWriter.java
        • src/java/org/apache/sqoop/orm/ClassWriter.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop200 #504 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/504/ ) SQOOP-829 : Error Messages For --map-column-java Should Be More Useful (Revision 2b0456d6ce4b1e20bdd292c992efe231965372ae) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=2b0456d6ce4b1e20bdd292c992efe231965372ae Files : src/test/com/cloudera/sqoop/orm/TestClassWriter.java src/java/org/apache/sqoop/orm/ClassWriter.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop20 #513 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/513/)
        SQOOP-829: Error Messages For --map-column-java Should Be More Useful (Revision 2b0456d6ce4b1e20bdd292c992efe231965372ae)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=2b0456d6ce4b1e20bdd292c992efe231965372ae
        Files :

        • src/test/com/cloudera/sqoop/orm/TestClassWriter.java
        • src/java/org/apache/sqoop/orm/ClassWriter.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop20 #513 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/513/ ) SQOOP-829 : Error Messages For --map-column-java Should Be More Useful (Revision 2b0456d6ce4b1e20bdd292c992efe231965372ae) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=2b0456d6ce4b1e20bdd292c992efe231965372ae Files : src/test/com/cloudera/sqoop/orm/TestClassWriter.java src/java/org/apache/sqoop/orm/ClassWriter.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop23 #709 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/709/)
        SQOOP-829: Error Messages For --map-column-java Should Be More Useful (Revision 2b0456d6ce4b1e20bdd292c992efe231965372ae)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=2b0456d6ce4b1e20bdd292c992efe231965372ae
        Files :

        • src/java/org/apache/sqoop/orm/ClassWriter.java
        • src/test/com/cloudera/sqoop/orm/TestClassWriter.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop23 #709 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/709/ ) SQOOP-829 : Error Messages For --map-column-java Should Be More Useful (Revision 2b0456d6ce4b1e20bdd292c992efe231965372ae) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=2b0456d6ce4b1e20bdd292c992efe231965372ae Files : src/java/org/apache/sqoop/orm/ClassWriter.java src/test/com/cloudera/sqoop/orm/TestClassWriter.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop100 #497 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/497/)
        SQOOP-829: Error Messages For --map-column-java Should Be More Useful (Revision 2b0456d6ce4b1e20bdd292c992efe231965372ae)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=2b0456d6ce4b1e20bdd292c992efe231965372ae
        Files :

        • src/java/org/apache/sqoop/orm/ClassWriter.java
        • src/test/com/cloudera/sqoop/orm/TestClassWriter.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop100 #497 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/497/ ) SQOOP-829 : Error Messages For --map-column-java Should Be More Useful (Revision 2b0456d6ce4b1e20bdd292c992efe231965372ae) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=2b0456d6ce4b1e20bdd292c992efe231965372ae Files : src/java/org/apache/sqoop/orm/ClassWriter.java src/test/com/cloudera/sqoop/orm/TestClassWriter.java

          People

          • Assignee:
            njw45 Nick White
            Reporter:
            njw45 Nick White
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development