Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-636

ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.4.2
    • Fix Version/s: 1.4.3
    • Component/s: None
    • Labels:

      Description

      The utility method runExport creates Sqoop object with out Configuration and SqoopOptions which has the side effect of ignoring what is overridden by the implementing class and creates new ones. ImportJobTestCase does the right thing.

      1. SQOOP-636.patch
        0.9 kB
        Venkatesh Seetharam

        Activity

        Hide
        svenkat Venkatesh Seetharam added a comment -

        A trivial patch to reuse the existing Configuration and SqoopOptions before invoking runSqoop.

        Show
        svenkat Venkatesh Seetharam added a comment - A trivial patch to reuse the existing Configuration and SqoopOptions before invoking runSqoop.
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Hi Venkatesh,
        thank you very much for your patch. It seems you missed import statement for classes Configuration and SqoopOptions, so that compilation of tests will fail. Would you mind adding those imports and resubmitting your patch?

        Jarcec

        Show
        jarcec Jarek Jarcec Cecho added a comment - Hi Venkatesh, thank you very much for your patch. It seems you missed import statement for classes Configuration and SqoopOptions, so that compilation of tests will fail. Would you mind adding those imports and resubmitting your patch? Jarcec
        Hide
        svenkat Venkatesh Seetharam added a comment -

        Apologies, that was irresponsible on my part. Not sure how it happened. New patch up with the imports, compiles and tests work.

        Show
        svenkat Venkatesh Seetharam added a comment - Apologies, that was irresponsible on my part. Not sure how it happened. New patch up with the imports, compiles and tests work.
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        It's pretty small patch, so I'm giving my +1 here.

        Show
        jarcec Jarek Jarcec Cecho added a comment - It's pretty small patch, so I'm giving my +1 here.
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        The patch has been committed: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=695666acdbef7b979d2cd64dd96d1808d7241fc0

        Thank you very much for your contribution Venkatesh!

        Jarcec

        Show
        jarcec Jarek Jarcec Cecho added a comment - The patch has been committed: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=695666acdbef7b979d2cd64dd96d1808d7241fc0 Thank you very much for your contribution Venkatesh! Jarcec
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop23 #384 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/384/)
        SQOOP-636: ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0
        Files :

        • src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop23 #384 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/384/ ) SQOOP-636 : ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0 Files : src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop200 #251 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/251/)
        SQOOP-636: ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0
        Files :

        • src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop200 #251 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/251/ ) SQOOP-636 : ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0 Files : src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop20 #242 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/242/)
        SQOOP-636: ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0
        Files :

        • src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop20 #242 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/242/ ) SQOOP-636 : ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0 Files : src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop100 #233 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/233/)
        SQOOP-636: ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0
        Files :

        • src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop100 #233 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/233/ ) SQOOP-636 : ExportJobTestCase.runExport method does not reuse the existing Configuration and SqoopOptions (Revision 695666acdbef7b979d2cd64dd96d1808d7241fc0) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=695666acdbef7b979d2cd64dd96d1808d7241fc0 Files : src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java

          People

          • Assignee:
            svenkat Venkatesh Seetharam
            Reporter:
            svenkat Venkatesh Seetharam
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development