Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-628

Postgres direct import fails on non-lowercase column names

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.2
    • Fix Version/s: 1.4.3
    • Component/s: connectors/postgresql
    • Labels:
      None

      Description

      Postgresql requires non-lowercase column names to be escaped. Sqoop currently does this for the JDBC client but does not for the direct import.

      I've attached a patch that brings column escaping from the JDBC side to the direct import.

        Activity

        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Hi Paul,
        thank you very much for your contribution. Would you mind uploading your patch to Apache review board (https://reviews.apache.org) so that we can further review it?

        Show
        jarcec Jarek Jarcec Cecho added a comment - Hi Paul, thank you very much for your contribution. Would you mind uploading your patch to Apache review board ( https://reviews.apache.org ) so that we can further review it?
        Hide
        paulgb Paul Butler added a comment -

        I've added it to the review board:

        https://reviews.apache.org/r/7567/

        Show
        paulgb Paul Butler added a comment - I've added it to the review board: https://reviews.apache.org/r/7567/
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Committed: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=3aed0316760fcfa97553fbffc61dcaf506040a34

        Thank you very much for your contribution Paul! I appreciate your time.

        Jarcec

        Show
        jarcec Jarek Jarcec Cecho added a comment - Committed: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=3aed0316760fcfa97553fbffc61dcaf506040a34 Thank you very much for your contribution Paul! I appreciate your time. Jarcec
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop20 #191 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/191/)
        SQOOP-628: Postgres direct import fails on non-lowercase column names (Revision 3aed0316760fcfa97553fbffc61dcaf506040a34)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3aed0316760fcfa97553fbffc61dcaf506040a34
        Files :

        • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
        • src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop20 #191 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/191/ ) SQOOP-628 : Postgres direct import fails on non-lowercase column names (Revision 3aed0316760fcfa97553fbffc61dcaf506040a34) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3aed0316760fcfa97553fbffc61dcaf506040a34 Files : src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop23 #335 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/335/)
        SQOOP-628: Postgres direct import fails on non-lowercase column names (Revision 3aed0316760fcfa97553fbffc61dcaf506040a34)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3aed0316760fcfa97553fbffc61dcaf506040a34
        Files :

        • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
        • src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop23 #335 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/335/ ) SQOOP-628 : Postgres direct import fails on non-lowercase column names (Revision 3aed0316760fcfa97553fbffc61dcaf506040a34) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3aed0316760fcfa97553fbffc61dcaf506040a34 Files : src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop100 #190 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/190/)
        SQOOP-628: Postgres direct import fails on non-lowercase column names (Revision 3aed0316760fcfa97553fbffc61dcaf506040a34)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3aed0316760fcfa97553fbffc61dcaf506040a34
        Files :

        • src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java
        • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop100 #190 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/190/ ) SQOOP-628 : Postgres direct import fails on non-lowercase column names (Revision 3aed0316760fcfa97553fbffc61dcaf506040a34) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3aed0316760fcfa97553fbffc61dcaf506040a34 Files : src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop200 #190 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/190/)
        SQOOP-628: Postgres direct import fails on non-lowercase column names (Revision 3aed0316760fcfa97553fbffc61dcaf506040a34)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3aed0316760fcfa97553fbffc61dcaf506040a34
        Files :

        • src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java
        • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop200 #190 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/190/ ) SQOOP-628 : Postgres direct import fails on non-lowercase column names (Revision 3aed0316760fcfa97553fbffc61dcaf506040a34) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3aed0316760fcfa97553fbffc61dcaf506040a34 Files : src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java

          People

          • Assignee:
            paulbutler Paul Butler
            Reporter:
            paulgb Paul Butler
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development