Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-579

Simple refactoring of org.apache.sqoop.manager.DefaultManagerFactory - extract methods for reuse

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.1-incubating
    • Fix Version/s: 1.4.3
    • Component/s: connectors
    • Labels:
      None

      Description

      Would like to extract couple of code fragments into methods so custom manager factories can reuse 'em.

      • Extracting scheme from options
      • factory method for doling out a connection manager for a given class name
      1. SQOOP-579.patch
        3 kB
        Venkatesh Seetharam

        Activity

        Hide
        svenkat Venkatesh Seetharam added a comment -

        Attached a patch which is trivial.

        Show
        svenkat Venkatesh Seetharam added a comment - Attached a patch which is trivial.
        Hide
        svenkat Venkatesh Seetharam added a comment -

        Does not apply cleanly on trunk. Will update this.

        Show
        svenkat Venkatesh Seetharam added a comment - Does not apply cleanly on trunk. Will update this.
        Hide
        svenkat Venkatesh Seetharam added a comment -

        Attaching latest one.

        Show
        svenkat Venkatesh Seetharam added a comment - Attaching latest one.
        Hide
        abhijeet_gaikwad Abhijeet Gaikwad added a comment -

        Looks good.
        Just one minor change: extractSchemeFrom() name seems incomplete, can you change it to extractSchemeFromJDBCUrl() or maybe extractScheme(). Please upload the new patch.

        Thanks.

        Show
        abhijeet_gaikwad Abhijeet Gaikwad added a comment - Looks good. Just one minor change: extractSchemeFrom() name seems incomplete, can you change it to extractSchemeFromJDBCUrl() or maybe extractScheme(). Please upload the new patch. Thanks.
        Hide
        svenkat Venkatesh Seetharam added a comment -

        extractSchemeFrom(SqoopOptions options) implies extract scheme from the parameter options. Perhaps its a style issue.

        replaces it with extractScheme.

        Show
        svenkat Venkatesh Seetharam added a comment - extractSchemeFrom(SqoopOptions options) implies extract scheme from the parameter options. Perhaps its a style issue. replaces it with extractScheme.
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Patch is quite simple, so I'm bypassing review board and giving my +1 here.

        Jarcec

        Show
        jarcec Jarek Jarcec Cecho added a comment - Patch is quite simple, so I'm bypassing review board and giving my +1 here. Jarcec
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Committed revision 1375401.

        Thank you for your contribution Venkatesh!

        Jarcec

        Show
        jarcec Jarek Jarcec Cecho added a comment - Committed revision 1375401. Thank you for your contribution Venkatesh! Jarcec
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop200 #3 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/3/)
        SQOOP-579. Simple refactoring of org.apache.sqoop.manager.DefaultManagerFactory - extract methods for reuse.

        (Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375401)

        Result = SUCCESS
        jarcec :
        Files :

        • /sqoop/trunk/src/java/org/apache/sqoop/manager/DefaultManagerFactory.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop200 #3 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/3/ ) SQOOP-579 . Simple refactoring of org.apache.sqoop.manager.DefaultManagerFactory - extract methods for reuse. (Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375401) Result = SUCCESS jarcec : Files : /sqoop/trunk/src/java/org/apache/sqoop/manager/DefaultManagerFactory.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop23 #142 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/142/)
        SQOOP-579. Simple refactoring of org.apache.sqoop.manager.DefaultManagerFactory - extract methods for reuse.

        (Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375401)

        Result = SUCCESS
        jarcec :
        Files :

        • /sqoop/trunk/src/java/org/apache/sqoop/manager/DefaultManagerFactory.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop23 #142 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/142/ ) SQOOP-579 . Simple refactoring of org.apache.sqoop.manager.DefaultManagerFactory - extract methods for reuse. (Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375401) Result = SUCCESS jarcec : Files : /sqoop/trunk/src/java/org/apache/sqoop/manager/DefaultManagerFactory.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop20 #13 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/13/)
        SQOOP-579. Simple refactoring of org.apache.sqoop.manager.DefaultManagerFactory - extract methods for reuse.

        (Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375401)

        Result = SUCCESS
        jarcec :
        Files :

        • /sqoop/trunk/src/java/org/apache/sqoop/manager/DefaultManagerFactory.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop20 #13 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/13/ ) SQOOP-579 . Simple refactoring of org.apache.sqoop.manager.DefaultManagerFactory - extract methods for reuse. (Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375401) Result = SUCCESS jarcec : Files : /sqoop/trunk/src/java/org/apache/sqoop/manager/DefaultManagerFactory.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop100 #13 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/13/)
        SQOOP-579. Simple refactoring of org.apache.sqoop.manager.DefaultManagerFactory - extract methods for reuse.

        (Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375401)

        Result = SUCCESS
        jarcec :
        Files :

        • /sqoop/trunk/src/java/org/apache/sqoop/manager/DefaultManagerFactory.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop100 #13 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/13/ ) SQOOP-579 . Simple refactoring of org.apache.sqoop.manager.DefaultManagerFactory - extract methods for reuse. (Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375401) Result = SUCCESS jarcec : Files : /sqoop/trunk/src/java/org/apache/sqoop/manager/DefaultManagerFactory.java

          People

          • Assignee:
            svenkat Venkatesh Seetharam
            Reporter:
            svenkat Venkatesh Seetharam
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development