Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-438

allow sourcing of sqoop-env.sh to set various environment variables

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0-incubating
    • Fix Version/s: 1.4.2
    • Component/s: None
    • Labels:
      None

      Description

      currently if you want to use a different path for HADOOP_HOME than expected you have to specify --hadoop-home or export HADOOP_HOME env var.

      We could add sqoop-env.sh and source it in bin/configure-sqoop so the users can actually set the variables in conf rather than having to do it every time sqoop is invoked.

      1. SQOOP-438.patch
        2 kB
        Arpit Gupta
      2. SQOOP-438.patch
        2 kB
        Arpit Gupta

        Activity

        Hide
        arpitgupta Arpit Gupta added a comment -

        attached a patch for source sqoop-env.sh

        Show
        arpitgupta Arpit Gupta added a comment - attached a patch for source sqoop-env.sh
        Hide
        arpitgupta Arpit Gupta added a comment -

        add export in the sqoop-env-template.sh

        Show
        arpitgupta Arpit Gupta added a comment - add export in the sqoop-env-template.sh
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Hi Arpit,
        thank you very much for your idea and time spent on this issue. Would you mind uploading your patch to Apache review board for review process? (https://reviews.apache.org).

        Jarcec

        Show
        jarcec Jarek Jarcec Cecho added a comment - Hi Arpit, thank you very much for your idea and time spent on this issue. Would you mind uploading your patch to Apache review board for review process? ( https://reviews.apache.org ). Jarcec
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3935/
        -----------------------------------------------------------

        Review request for Sqoop.

        Summary
        -------

        allow sourcing of sqoop-env.sh to set various env vars.

        This addresses bug SQOOP-438.
        https://issues.apache.org/jira/browse/SQOOP-438

        Diffs


        bin/configure-sqoop 9101d53
        conf/sqoop-env-template.sh PRE-CREATION

        Diff: https://reviews.apache.org/r/3935/diff

        Testing
        -------

        used sqoop with this patch applied and did not have to export HADOOP_HOME, HIVE_HOME and HBASE_HOME etc

        Thanks,

        Arpit

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3935/ ----------------------------------------------------------- Review request for Sqoop. Summary ------- allow sourcing of sqoop-env.sh to set various env vars. This addresses bug SQOOP-438 . https://issues.apache.org/jira/browse/SQOOP-438 Diffs bin/configure-sqoop 9101d53 conf/sqoop-env-template.sh PRE-CREATION Diff: https://reviews.apache.org/r/3935/diff Testing ------- used sqoop with this patch applied and did not have to export HADOOP_HOME, HIVE_HOME and HBASE_HOME etc Thanks, Arpit
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3935/#review5210
        -----------------------------------------------------------

        Ship it!

        Thank you for your time Arpid!

        • Jarek

        On 2012-02-16 21:00:45, Arpit Gupta wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3935/

        -----------------------------------------------------------

        (Updated 2012-02-16 21:00:45)

        Review request for Sqoop.

        Summary

        -------

        allow sourcing of sqoop-env.sh to set various env vars.

        This addresses bug SQOOP-438.

        https://issues.apache.org/jira/browse/SQOOP-438

        Diffs

        -----

        bin/configure-sqoop 9101d53

        conf/sqoop-env-template.sh PRE-CREATION

        Diff: https://reviews.apache.org/r/3935/diff

        Testing

        -------

        used sqoop with this patch applied and did not have to export HADOOP_HOME, HIVE_HOME and HBASE_HOME etc

        Thanks,

        Arpit

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3935/#review5210 ----------------------------------------------------------- Ship it! Thank you for your time Arpid! Jarek On 2012-02-16 21:00:45, Arpit Gupta wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3935/ ----------------------------------------------------------- (Updated 2012-02-16 21:00:45) Review request for Sqoop. Summary ------- allow sourcing of sqoop-env.sh to set various env vars. This addresses bug SQOOP-438 . https://issues.apache.org/jira/browse/SQOOP-438 Diffs ----- bin/configure-sqoop 9101d53 conf/sqoop-env-template.sh PRE-CREATION Diff: https://reviews.apache.org/r/3935/diff Testing ------- used sqoop with this patch applied and did not have to export HADOOP_HOME, HIVE_HOME and HBASE_HOME etc Thanks, Arpit
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Patch committed, thank you very much Arpit!

        Show
        jarcec Jarek Jarcec Cecho added a comment - Patch committed, thank you very much Arpit!
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6 #87 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/87/)
        SQOOP-438. allow sourcing of sqoop-env.sh to set various environment variables

        (Arpit Gupta via Jarek Jarcec Cecho) (Revision 1292917)

        Result = SUCCESS
        jarcec : http://svn.apache.org/viewvc/?view=rev&rev=1292917
        Files :

        • /incubator/sqoop/trunk/bin/configure-sqoop
        • /incubator/sqoop/trunk/conf/sqoop-env-template.sh
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6 #87 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/87/ ) SQOOP-438 . allow sourcing of sqoop-env.sh to set various environment variables (Arpit Gupta via Jarek Jarcec Cecho) (Revision 1292917) Result = SUCCESS jarcec : http://svn.apache.org/viewvc/?view=rev&rev=1292917 Files : /incubator/sqoop/trunk/bin/configure-sqoop /incubator/sqoop/trunk/conf/sqoop-env-template.sh

          People

          • Assignee:
            arpitgupta Arpit Gupta
            Reporter:
            arpitgupta Arpit Gupta
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development