Sqoop
  1. Sqoop
  2. SQOOP-425

Sqoop invokes ResultSet.isLast() which causes Sybase JDBC driver to hang

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.4.2
    • Component/s: None
    • Labels:
      None

      Description

      The call to ResultSet.isLast() should be replaced by ResultSet.isAfterLast() where necessary in order to help support Sybase for data import.

      1. SQOOP-425.patch
        0.6 kB
        Cheolsoo Park

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4075/
        -----------------------------------------------------------

        Review request for Sqoop and Bilung Lee.

        Summary
        -------

        The call to ResultSet.isLast() should be replaced by ResultSet.isAfterLast() where necessary in order to help support Sybase for data import.

        This addresses bug SQOOP-425.
        https://issues.apache.org/jira/browse/SQOOP-425

        Diffs


        ./src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1294374

        Diff: https://reviews.apache.org/r/4075/diff

        Testing
        -------

        Ran ant test

        Thanks,

        Cheolsoo

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4075/ ----------------------------------------------------------- Review request for Sqoop and Bilung Lee. Summary ------- The call to ResultSet.isLast() should be replaced by ResultSet.isAfterLast() where necessary in order to help support Sybase for data import. This addresses bug SQOOP-425 . https://issues.apache.org/jira/browse/SQOOP-425 Diffs ./src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1294374 Diff: https://reviews.apache.org/r/4075/diff Testing ------- Ran ant test Thanks, Cheolsoo
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4075/#review5370
        -----------------------------------------------------------

        Ship it!

        Thanks for the patch!

        • Bilung

        On 2012-02-27 23:28:35, Cheolsoo Park wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4075/

        -----------------------------------------------------------

        (Updated 2012-02-27 23:28:35)

        Review request for Sqoop and Bilung Lee.

        Summary

        -------

        The call to ResultSet.isLast() should be replaced by ResultSet.isAfterLast() where necessary in order to help support Sybase for data import.

        This addresses bug SQOOP-425.

        https://issues.apache.org/jira/browse/SQOOP-425

        Diffs

        -----

        ./src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1294374

        Diff: https://reviews.apache.org/r/4075/diff

        Testing

        -------

        Ran ant test

        Thanks,

        Cheolsoo

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4075/#review5370 ----------------------------------------------------------- Ship it! Thanks for the patch! Bilung On 2012-02-27 23:28:35, Cheolsoo Park wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4075/ ----------------------------------------------------------- (Updated 2012-02-27 23:28:35) Review request for Sqoop and Bilung Lee. Summary ------- The call to ResultSet.isLast() should be replaced by ResultSet.isAfterLast() where necessary in order to help support Sybase for data import. This addresses bug SQOOP-425 . https://issues.apache.org/jira/browse/SQOOP-425 Diffs ----- ./src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java 1294374 Diff: https://reviews.apache.org/r/4075/diff Testing ------- Ran ant test Thanks, Cheolsoo
        Hide
        Bilung Lee added a comment -

        Thanks, Cheolsoo! Patch committed.

        Show
        Bilung Lee added a comment - Thanks, Cheolsoo! Patch committed.
        Hide
        Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6 #88 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/88/)
        SQOOP-425 Sqoop invokes ResultSet.isLast() which causes Sybase JDBC driver to hang (Revision 1294396)

        Result = SUCCESS
        blee : http://svn.apache.org/viewvc/?view=rev&rev=1294396
        Files :

        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java
        Show
        Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6 #88 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/88/ ) SQOOP-425 Sqoop invokes ResultSet.isLast() which causes Sybase JDBC driver to hang (Revision 1294396) Result = SUCCESS blee : http://svn.apache.org/viewvc/?view=rev&rev=1294396 Files : /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBRecordReader.java

          People

          • Assignee:
            Cheolsoo Park
            Reporter:
            Arvind Prabhakar
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development