Uploaded image for project: 'Sqoop (Retired)'
  1. Sqoop (Retired)
  2. SQOOP-422

Throw an exception when --direct and hbase* options are used together

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.3.0, 1.4.0-incubating, 1.4.1-incubating
    • 1.4.1-incubating
    • hbase-integration
    • None

    Description

      Currently if --direct is passed to sqoop it silently ignores any hbase* options and writes directly to hdfs. It should throw an exception when those incompatible options are specified.

      Attachments

        1. SQOOP-422.patch
          0.6 kB
          Jarek Jarcec Cecho
        2. SQOOP-422.patch
          0.6 kB
          Jarek Jarcec Cecho

        Activity

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3429/
          -----------------------------------------------------------

          Review request for Sqoop and Arvind Prabhakar.

          Summary
          -------

          Just small patch that is ensuring that user did not specify both --direct and --hbase-table parameters together.

          This addresses bug SQOOP-422.
          https://issues.apache.org/jira/browse/SQOOP-422

          Diffs


          /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1228879

          Diff: https://reviews.apache.org/r/3429/diff

          Testing
          -------

          It passes tests.

          Thanks,

          Jarek

          jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3429/ ----------------------------------------------------------- Review request for Sqoop and Arvind Prabhakar. Summary ------- Just small patch that is ensuring that user did not specify both --direct and --hbase-table parameters together. This addresses bug SQOOP-422 . https://issues.apache.org/jira/browse/SQOOP-422 Diffs /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1228879 Diff: https://reviews.apache.org/r/3429/diff Testing ------- It passes tests. Thanks, Jarek

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3429/#review4243
          -----------------------------------------------------------

          Ship it!

          • Alex

          On 2012-01-08 16:30:21, Jarek Cecho wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/3429/

          -----------------------------------------------------------

          (Updated 2012-01-08 16:30:21)

          Review request for Sqoop and Arvind Prabhakar.

          Summary

          -------

          Just small patch that is ensuring that user did not specify both --direct and --hbase-table parameters together.

          This addresses bug SQOOP-422.

          https://issues.apache.org/jira/browse/SQOOP-422

          Diffs

          -----

          /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1228879

          Diff: https://reviews.apache.org/r/3429/diff

          Testing

          -------

          It passes tests.

          Thanks,

          Jarek

          jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3429/#review4243 ----------------------------------------------------------- Ship it! Alex On 2012-01-08 16:30:21, Jarek Cecho wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3429/ ----------------------------------------------------------- (Updated 2012-01-08 16:30:21) Review request for Sqoop and Arvind Prabhakar. Summary ------- Just small patch that is ensuring that user did not specify both --direct and --hbase-table parameters together. This addresses bug SQOOP-422 . https://issues.apache.org/jira/browse/SQOOP-422 Diffs ----- /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1228879 Diff: https://reviews.apache.org/r/3429/diff Testing ------- It passes tests. Thanks, Jarek

          On 2012-01-08 16:31:41, Alex Newman wrote:

          >

          Patch it already submitted to JIRA, feel free to commit it.

          • Jarek

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3429/#review4243
          -----------------------------------------------------------

          On 2012-01-08 16:30:21, Jarek Cecho wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/3429/

          -----------------------------------------------------------

          (Updated 2012-01-08 16:30:21)

          Review request for Sqoop and Arvind Prabhakar.

          Summary

          -------

          Just small patch that is ensuring that user did not specify both --direct and --hbase-table parameters together.

          This addresses bug SQOOP-422.

          https://issues.apache.org/jira/browse/SQOOP-422

          Diffs

          -----

          /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1228879

          Diff: https://reviews.apache.org/r/3429/diff

          Testing

          -------

          It passes tests.

          Thanks,

          Jarek

          jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - On 2012-01-08 16:31:41, Alex Newman wrote: > Patch it already submitted to JIRA, feel free to commit it. Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3429/#review4243 ----------------------------------------------------------- On 2012-01-08 16:30:21, Jarek Cecho wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3429/ ----------------------------------------------------------- (Updated 2012-01-08 16:30:21) Review request for Sqoop and Arvind Prabhakar. Summary ------- Just small patch that is ensuring that user did not specify both --direct and --hbase-table parameters together. This addresses bug SQOOP-422 . https://issues.apache.org/jira/browse/SQOOP-422 Diffs ----- /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1228879 Diff: https://reviews.apache.org/r/3429/diff Testing ------- It passes tests. Thanks, Jarek

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3429/
          -----------------------------------------------------------

          (Updated 2012-01-27 20:00:10.538826)

          Review request for Sqoop and Arvind Prabhakar.

          Changes
          -------

          I've fixed check style violations.

          Summary
          -------

          Just small patch that is ensuring that user did not specify both --direct and --hbase-table parameters together.

          This addresses bug SQOOP-422.
          https://issues.apache.org/jira/browse/SQOOP-422

          Diffs (updated)


          /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1236857

          Diff: https://reviews.apache.org/r/3429/diff

          Testing
          -------

          It passes tests.

          Thanks,

          Jarek

          jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3429/ ----------------------------------------------------------- (Updated 2012-01-27 20:00:10.538826) Review request for Sqoop and Arvind Prabhakar. Changes ------- I've fixed check style violations. Summary ------- Just small patch that is ensuring that user did not specify both --direct and --hbase-table parameters together. This addresses bug SQOOP-422 . https://issues.apache.org/jira/browse/SQOOP-422 Diffs (updated) /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1236857 Diff: https://reviews.apache.org/r/3429/diff Testing ------- It passes tests. Thanks, Jarek

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/3429/#review4661
          -----------------------------------------------------------

          Ship it!

          Thanks for the update!

          • Bilung

          On 2012-01-27 20:00:10, Jarek Cecho wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/3429/

          -----------------------------------------------------------

          (Updated 2012-01-27 20:00:10)

          Review request for Sqoop and Arvind Prabhakar.

          Summary

          -------

          Just small patch that is ensuring that user did not specify both --direct and --hbase-table parameters together.

          This addresses bug SQOOP-422.

          https://issues.apache.org/jira/browse/SQOOP-422

          Diffs

          -----

          /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1236857

          Diff: https://reviews.apache.org/r/3429/diff

          Testing

          -------

          It passes tests.

          Thanks,

          Jarek

          jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3429/#review4661 ----------------------------------------------------------- Ship it! Thanks for the update! Bilung On 2012-01-27 20:00:10, Jarek Cecho wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3429/ ----------------------------------------------------------- (Updated 2012-01-27 20:00:10) Review request for Sqoop and Arvind Prabhakar. Summary ------- Just small patch that is ensuring that user did not specify both --direct and --hbase-table parameters together. This addresses bug SQOOP-422 . https://issues.apache.org/jira/browse/SQOOP-422 Diffs ----- /src/java/org/apache/sqoop/tool/BaseSqoopTool.java 1236857 Diff: https://reviews.apache.org/r/3429/diff Testing ------- It passes tests. Thanks, Jarek
          bleeapache Bilung Lee added a comment -

          Patch committed. Thanks!

          bleeapache Bilung Lee added a comment - Patch committed. Thanks!
          hudson Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6 #81 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/81/)
          SQOOP-422. Throw an exception when --direct and hbase* options are used together

          blee : http://svn.apache.org/viewvc/?view=rev&rev=1236903
          Files :

          • /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/BaseSqoopTool.java
          hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6 #81 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/81/ ) SQOOP-422 . Throw an exception when --direct and hbase* options are used together blee : http://svn.apache.org/viewvc/?view=rev&rev=1236903 Files : /incubator/sqoop/trunk/src/java/org/apache/sqoop/tool/BaseSqoopTool.java

          People

            jarcec Jarek Jarcec Cecho
            oliver_meyn Oliver Meyn
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: