Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      1. Migrate those classes directly under sqoop package.
      2. Make sure checkstyle runs clean.

      1. SQOOP-386.patch
        188 kB
        Bilung Lee

        Activity

        Hide
        Arvind Prabhakar added a comment -

        Patch committed. Thanks Bilung!

        Show
        Arvind Prabhakar added a comment - Patch committed. Thanks Bilung!
        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #53 (See https://builds.apache.org/job/Sqoop-jdk-1.6/53/)
        SQOOP-386. Namespace migration cleanup.

        (Bilung Lee via Arvind Prabhakar)

        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1196486
        Files :

        • /incubator/sqoop/trunk/NOTICE.txt
        • /incubator/sqoop/trunk/src/docs/dev/SqoopDevGuide.txt
        • /incubator/sqoop/trunk/src/docs/dev/api-reference.txt
        • /incubator/sqoop/trunk/src/docs/dev/compiling.txt
        • /incubator/sqoop/trunk/src/docs/dev/intro.txt
        • /incubator/sqoop/trunk/src/docs/dev/preface.txt
        • /incubator/sqoop/trunk/src/docs/man/codegen-args.txt
        • /incubator/sqoop/trunk/src/docs/man/common-args.txt
        • /incubator/sqoop/trunk/src/docs/man/hbase-args.txt
        • /incubator/sqoop/trunk/src/docs/man/hive-args.txt
        • /incubator/sqoop/trunk/src/docs/man/import-args.txt
        • /incubator/sqoop/trunk/src/docs/man/input-args.txt
        • /incubator/sqoop/trunk/src/docs/man/output-args.txt
        • /incubator/sqoop/trunk/src/docs/sip/INDEX.txt
        • /incubator/sqoop/trunk/src/docs/sip/README.txt
        • /incubator/sqoop/trunk/src/docs/sip/sip-1.txt
        • /incubator/sqoop/trunk/src/docs/sip/sip-2.txt
        • /incubator/sqoop/trunk/src/docs/sip/sip-3.txt
        • /incubator/sqoop/trunk/src/docs/sip/sip-4.txt
        • /incubator/sqoop/trunk/src/docs/sip/sip-6.txt
        • /incubator/sqoop/trunk/src/docs/user/SqoopUserGuide.txt
        • /incubator/sqoop/trunk/src/docs/user/basics.txt
        • /incubator/sqoop/trunk/src/docs/user/codegen-args.txt
        • /incubator/sqoop/trunk/src/docs/user/codegen-purpose.txt
        • /incubator/sqoop/trunk/src/docs/user/codegen.txt
        • /incubator/sqoop/trunk/src/docs/user/common-args.txt
        • /incubator/sqoop/trunk/src/docs/user/compatibility.txt
        • /incubator/sqoop/trunk/src/docs/user/connecting.txt
        • /incubator/sqoop/trunk/src/docs/user/controlling-input-format.txt
        • /incubator/sqoop/trunk/src/docs/user/controlling-output-format.txt
        • /incubator/sqoop/trunk/src/docs/user/create-hive-table-purpose.txt
        • /incubator/sqoop/trunk/src/docs/user/create-hive-table.txt
        • /incubator/sqoop/trunk/src/docs/user/eval-purpose.txt
        • /incubator/sqoop/trunk/src/docs/user/eval.txt
        • /incubator/sqoop/trunk/src/docs/user/export-purpose.txt
        • /incubator/sqoop/trunk/src/docs/user/export.txt
        • /incubator/sqoop/trunk/src/docs/user/hbase-args.txt
        • /incubator/sqoop/trunk/src/docs/user/hbase.txt
        • /incubator/sqoop/trunk/src/docs/user/help.txt
        • /incubator/sqoop/trunk/src/docs/user/hive-args.txt
        • /incubator/sqoop/trunk/src/docs/user/hive-notes.txt
        • /incubator/sqoop/trunk/src/docs/user/hive.txt
        • /incubator/sqoop/trunk/src/docs/user/import-all-tables-purpose.txt
        • /incubator/sqoop/trunk/src/docs/user/import-all-tables.txt
        • /incubator/sqoop/trunk/src/docs/user/import-purpose.txt
        • /incubator/sqoop/trunk/src/docs/user/import.txt
        • /incubator/sqoop/trunk/src/docs/user/input-args.txt
        • /incubator/sqoop/trunk/src/docs/user/input-formatting-args.txt
        • /incubator/sqoop/trunk/src/docs/user/input-formatting.txt
        • /incubator/sqoop/trunk/src/docs/user/intro.txt
        • /incubator/sqoop/trunk/src/docs/user/job-purpose.txt
        • /incubator/sqoop/trunk/src/docs/user/list-databases.txt
        • /incubator/sqoop/trunk/src/docs/user/list-tables.txt
        • /incubator/sqoop/trunk/src/docs/user/merge-purpose.txt
        • /incubator/sqoop/trunk/src/docs/user/metastore-purpose.txt
        • /incubator/sqoop/trunk/src/docs/user/output-args.txt
        • /incubator/sqoop/trunk/src/docs/user/output-formatting-args.txt
        • /incubator/sqoop/trunk/src/docs/user/output-formatting.txt
        • /incubator/sqoop/trunk/src/docs/user/preface.txt
        • /incubator/sqoop/trunk/src/docs/user/saved-jobs.txt
        • /incubator/sqoop/trunk/src/docs/user/support.txt
        • /incubator/sqoop/trunk/src/docs/user/tools.txt
        • /incubator/sqoop/trunk/src/docs/user/troubleshooting.txt
        • /incubator/sqoop/trunk/src/docs/user/version.txt
        • /incubator/sqoop/trunk/src/docs/web/breadcrumbs.xsl
        • /incubator/sqoop/trunk/src/docs/web/docbook.css
        • /incubator/sqoop/trunk/src/docs/web/footer.xsl
        • /incubator/sqoop/trunk/src/docs/web/header.xsl
        • /incubator/sqoop/trunk/src/docs/web/html.xsl
        • /incubator/sqoop/trunk/src/docs/web/index.txt
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/ConnFactory.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/Sqoop.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/SqoopOptions.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/cli/RelatedOptions.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/io/LobFile.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/manager/PostgresqlManager.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/DelegatingOutputFormat.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/ExportBatchOutputFormat.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/CodeGenTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/SqoopTool.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/TaskId.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/ConnFactory.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/Sqoop.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/SqoopOptions.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/lib/ClobRef.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/lib/DelimiterSet.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/manager/PostgresqlManager.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/AvroExportMapper.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/MySQLDumpInputFormat.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java
        • /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java
        • /incubator/sqoop/trunk/src/perftest/ExportStressTest.java
        • /incubator/sqoop/trunk/src/perftest/ExtConnFactoryTest.java
        • /incubator/sqoop/trunk/src/perftest/ExtFactory.java
        • /incubator/sqoop/trunk/src/perftest/LobFilePerfTest.java
        • /incubator/sqoop/trunk/src/perftest/LobFileStressTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/AllTests.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/SmokeTests.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestAllTables.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestAppendUtils.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestAvroExport.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestAvroImport.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestBoundaryQuery.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestColumnTypes.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestCompression.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestConnFactory.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestExport.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestExportUpdate.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestIncrementalImport.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestMerge.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestMultiCols.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestMultiMaps.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestQuery.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestSplitBy.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestSqoopOptions.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestTargetDir.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestWhere.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/ThirdPartyTests.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hbase/TestHBaseUtil.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hive/TestHiveImport.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/io/TestCodecMap.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/io/TestLobFile.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/io/TestNamedFifo.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/io/TestSplittableBufferedWriter.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestBlobRef.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestBooleanParser.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestClobRef.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestFieldFormatter.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestLargeObjectLoader.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestRecordParser.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/MySQLAuthTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleCompatTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleExportTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleManagerTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleUtils.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/PostgresqlTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/TestHsqldbManager.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/TestSqlManager.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/mapreduce/MapreduceTests.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/mapreduce/TestImportJob.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/orm/TestClassWriter.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/orm/TestParseMethods.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/CommonArgs.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/DirUtil.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ExplicitSetMapper.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/HsqldbTestServer.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ImportJobTestCase.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/InjectableConnManager.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/InjectableManagerFactory.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/MockObjectFactory.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/MockResultSet.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ReparseMapper.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/SeqFileReader.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/tool/TestToolPlugin.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/util/TestOptionsFileExpansion.java
        • /incubator/sqoop/trunk/src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #53 (See https://builds.apache.org/job/Sqoop-jdk-1.6/53/ ) SQOOP-386 . Namespace migration cleanup. (Bilung Lee via Arvind Prabhakar) arvind : http://svn.apache.org/viewvc/?view=rev&rev=1196486 Files : /incubator/sqoop/trunk/NOTICE.txt /incubator/sqoop/trunk/src/docs/dev/SqoopDevGuide.txt /incubator/sqoop/trunk/src/docs/dev/api-reference.txt /incubator/sqoop/trunk/src/docs/dev/compiling.txt /incubator/sqoop/trunk/src/docs/dev/intro.txt /incubator/sqoop/trunk/src/docs/dev/preface.txt /incubator/sqoop/trunk/src/docs/man/codegen-args.txt /incubator/sqoop/trunk/src/docs/man/common-args.txt /incubator/sqoop/trunk/src/docs/man/hbase-args.txt /incubator/sqoop/trunk/src/docs/man/hive-args.txt /incubator/sqoop/trunk/src/docs/man/import-args.txt /incubator/sqoop/trunk/src/docs/man/input-args.txt /incubator/sqoop/trunk/src/docs/man/output-args.txt /incubator/sqoop/trunk/src/docs/sip/INDEX.txt /incubator/sqoop/trunk/src/docs/sip/README.txt /incubator/sqoop/trunk/src/docs/sip/sip-1.txt /incubator/sqoop/trunk/src/docs/sip/sip-2.txt /incubator/sqoop/trunk/src/docs/sip/sip-3.txt /incubator/sqoop/trunk/src/docs/sip/sip-4.txt /incubator/sqoop/trunk/src/docs/sip/sip-6.txt /incubator/sqoop/trunk/src/docs/user/SqoopUserGuide.txt /incubator/sqoop/trunk/src/docs/user/basics.txt /incubator/sqoop/trunk/src/docs/user/codegen-args.txt /incubator/sqoop/trunk/src/docs/user/codegen-purpose.txt /incubator/sqoop/trunk/src/docs/user/codegen.txt /incubator/sqoop/trunk/src/docs/user/common-args.txt /incubator/sqoop/trunk/src/docs/user/compatibility.txt /incubator/sqoop/trunk/src/docs/user/connecting.txt /incubator/sqoop/trunk/src/docs/user/controlling-input-format.txt /incubator/sqoop/trunk/src/docs/user/controlling-output-format.txt /incubator/sqoop/trunk/src/docs/user/create-hive-table-purpose.txt /incubator/sqoop/trunk/src/docs/user/create-hive-table.txt /incubator/sqoop/trunk/src/docs/user/eval-purpose.txt /incubator/sqoop/trunk/src/docs/user/eval.txt /incubator/sqoop/trunk/src/docs/user/export-purpose.txt /incubator/sqoop/trunk/src/docs/user/export.txt /incubator/sqoop/trunk/src/docs/user/hbase-args.txt /incubator/sqoop/trunk/src/docs/user/hbase.txt /incubator/sqoop/trunk/src/docs/user/help.txt /incubator/sqoop/trunk/src/docs/user/hive-args.txt /incubator/sqoop/trunk/src/docs/user/hive-notes.txt /incubator/sqoop/trunk/src/docs/user/hive.txt /incubator/sqoop/trunk/src/docs/user/import-all-tables-purpose.txt /incubator/sqoop/trunk/src/docs/user/import-all-tables.txt /incubator/sqoop/trunk/src/docs/user/import-purpose.txt /incubator/sqoop/trunk/src/docs/user/import.txt /incubator/sqoop/trunk/src/docs/user/input-args.txt /incubator/sqoop/trunk/src/docs/user/input-formatting-args.txt /incubator/sqoop/trunk/src/docs/user/input-formatting.txt /incubator/sqoop/trunk/src/docs/user/intro.txt /incubator/sqoop/trunk/src/docs/user/job-purpose.txt /incubator/sqoop/trunk/src/docs/user/list-databases.txt /incubator/sqoop/trunk/src/docs/user/list-tables.txt /incubator/sqoop/trunk/src/docs/user/merge-purpose.txt /incubator/sqoop/trunk/src/docs/user/metastore-purpose.txt /incubator/sqoop/trunk/src/docs/user/output-args.txt /incubator/sqoop/trunk/src/docs/user/output-formatting-args.txt /incubator/sqoop/trunk/src/docs/user/output-formatting.txt /incubator/sqoop/trunk/src/docs/user/preface.txt /incubator/sqoop/trunk/src/docs/user/saved-jobs.txt /incubator/sqoop/trunk/src/docs/user/support.txt /incubator/sqoop/trunk/src/docs/user/tools.txt /incubator/sqoop/trunk/src/docs/user/troubleshooting.txt /incubator/sqoop/trunk/src/docs/user/version.txt /incubator/sqoop/trunk/src/docs/web/breadcrumbs.xsl /incubator/sqoop/trunk/src/docs/web/docbook.css /incubator/sqoop/trunk/src/docs/web/footer.xsl /incubator/sqoop/trunk/src/docs/web/header.xsl /incubator/sqoop/trunk/src/docs/web/html.xsl /incubator/sqoop/trunk/src/docs/web/index.txt /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/ConnFactory.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/Sqoop.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/SqoopOptions.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/cli/RelatedOptions.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/io/LobFile.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/manager/PostgresqlManager.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/DelegatingOutputFormat.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/ExportBatchOutputFormat.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/CodeGenTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/tool/SqoopTool.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/util/TaskId.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/ConnFactory.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/Sqoop.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/SqoopOptions.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/lib/ClobRef.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/lib/DelimiterSet.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/manager/PostgresqlManager.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/AvroExportMapper.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/MySQLDumpInputFormat.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java /incubator/sqoop/trunk/src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java /incubator/sqoop/trunk/src/perftest/ExportStressTest.java /incubator/sqoop/trunk/src/perftest/ExtConnFactoryTest.java /incubator/sqoop/trunk/src/perftest/ExtFactory.java /incubator/sqoop/trunk/src/perftest/LobFilePerfTest.java /incubator/sqoop/trunk/src/perftest/LobFileStressTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/AllTests.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/SmokeTests.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestAllTables.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestAppendUtils.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestAvroExport.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestAvroImport.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestBoundaryQuery.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestColumnTypes.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestCompression.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestConnFactory.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestExport.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestExportUpdate.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestIncrementalImport.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestMerge.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestMultiCols.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestMultiMaps.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestQuery.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestSplitBy.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestSqoopOptions.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestTargetDir.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestWhere.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/ThirdPartyTests.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hbase/TestHBaseUtil.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hive/TestHiveImport.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/io/TestCodecMap.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/io/TestLobFile.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/io/TestNamedFifo.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/io/TestSplittableBufferedWriter.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestBlobRef.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestBooleanParser.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestClobRef.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestFieldFormatter.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestLargeObjectLoader.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/lib/TestRecordParser.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/MySQLAuthTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleCompatTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleExportTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleManagerTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleUtils.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/PostgresqlTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/TestHsqldbManager.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/TestSqlManager.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/mapreduce/MapreduceTests.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/mapreduce/TestImportJob.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/orm/TestClassWriter.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/orm/TestParseMethods.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/CommonArgs.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/DirUtil.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ExplicitSetMapper.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/HsqldbTestServer.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ImportJobTestCase.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/InjectableConnManager.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/InjectableManagerFactory.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/MockObjectFactory.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/MockResultSet.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ReparseMapper.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/SeqFileReader.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/tool/TestToolPlugin.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/util/TestOptionsFileExpansion.java /incubator/sqoop/trunk/src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2668/#review3007
        -----------------------------------------------------------

        Ship it!

        +1

        Changes look good Bilung. Please attach the patch to the JIRA when you get a chance.

        • Arvind

        On 2011-11-02 01:42:46, Bilung Lee wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2668/

        -----------------------------------------------------------

        (Updated 2011-11-02 01:42:46)

        Review request for Arvind Prabhakar.

        Summary

        -------

        Patch for SQOOP-386.

        This addresses bug SQOOP-386.

        https://issues.apache.org/jira/browse/SQOOP-386

        Diffs

        -----

        ./NOTICE.txt 1187139

        ./src/docs/dev/SqoopDevGuide.txt 1196401

        ./src/docs/dev/api-reference.txt 1187844

        ./src/docs/dev/compiling.txt 1187844

        ./src/docs/dev/intro.txt 1187844

        ./src/docs/dev/preface.txt 1187844

        ./src/docs/man/codegen-args.txt 1187844

        ./src/docs/man/common-args.txt 1187844

        ./src/docs/man/hbase-args.txt 1187844

        ./src/docs/man/hive-args.txt 1187844

        ./src/docs/man/import-args.txt 1187844

        ./src/docs/man/input-args.txt 1187844

        ./src/docs/man/output-args.txt 1187844

        ./src/docs/sip/INDEX.txt 1187844

        ./src/docs/sip/README.txt 1187844

        ./src/docs/sip/sip-1.txt 1187844

        ./src/docs/sip/sip-2.txt 1187844

        ./src/docs/sip/sip-3.txt 1187844

        ./src/docs/sip/sip-4.txt 1187844

        ./src/docs/sip/sip-6.txt 1187844

        ./src/docs/user/SqoopUserGuide.txt 1187844

        ./src/docs/user/basics.txt 1187844

        ./src/docs/user/codegen-args.txt 1187844

        ./src/docs/user/codegen-purpose.txt 1187844

        ./src/docs/user/codegen.txt 1187844

        ./src/docs/user/common-args.txt 1187844

        ./src/docs/user/compatibility.txt 1187844

        ./src/docs/user/connecting.txt 1187844

        ./src/docs/user/controlling-input-format.txt 1187844

        ./src/docs/user/controlling-output-format.txt 1187844

        ./src/docs/user/create-hive-table-purpose.txt 1187844

        ./src/docs/user/create-hive-table.txt 1187844

        ./src/docs/user/eval-purpose.txt 1187844

        ./src/docs/user/eval.txt 1187844

        ./src/docs/user/export-purpose.txt 1187844

        ./src/docs/user/export.txt 1187844

        ./src/docs/user/hbase-args.txt 1187844

        ./src/docs/user/hbase.txt 1187844

        ./src/docs/user/help.txt 1187844

        ./src/docs/user/hive-args.txt 1187844

        ./src/docs/user/hive-notes.txt 1187844

        ./src/docs/user/hive.txt 1187844

        ./src/docs/user/import-all-tables-purpose.txt 1187844

        ./src/docs/user/import-all-tables.txt 1187844

        ./src/docs/user/import-purpose.txt 1187844

        ./src/docs/user/import.txt 1187844

        ./src/docs/user/input-args.txt 1187844

        ./src/docs/user/input-formatting-args.txt 1187844

        ./src/docs/user/input-formatting.txt 1187844

        ./src/docs/user/intro.txt 1187844

        ./src/docs/user/job-purpose.txt 1187844

        ./src/docs/user/list-databases.txt 1187844

        ./src/docs/user/list-tables.txt 1187844

        ./src/docs/user/merge-purpose.txt 1187844

        ./src/docs/user/metastore-purpose.txt 1187844

        ./src/docs/user/output-args.txt 1187844

        ./src/docs/user/output-formatting-args.txt 1187844

        ./src/docs/user/output-formatting.txt 1187844

        ./src/docs/user/preface.txt 1187844

        ./src/docs/user/saved-jobs.txt 1187844

        ./src/docs/user/support.txt 1187844

        ./src/docs/user/tools.txt 1187844

        ./src/docs/user/troubleshooting.txt 1187844

        ./src/docs/user/version.txt 1187844

        ./src/docs/web/breadcrumbs.xsl 1187844

        ./src/docs/web/docbook.css 1187844

        ./src/docs/web/footer.xsl 1187844

        ./src/docs/web/header.xsl 1187844

        ./src/docs/web/html.xsl 1187844

        ./src/docs/web/index.txt 1187844

        ./src/java/com/cloudera/sqoop/ConnFactory.java 1187591

        ./src/java/com/cloudera/sqoop/Sqoop.java 1187591

        ./src/java/com/cloudera/sqoop/SqoopOptions.java 1187591

        ./src/java/com/cloudera/sqoop/cli/RelatedOptions.java 1195865

        ./src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 1195691

        ./src/java/com/cloudera/sqoop/io/LobFile.java 1190438

        ./src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 1196291

        ./src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1190670

        ./src/java/com/cloudera/sqoop/mapreduce/DelegatingOutputFormat.java 1190670

        ./src/java/com/cloudera/sqoop/mapreduce/ExportBatchOutputFormat.java 1190670

        ./src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1190670

        ./src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1190670

        ./src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1195852

        ./src/java/com/cloudera/sqoop/tool/SqoopTool.java 1196194

        ./src/java/com/cloudera/sqoop/util/TaskId.java 1188941

        ./src/java/org/apache/sqoop/ConnFactory.java PRE-CREATION

        ./src/java/org/apache/sqoop/Sqoop.java PRE-CREATION

        ./src/java/org/apache/sqoop/SqoopOptions.java PRE-CREATION

        ./src/java/org/apache/sqoop/lib/ClobRef.java 1196332

        ./src/java/org/apache/sqoop/lib/DelimiterSet.java 1196332

        ./src/java/org/apache/sqoop/manager/PostgresqlManager.java 1196332

        ./src/java/org/apache/sqoop/mapreduce/AvroExportMapper.java 1196332

        ./src/java/org/apache/sqoop/mapreduce/MySQLDumpInputFormat.java 1196332

        ./src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java 1196332

        ./src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1196332

        ./src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java 1196332

        ./src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java 1196332

        ./src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java 1196332

        ./src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1196332

        ./src/perftest/ExportStressTest.java 1187139

        ./src/perftest/ExtConnFactoryTest.java 1187139

        ./src/perftest/ExtFactory.java 1187139

        ./src/perftest/LobFilePerfTest.java 1187139

        ./src/perftest/LobFileStressTest.java 1187139

        ./src/test/com/cloudera/sqoop/AllTests.java 1190533

        ./src/test/com/cloudera/sqoop/SmokeTests.java 1190533

        ./src/test/com/cloudera/sqoop/TestAllTables.java 1190533

        ./src/test/com/cloudera/sqoop/TestAppendUtils.java 1190533

        ./src/test/com/cloudera/sqoop/TestAvroExport.java 1190533

        ./src/test/com/cloudera/sqoop/TestAvroImport.java 1190533

        ./src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java 1190533

        ./src/test/com/cloudera/sqoop/TestBoundaryQuery.java 1190533

        ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1190533

        ./src/test/com/cloudera/sqoop/TestCompression.java 1190533

        ./src/test/com/cloudera/sqoop/TestConnFactory.java 1190533

        ./src/test/com/cloudera/sqoop/TestExport.java 1195790

        ./src/test/com/cloudera/sqoop/TestExportUpdate.java 1190533

        ./src/test/com/cloudera/sqoop/TestIncrementalImport.java 1190533

        ./src/test/com/cloudera/sqoop/TestMerge.java 1190533

        ./src/test/com/cloudera/sqoop/TestMultiCols.java 1190533

        ./src/test/com/cloudera/sqoop/TestMultiMaps.java 1190533

        ./src/test/com/cloudera/sqoop/TestQuery.java 1190533

        ./src/test/com/cloudera/sqoop/TestSplitBy.java 1190533

        ./src/test/com/cloudera/sqoop/TestSqoopOptions.java 1190533

        ./src/test/com/cloudera/sqoop/TestTargetDir.java 1190533

        ./src/test/com/cloudera/sqoop/TestWhere.java 1190533

        ./src/test/com/cloudera/sqoop/ThirdPartyTests.java 1190533

        ./src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 1190533

        ./src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java 1190533

        ./src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java 1190533

        ./src/test/com/cloudera/sqoop/hbase/TestHBaseUtil.java 1190533

        ./src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1190533

        ./src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 1190533

        ./src/test/com/cloudera/sqoop/io/TestCodecMap.java 1190533

        ./src/test/com/cloudera/sqoop/io/TestLobFile.java 1190533

        ./src/test/com/cloudera/sqoop/io/TestNamedFifo.java 1190533

        ./src/test/com/cloudera/sqoop/io/TestSplittableBufferedWriter.java 1190533

        ./src/test/com/cloudera/sqoop/lib/TestBlobRef.java 1190533

        ./src/test/com/cloudera/sqoop/lib/TestBooleanParser.java 1190533

        ./src/test/com/cloudera/sqoop/lib/TestClobRef.java 1190533

        ./src/test/com/cloudera/sqoop/lib/TestFieldFormatter.java 1190533

        ./src/test/com/cloudera/sqoop/lib/TestLargeObjectLoader.java 1190533

        ./src/test/com/cloudera/sqoop/lib/TestRecordParser.java 1190533

        ./src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java 1190533

        ./src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 1190533

        ./src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java 1190533

        ./src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 1190533

        ./src/test/com/cloudera/sqoop/manager/MySQLAuthTest.java 1190533

        ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1190533

        ./src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java 1190533

        ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1190533

        ./src/test/com/cloudera/sqoop/manager/OracleExportTest.java 1190533

        ./src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1190533

        ./src/test/com/cloudera/sqoop/manager/OracleUtils.java 1190533

        ./src/test/com/cloudera/sqoop/manager/PostgresqlTest.java 1196291

        ./src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 1190533

        ./src/test/com/cloudera/sqoop/manager/TestHsqldbManager.java 1190533

        ./src/test/com/cloudera/sqoop/manager/TestSqlManager.java 1190533

        ./src/test/com/cloudera/sqoop/mapreduce/MapreduceTests.java 1190533

        ./src/test/com/cloudera/sqoop/mapreduce/TestImportJob.java 1190533

        ./src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 1190533

        ./src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java 1190533

        ./src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1195805

        ./src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1195805

        ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1190533

        ./src/test/com/cloudera/sqoop/testutil/CommonArgs.java 1190533

        ./src/test/com/cloudera/sqoop/testutil/DirUtil.java 1190533

        ./src/test/com/cloudera/sqoop/testutil/ExplicitSetMapper.java 1195790

        ./src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 1190533

        ./src/test/com/cloudera/sqoop/testutil/HsqldbTestServer.java 1190533

        ./src/test/com/cloudera/sqoop/testutil/ImportJobTestCase.java 1190533

        ./src/test/com/cloudera/sqoop/testutil/InjectableConnManager.java 1190533

        ./src/test/com/cloudera/sqoop/testutil/InjectableManagerFactory.java 1190533

        ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1190533

        ./src/test/com/cloudera/sqoop/testutil/MockObjectFactory.java 1190533

        ./src/test/com/cloudera/sqoop/testutil/MockResultSet.java 1190533

        ./src/test/com/cloudera/sqoop/testutil/ReparseMapper.java 1195788

        ./src/test/com/cloudera/sqoop/testutil/SeqFileReader.java 1190533

        ./src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1195805

        ./src/test/com/cloudera/sqoop/util/TestOptionsFileExpansion.java 1190533

        ./src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java 1196332

        Diff: https://reviews.apache.org/r/2668/diff

        Testing

        -------

        All test cases

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2668/#review3007 ----------------------------------------------------------- Ship it! +1 Changes look good Bilung. Please attach the patch to the JIRA when you get a chance. Arvind On 2011-11-02 01:42:46, Bilung Lee wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2668/ ----------------------------------------------------------- (Updated 2011-11-02 01:42:46) Review request for Arvind Prabhakar. Summary ------- Patch for SQOOP-386 . This addresses bug SQOOP-386 . https://issues.apache.org/jira/browse/SQOOP-386 Diffs ----- ./NOTICE.txt 1187139 ./src/docs/dev/SqoopDevGuide.txt 1196401 ./src/docs/dev/api-reference.txt 1187844 ./src/docs/dev/compiling.txt 1187844 ./src/docs/dev/intro.txt 1187844 ./src/docs/dev/preface.txt 1187844 ./src/docs/man/codegen-args.txt 1187844 ./src/docs/man/common-args.txt 1187844 ./src/docs/man/hbase-args.txt 1187844 ./src/docs/man/hive-args.txt 1187844 ./src/docs/man/import-args.txt 1187844 ./src/docs/man/input-args.txt 1187844 ./src/docs/man/output-args.txt 1187844 ./src/docs/sip/INDEX.txt 1187844 ./src/docs/sip/README.txt 1187844 ./src/docs/sip/sip-1.txt 1187844 ./src/docs/sip/sip-2.txt 1187844 ./src/docs/sip/sip-3.txt 1187844 ./src/docs/sip/sip-4.txt 1187844 ./src/docs/sip/sip-6.txt 1187844 ./src/docs/user/SqoopUserGuide.txt 1187844 ./src/docs/user/basics.txt 1187844 ./src/docs/user/codegen-args.txt 1187844 ./src/docs/user/codegen-purpose.txt 1187844 ./src/docs/user/codegen.txt 1187844 ./src/docs/user/common-args.txt 1187844 ./src/docs/user/compatibility.txt 1187844 ./src/docs/user/connecting.txt 1187844 ./src/docs/user/controlling-input-format.txt 1187844 ./src/docs/user/controlling-output-format.txt 1187844 ./src/docs/user/create-hive-table-purpose.txt 1187844 ./src/docs/user/create-hive-table.txt 1187844 ./src/docs/user/eval-purpose.txt 1187844 ./src/docs/user/eval.txt 1187844 ./src/docs/user/export-purpose.txt 1187844 ./src/docs/user/export.txt 1187844 ./src/docs/user/hbase-args.txt 1187844 ./src/docs/user/hbase.txt 1187844 ./src/docs/user/help.txt 1187844 ./src/docs/user/hive-args.txt 1187844 ./src/docs/user/hive-notes.txt 1187844 ./src/docs/user/hive.txt 1187844 ./src/docs/user/import-all-tables-purpose.txt 1187844 ./src/docs/user/import-all-tables.txt 1187844 ./src/docs/user/import-purpose.txt 1187844 ./src/docs/user/import.txt 1187844 ./src/docs/user/input-args.txt 1187844 ./src/docs/user/input-formatting-args.txt 1187844 ./src/docs/user/input-formatting.txt 1187844 ./src/docs/user/intro.txt 1187844 ./src/docs/user/job-purpose.txt 1187844 ./src/docs/user/list-databases.txt 1187844 ./src/docs/user/list-tables.txt 1187844 ./src/docs/user/merge-purpose.txt 1187844 ./src/docs/user/metastore-purpose.txt 1187844 ./src/docs/user/output-args.txt 1187844 ./src/docs/user/output-formatting-args.txt 1187844 ./src/docs/user/output-formatting.txt 1187844 ./src/docs/user/preface.txt 1187844 ./src/docs/user/saved-jobs.txt 1187844 ./src/docs/user/support.txt 1187844 ./src/docs/user/tools.txt 1187844 ./src/docs/user/troubleshooting.txt 1187844 ./src/docs/user/version.txt 1187844 ./src/docs/web/breadcrumbs.xsl 1187844 ./src/docs/web/docbook.css 1187844 ./src/docs/web/footer.xsl 1187844 ./src/docs/web/header.xsl 1187844 ./src/docs/web/html.xsl 1187844 ./src/docs/web/index.txt 1187844 ./src/java/com/cloudera/sqoop/ConnFactory.java 1187591 ./src/java/com/cloudera/sqoop/Sqoop.java 1187591 ./src/java/com/cloudera/sqoop/SqoopOptions.java 1187591 ./src/java/com/cloudera/sqoop/cli/RelatedOptions.java 1195865 ./src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 1195691 ./src/java/com/cloudera/sqoop/io/LobFile.java 1190438 ./src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 1196291 ./src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1190670 ./src/java/com/cloudera/sqoop/mapreduce/DelegatingOutputFormat.java 1190670 ./src/java/com/cloudera/sqoop/mapreduce/ExportBatchOutputFormat.java 1190670 ./src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1190670 ./src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1190670 ./src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1195852 ./src/java/com/cloudera/sqoop/tool/SqoopTool.java 1196194 ./src/java/com/cloudera/sqoop/util/TaskId.java 1188941 ./src/java/org/apache/sqoop/ConnFactory.java PRE-CREATION ./src/java/org/apache/sqoop/Sqoop.java PRE-CREATION ./src/java/org/apache/sqoop/SqoopOptions.java PRE-CREATION ./src/java/org/apache/sqoop/lib/ClobRef.java 1196332 ./src/java/org/apache/sqoop/lib/DelimiterSet.java 1196332 ./src/java/org/apache/sqoop/manager/PostgresqlManager.java 1196332 ./src/java/org/apache/sqoop/mapreduce/AvroExportMapper.java 1196332 ./src/java/org/apache/sqoop/mapreduce/MySQLDumpInputFormat.java 1196332 ./src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java 1196332 ./src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1196332 ./src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java 1196332 ./src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java 1196332 ./src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java 1196332 ./src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1196332 ./src/perftest/ExportStressTest.java 1187139 ./src/perftest/ExtConnFactoryTest.java 1187139 ./src/perftest/ExtFactory.java 1187139 ./src/perftest/LobFilePerfTest.java 1187139 ./src/perftest/LobFileStressTest.java 1187139 ./src/test/com/cloudera/sqoop/AllTests.java 1190533 ./src/test/com/cloudera/sqoop/SmokeTests.java 1190533 ./src/test/com/cloudera/sqoop/TestAllTables.java 1190533 ./src/test/com/cloudera/sqoop/TestAppendUtils.java 1190533 ./src/test/com/cloudera/sqoop/TestAvroExport.java 1190533 ./src/test/com/cloudera/sqoop/TestAvroImport.java 1190533 ./src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java 1190533 ./src/test/com/cloudera/sqoop/TestBoundaryQuery.java 1190533 ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1190533 ./src/test/com/cloudera/sqoop/TestCompression.java 1190533 ./src/test/com/cloudera/sqoop/TestConnFactory.java 1190533 ./src/test/com/cloudera/sqoop/TestExport.java 1195790 ./src/test/com/cloudera/sqoop/TestExportUpdate.java 1190533 ./src/test/com/cloudera/sqoop/TestIncrementalImport.java 1190533 ./src/test/com/cloudera/sqoop/TestMerge.java 1190533 ./src/test/com/cloudera/sqoop/TestMultiCols.java 1190533 ./src/test/com/cloudera/sqoop/TestMultiMaps.java 1190533 ./src/test/com/cloudera/sqoop/TestQuery.java 1190533 ./src/test/com/cloudera/sqoop/TestSplitBy.java 1190533 ./src/test/com/cloudera/sqoop/TestSqoopOptions.java 1190533 ./src/test/com/cloudera/sqoop/TestTargetDir.java 1190533 ./src/test/com/cloudera/sqoop/TestWhere.java 1190533 ./src/test/com/cloudera/sqoop/ThirdPartyTests.java 1190533 ./src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 1190533 ./src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java 1190533 ./src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java 1190533 ./src/test/com/cloudera/sqoop/hbase/TestHBaseUtil.java 1190533 ./src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1190533 ./src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 1190533 ./src/test/com/cloudera/sqoop/io/TestCodecMap.java 1190533 ./src/test/com/cloudera/sqoop/io/TestLobFile.java 1190533 ./src/test/com/cloudera/sqoop/io/TestNamedFifo.java 1190533 ./src/test/com/cloudera/sqoop/io/TestSplittableBufferedWriter.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestBlobRef.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestBooleanParser.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestClobRef.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestFieldFormatter.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestLargeObjectLoader.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestRecordParser.java 1190533 ./src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/MySQLAuthTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java 1190533 ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/OracleExportTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/OracleUtils.java 1190533 ./src/test/com/cloudera/sqoop/manager/PostgresqlTest.java 1196291 ./src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/TestHsqldbManager.java 1190533 ./src/test/com/cloudera/sqoop/manager/TestSqlManager.java 1190533 ./src/test/com/cloudera/sqoop/mapreduce/MapreduceTests.java 1190533 ./src/test/com/cloudera/sqoop/mapreduce/TestImportJob.java 1190533 ./src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 1190533 ./src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java 1190533 ./src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1195805 ./src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1195805 ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1190533 ./src/test/com/cloudera/sqoop/testutil/CommonArgs.java 1190533 ./src/test/com/cloudera/sqoop/testutil/DirUtil.java 1190533 ./src/test/com/cloudera/sqoop/testutil/ExplicitSetMapper.java 1195790 ./src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 1190533 ./src/test/com/cloudera/sqoop/testutil/HsqldbTestServer.java 1190533 ./src/test/com/cloudera/sqoop/testutil/ImportJobTestCase.java 1190533 ./src/test/com/cloudera/sqoop/testutil/InjectableConnManager.java 1190533 ./src/test/com/cloudera/sqoop/testutil/InjectableManagerFactory.java 1190533 ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1190533 ./src/test/com/cloudera/sqoop/testutil/MockObjectFactory.java 1190533 ./src/test/com/cloudera/sqoop/testutil/MockResultSet.java 1190533 ./src/test/com/cloudera/sqoop/testutil/ReparseMapper.java 1195788 ./src/test/com/cloudera/sqoop/testutil/SeqFileReader.java 1190533 ./src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1195805 ./src/test/com/cloudera/sqoop/util/TestOptionsFileExpansion.java 1190533 ./src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java 1196332 Diff: https://reviews.apache.org/r/2668/diff Testing ------- All test cases Thanks, Bilung
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2668/
        -----------------------------------------------------------

        Review request for Arvind Prabhakar.

        Summary
        -------

        Patch for SQOOP-386.

        This addresses bug SQOOP-386.
        https://issues.apache.org/jira/browse/SQOOP-386

        Diffs


        ./NOTICE.txt 1187139
        ./src/docs/dev/SqoopDevGuide.txt 1196401
        ./src/docs/dev/api-reference.txt 1187844
        ./src/docs/dev/compiling.txt 1187844
        ./src/docs/dev/intro.txt 1187844
        ./src/docs/dev/preface.txt 1187844
        ./src/docs/man/codegen-args.txt 1187844
        ./src/docs/man/common-args.txt 1187844
        ./src/docs/man/hbase-args.txt 1187844
        ./src/docs/man/hive-args.txt 1187844
        ./src/docs/man/import-args.txt 1187844
        ./src/docs/man/input-args.txt 1187844
        ./src/docs/man/output-args.txt 1187844
        ./src/docs/sip/INDEX.txt 1187844
        ./src/docs/sip/README.txt 1187844
        ./src/docs/sip/sip-1.txt 1187844
        ./src/docs/sip/sip-2.txt 1187844
        ./src/docs/sip/sip-3.txt 1187844
        ./src/docs/sip/sip-4.txt 1187844
        ./src/docs/sip/sip-6.txt 1187844
        ./src/docs/user/SqoopUserGuide.txt 1187844
        ./src/docs/user/basics.txt 1187844
        ./src/docs/user/codegen-args.txt 1187844
        ./src/docs/user/codegen-purpose.txt 1187844
        ./src/docs/user/codegen.txt 1187844
        ./src/docs/user/common-args.txt 1187844
        ./src/docs/user/compatibility.txt 1187844
        ./src/docs/user/connecting.txt 1187844
        ./src/docs/user/controlling-input-format.txt 1187844
        ./src/docs/user/controlling-output-format.txt 1187844
        ./src/docs/user/create-hive-table-purpose.txt 1187844
        ./src/docs/user/create-hive-table.txt 1187844
        ./src/docs/user/eval-purpose.txt 1187844
        ./src/docs/user/eval.txt 1187844
        ./src/docs/user/export-purpose.txt 1187844
        ./src/docs/user/export.txt 1187844
        ./src/docs/user/hbase-args.txt 1187844
        ./src/docs/user/hbase.txt 1187844
        ./src/docs/user/help.txt 1187844
        ./src/docs/user/hive-args.txt 1187844
        ./src/docs/user/hive-notes.txt 1187844
        ./src/docs/user/hive.txt 1187844
        ./src/docs/user/import-all-tables-purpose.txt 1187844
        ./src/docs/user/import-all-tables.txt 1187844
        ./src/docs/user/import-purpose.txt 1187844
        ./src/docs/user/import.txt 1187844
        ./src/docs/user/input-args.txt 1187844
        ./src/docs/user/input-formatting-args.txt 1187844
        ./src/docs/user/input-formatting.txt 1187844
        ./src/docs/user/intro.txt 1187844
        ./src/docs/user/job-purpose.txt 1187844
        ./src/docs/user/list-databases.txt 1187844
        ./src/docs/user/list-tables.txt 1187844
        ./src/docs/user/merge-purpose.txt 1187844
        ./src/docs/user/metastore-purpose.txt 1187844
        ./src/docs/user/output-args.txt 1187844
        ./src/docs/user/output-formatting-args.txt 1187844
        ./src/docs/user/output-formatting.txt 1187844
        ./src/docs/user/preface.txt 1187844
        ./src/docs/user/saved-jobs.txt 1187844
        ./src/docs/user/support.txt 1187844
        ./src/docs/user/tools.txt 1187844
        ./src/docs/user/troubleshooting.txt 1187844
        ./src/docs/user/version.txt 1187844
        ./src/docs/web/breadcrumbs.xsl 1187844
        ./src/docs/web/docbook.css 1187844
        ./src/docs/web/footer.xsl 1187844
        ./src/docs/web/header.xsl 1187844
        ./src/docs/web/html.xsl 1187844
        ./src/docs/web/index.txt 1187844
        ./src/java/com/cloudera/sqoop/ConnFactory.java 1187591
        ./src/java/com/cloudera/sqoop/Sqoop.java 1187591
        ./src/java/com/cloudera/sqoop/SqoopOptions.java 1187591
        ./src/java/com/cloudera/sqoop/cli/RelatedOptions.java 1195865
        ./src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 1195691
        ./src/java/com/cloudera/sqoop/io/LobFile.java 1190438
        ./src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 1196291
        ./src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1190670
        ./src/java/com/cloudera/sqoop/mapreduce/DelegatingOutputFormat.java 1190670
        ./src/java/com/cloudera/sqoop/mapreduce/ExportBatchOutputFormat.java 1190670
        ./src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1190670
        ./src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1190670
        ./src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1195852
        ./src/java/com/cloudera/sqoop/tool/SqoopTool.java 1196194
        ./src/java/com/cloudera/sqoop/util/TaskId.java 1188941
        ./src/java/org/apache/sqoop/ConnFactory.java PRE-CREATION
        ./src/java/org/apache/sqoop/Sqoop.java PRE-CREATION
        ./src/java/org/apache/sqoop/SqoopOptions.java PRE-CREATION
        ./src/java/org/apache/sqoop/lib/ClobRef.java 1196332
        ./src/java/org/apache/sqoop/lib/DelimiterSet.java 1196332
        ./src/java/org/apache/sqoop/manager/PostgresqlManager.java 1196332
        ./src/java/org/apache/sqoop/mapreduce/AvroExportMapper.java 1196332
        ./src/java/org/apache/sqoop/mapreduce/MySQLDumpInputFormat.java 1196332
        ./src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java 1196332
        ./src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1196332
        ./src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java 1196332
        ./src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java 1196332
        ./src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java 1196332
        ./src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1196332
        ./src/perftest/ExportStressTest.java 1187139
        ./src/perftest/ExtConnFactoryTest.java 1187139
        ./src/perftest/ExtFactory.java 1187139
        ./src/perftest/LobFilePerfTest.java 1187139
        ./src/perftest/LobFileStressTest.java 1187139
        ./src/test/com/cloudera/sqoop/AllTests.java 1190533
        ./src/test/com/cloudera/sqoop/SmokeTests.java 1190533
        ./src/test/com/cloudera/sqoop/TestAllTables.java 1190533
        ./src/test/com/cloudera/sqoop/TestAppendUtils.java 1190533
        ./src/test/com/cloudera/sqoop/TestAvroExport.java 1190533
        ./src/test/com/cloudera/sqoop/TestAvroImport.java 1190533
        ./src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java 1190533
        ./src/test/com/cloudera/sqoop/TestBoundaryQuery.java 1190533
        ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1190533
        ./src/test/com/cloudera/sqoop/TestCompression.java 1190533
        ./src/test/com/cloudera/sqoop/TestConnFactory.java 1190533
        ./src/test/com/cloudera/sqoop/TestExport.java 1195790
        ./src/test/com/cloudera/sqoop/TestExportUpdate.java 1190533
        ./src/test/com/cloudera/sqoop/TestIncrementalImport.java 1190533
        ./src/test/com/cloudera/sqoop/TestMerge.java 1190533
        ./src/test/com/cloudera/sqoop/TestMultiCols.java 1190533
        ./src/test/com/cloudera/sqoop/TestMultiMaps.java 1190533
        ./src/test/com/cloudera/sqoop/TestQuery.java 1190533
        ./src/test/com/cloudera/sqoop/TestSplitBy.java 1190533
        ./src/test/com/cloudera/sqoop/TestSqoopOptions.java 1190533
        ./src/test/com/cloudera/sqoop/TestTargetDir.java 1190533
        ./src/test/com/cloudera/sqoop/TestWhere.java 1190533
        ./src/test/com/cloudera/sqoop/ThirdPartyTests.java 1190533
        ./src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 1190533
        ./src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java 1190533
        ./src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java 1190533
        ./src/test/com/cloudera/sqoop/hbase/TestHBaseUtil.java 1190533
        ./src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1190533
        ./src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 1190533
        ./src/test/com/cloudera/sqoop/io/TestCodecMap.java 1190533
        ./src/test/com/cloudera/sqoop/io/TestLobFile.java 1190533
        ./src/test/com/cloudera/sqoop/io/TestNamedFifo.java 1190533
        ./src/test/com/cloudera/sqoop/io/TestSplittableBufferedWriter.java 1190533
        ./src/test/com/cloudera/sqoop/lib/TestBlobRef.java 1190533
        ./src/test/com/cloudera/sqoop/lib/TestBooleanParser.java 1190533
        ./src/test/com/cloudera/sqoop/lib/TestClobRef.java 1190533
        ./src/test/com/cloudera/sqoop/lib/TestFieldFormatter.java 1190533
        ./src/test/com/cloudera/sqoop/lib/TestLargeObjectLoader.java 1190533
        ./src/test/com/cloudera/sqoop/lib/TestRecordParser.java 1190533
        ./src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java 1190533
        ./src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 1190533
        ./src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java 1190533
        ./src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 1190533
        ./src/test/com/cloudera/sqoop/manager/MySQLAuthTest.java 1190533
        ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1190533
        ./src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java 1190533
        ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1190533
        ./src/test/com/cloudera/sqoop/manager/OracleExportTest.java 1190533
        ./src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1190533
        ./src/test/com/cloudera/sqoop/manager/OracleUtils.java 1190533
        ./src/test/com/cloudera/sqoop/manager/PostgresqlTest.java 1196291
        ./src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 1190533
        ./src/test/com/cloudera/sqoop/manager/TestHsqldbManager.java 1190533
        ./src/test/com/cloudera/sqoop/manager/TestSqlManager.java 1190533
        ./src/test/com/cloudera/sqoop/mapreduce/MapreduceTests.java 1190533
        ./src/test/com/cloudera/sqoop/mapreduce/TestImportJob.java 1190533
        ./src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 1190533
        ./src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java 1190533
        ./src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1195805
        ./src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1195805
        ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1190533
        ./src/test/com/cloudera/sqoop/testutil/CommonArgs.java 1190533
        ./src/test/com/cloudera/sqoop/testutil/DirUtil.java 1190533
        ./src/test/com/cloudera/sqoop/testutil/ExplicitSetMapper.java 1195790
        ./src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 1190533
        ./src/test/com/cloudera/sqoop/testutil/HsqldbTestServer.java 1190533
        ./src/test/com/cloudera/sqoop/testutil/ImportJobTestCase.java 1190533
        ./src/test/com/cloudera/sqoop/testutil/InjectableConnManager.java 1190533
        ./src/test/com/cloudera/sqoop/testutil/InjectableManagerFactory.java 1190533
        ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1190533
        ./src/test/com/cloudera/sqoop/testutil/MockObjectFactory.java 1190533
        ./src/test/com/cloudera/sqoop/testutil/MockResultSet.java 1190533
        ./src/test/com/cloudera/sqoop/testutil/ReparseMapper.java 1195788
        ./src/test/com/cloudera/sqoop/testutil/SeqFileReader.java 1190533
        ./src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1195805
        ./src/test/com/cloudera/sqoop/util/TestOptionsFileExpansion.java 1190533
        ./src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java 1196332

        Diff: https://reviews.apache.org/r/2668/diff

        Testing
        -------

        All test cases

        Thanks,

        Bilung

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2668/ ----------------------------------------------------------- Review request for Arvind Prabhakar. Summary ------- Patch for SQOOP-386 . This addresses bug SQOOP-386 . https://issues.apache.org/jira/browse/SQOOP-386 Diffs ./NOTICE.txt 1187139 ./src/docs/dev/SqoopDevGuide.txt 1196401 ./src/docs/dev/api-reference.txt 1187844 ./src/docs/dev/compiling.txt 1187844 ./src/docs/dev/intro.txt 1187844 ./src/docs/dev/preface.txt 1187844 ./src/docs/man/codegen-args.txt 1187844 ./src/docs/man/common-args.txt 1187844 ./src/docs/man/hbase-args.txt 1187844 ./src/docs/man/hive-args.txt 1187844 ./src/docs/man/import-args.txt 1187844 ./src/docs/man/input-args.txt 1187844 ./src/docs/man/output-args.txt 1187844 ./src/docs/sip/INDEX.txt 1187844 ./src/docs/sip/README.txt 1187844 ./src/docs/sip/sip-1.txt 1187844 ./src/docs/sip/sip-2.txt 1187844 ./src/docs/sip/sip-3.txt 1187844 ./src/docs/sip/sip-4.txt 1187844 ./src/docs/sip/sip-6.txt 1187844 ./src/docs/user/SqoopUserGuide.txt 1187844 ./src/docs/user/basics.txt 1187844 ./src/docs/user/codegen-args.txt 1187844 ./src/docs/user/codegen-purpose.txt 1187844 ./src/docs/user/codegen.txt 1187844 ./src/docs/user/common-args.txt 1187844 ./src/docs/user/compatibility.txt 1187844 ./src/docs/user/connecting.txt 1187844 ./src/docs/user/controlling-input-format.txt 1187844 ./src/docs/user/controlling-output-format.txt 1187844 ./src/docs/user/create-hive-table-purpose.txt 1187844 ./src/docs/user/create-hive-table.txt 1187844 ./src/docs/user/eval-purpose.txt 1187844 ./src/docs/user/eval.txt 1187844 ./src/docs/user/export-purpose.txt 1187844 ./src/docs/user/export.txt 1187844 ./src/docs/user/hbase-args.txt 1187844 ./src/docs/user/hbase.txt 1187844 ./src/docs/user/help.txt 1187844 ./src/docs/user/hive-args.txt 1187844 ./src/docs/user/hive-notes.txt 1187844 ./src/docs/user/hive.txt 1187844 ./src/docs/user/import-all-tables-purpose.txt 1187844 ./src/docs/user/import-all-tables.txt 1187844 ./src/docs/user/import-purpose.txt 1187844 ./src/docs/user/import.txt 1187844 ./src/docs/user/input-args.txt 1187844 ./src/docs/user/input-formatting-args.txt 1187844 ./src/docs/user/input-formatting.txt 1187844 ./src/docs/user/intro.txt 1187844 ./src/docs/user/job-purpose.txt 1187844 ./src/docs/user/list-databases.txt 1187844 ./src/docs/user/list-tables.txt 1187844 ./src/docs/user/merge-purpose.txt 1187844 ./src/docs/user/metastore-purpose.txt 1187844 ./src/docs/user/output-args.txt 1187844 ./src/docs/user/output-formatting-args.txt 1187844 ./src/docs/user/output-formatting.txt 1187844 ./src/docs/user/preface.txt 1187844 ./src/docs/user/saved-jobs.txt 1187844 ./src/docs/user/support.txt 1187844 ./src/docs/user/tools.txt 1187844 ./src/docs/user/troubleshooting.txt 1187844 ./src/docs/user/version.txt 1187844 ./src/docs/web/breadcrumbs.xsl 1187844 ./src/docs/web/docbook.css 1187844 ./src/docs/web/footer.xsl 1187844 ./src/docs/web/header.xsl 1187844 ./src/docs/web/html.xsl 1187844 ./src/docs/web/index.txt 1187844 ./src/java/com/cloudera/sqoop/ConnFactory.java 1187591 ./src/java/com/cloudera/sqoop/Sqoop.java 1187591 ./src/java/com/cloudera/sqoop/SqoopOptions.java 1187591 ./src/java/com/cloudera/sqoop/cli/RelatedOptions.java 1195865 ./src/java/com/cloudera/sqoop/hbase/ToStringPutTransformer.java 1195691 ./src/java/com/cloudera/sqoop/io/LobFile.java 1190438 ./src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 1196291 ./src/java/com/cloudera/sqoop/mapreduce/DataDrivenImportJob.java 1190670 ./src/java/com/cloudera/sqoop/mapreduce/DelegatingOutputFormat.java 1190670 ./src/java/com/cloudera/sqoop/mapreduce/ExportBatchOutputFormat.java 1190670 ./src/java/com/cloudera/sqoop/mapreduce/db/DBOutputFormat.java 1190670 ./src/java/com/cloudera/sqoop/mapreduce/db/DataDrivenDBInputFormat.java 1190670 ./src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1195852 ./src/java/com/cloudera/sqoop/tool/SqoopTool.java 1196194 ./src/java/com/cloudera/sqoop/util/TaskId.java 1188941 ./src/java/org/apache/sqoop/ConnFactory.java PRE-CREATION ./src/java/org/apache/sqoop/Sqoop.java PRE-CREATION ./src/java/org/apache/sqoop/SqoopOptions.java PRE-CREATION ./src/java/org/apache/sqoop/lib/ClobRef.java 1196332 ./src/java/org/apache/sqoop/lib/DelimiterSet.java 1196332 ./src/java/org/apache/sqoop/manager/PostgresqlManager.java 1196332 ./src/java/org/apache/sqoop/mapreduce/AvroExportMapper.java 1196332 ./src/java/org/apache/sqoop/mapreduce/MySQLDumpInputFormat.java 1196332 ./src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java 1196332 ./src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java 1196332 ./src/java/org/apache/sqoop/mapreduce/db/FloatSplitter.java 1196332 ./src/java/org/apache/sqoop/mapreduce/db/IntegerSplitter.java 1196332 ./src/java/org/apache/sqoop/mapreduce/db/TextSplitter.java 1196332 ./src/java/org/apache/sqoop/metastore/hsqldb/AutoHsqldbStorage.java 1196332 ./src/perftest/ExportStressTest.java 1187139 ./src/perftest/ExtConnFactoryTest.java 1187139 ./src/perftest/ExtFactory.java 1187139 ./src/perftest/LobFilePerfTest.java 1187139 ./src/perftest/LobFileStressTest.java 1187139 ./src/test/com/cloudera/sqoop/AllTests.java 1190533 ./src/test/com/cloudera/sqoop/SmokeTests.java 1190533 ./src/test/com/cloudera/sqoop/TestAllTables.java 1190533 ./src/test/com/cloudera/sqoop/TestAppendUtils.java 1190533 ./src/test/com/cloudera/sqoop/TestAvroExport.java 1190533 ./src/test/com/cloudera/sqoop/TestAvroImport.java 1190533 ./src/test/com/cloudera/sqoop/TestAvroImportExportRoundtrip.java 1190533 ./src/test/com/cloudera/sqoop/TestBoundaryQuery.java 1190533 ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1190533 ./src/test/com/cloudera/sqoop/TestCompression.java 1190533 ./src/test/com/cloudera/sqoop/TestConnFactory.java 1190533 ./src/test/com/cloudera/sqoop/TestExport.java 1195790 ./src/test/com/cloudera/sqoop/TestExportUpdate.java 1190533 ./src/test/com/cloudera/sqoop/TestIncrementalImport.java 1190533 ./src/test/com/cloudera/sqoop/TestMerge.java 1190533 ./src/test/com/cloudera/sqoop/TestMultiCols.java 1190533 ./src/test/com/cloudera/sqoop/TestMultiMaps.java 1190533 ./src/test/com/cloudera/sqoop/TestQuery.java 1190533 ./src/test/com/cloudera/sqoop/TestSplitBy.java 1190533 ./src/test/com/cloudera/sqoop/TestSqoopOptions.java 1190533 ./src/test/com/cloudera/sqoop/TestTargetDir.java 1190533 ./src/test/com/cloudera/sqoop/TestWhere.java 1190533 ./src/test/com/cloudera/sqoop/ThirdPartyTests.java 1190533 ./src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 1190533 ./src/test/com/cloudera/sqoop/hbase/TestHBaseImport.java 1190533 ./src/test/com/cloudera/sqoop/hbase/TestHBaseQueryImport.java 1190533 ./src/test/com/cloudera/sqoop/hbase/TestHBaseUtil.java 1190533 ./src/test/com/cloudera/sqoop/hive/TestHiveImport.java 1190533 ./src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java 1190533 ./src/test/com/cloudera/sqoop/io/TestCodecMap.java 1190533 ./src/test/com/cloudera/sqoop/io/TestLobFile.java 1190533 ./src/test/com/cloudera/sqoop/io/TestNamedFifo.java 1190533 ./src/test/com/cloudera/sqoop/io/TestSplittableBufferedWriter.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestBlobRef.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestBooleanParser.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestClobRef.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestFieldFormatter.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestLargeObjectLoader.java 1190533 ./src/test/com/cloudera/sqoop/lib/TestRecordParser.java 1190533 ./src/test/com/cloudera/sqoop/manager/DB2ManagerImportManualTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/MySQLAuthTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java 1190533 ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/OracleExportTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/OracleUtils.java 1190533 ./src/test/com/cloudera/sqoop/manager/PostgresqlTest.java 1196291 ./src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 1190533 ./src/test/com/cloudera/sqoop/manager/TestHsqldbManager.java 1190533 ./src/test/com/cloudera/sqoop/manager/TestSqlManager.java 1190533 ./src/test/com/cloudera/sqoop/mapreduce/MapreduceTests.java 1190533 ./src/test/com/cloudera/sqoop/mapreduce/TestImportJob.java 1190533 ./src/test/com/cloudera/sqoop/mapreduce/db/TestDataDrivenDBInputFormat.java 1190533 ./src/test/com/cloudera/sqoop/metastore/TestSavedJobs.java 1190533 ./src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1195805 ./src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1195805 ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1190533 ./src/test/com/cloudera/sqoop/testutil/CommonArgs.java 1190533 ./src/test/com/cloudera/sqoop/testutil/DirUtil.java 1190533 ./src/test/com/cloudera/sqoop/testutil/ExplicitSetMapper.java 1195790 ./src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 1190533 ./src/test/com/cloudera/sqoop/testutil/HsqldbTestServer.java 1190533 ./src/test/com/cloudera/sqoop/testutil/ImportJobTestCase.java 1190533 ./src/test/com/cloudera/sqoop/testutil/InjectableConnManager.java 1190533 ./src/test/com/cloudera/sqoop/testutil/InjectableManagerFactory.java 1190533 ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1190533 ./src/test/com/cloudera/sqoop/testutil/MockObjectFactory.java 1190533 ./src/test/com/cloudera/sqoop/testutil/MockResultSet.java 1190533 ./src/test/com/cloudera/sqoop/testutil/ReparseMapper.java 1195788 ./src/test/com/cloudera/sqoop/testutil/SeqFileReader.java 1190533 ./src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1195805 ./src/test/com/cloudera/sqoop/util/TestOptionsFileExpansion.java 1190533 ./src/test/org/apache/sqoop/mapreduce/db/TestTextSplitter.java 1196332 Diff: https://reviews.apache.org/r/2668/diff Testing ------- All test cases Thanks, Bilung

          People

          • Assignee:
            Bilung Lee
            Reporter:
            Bilung Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development