Sqoop
  1. Sqoop
  2. SQOOP-364

Default getCurTimestampQuery() in SqlManager is not working for PostgreSQL

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      PostgresqlManager needs to override getCurTimestampQuery() to return "SELECT CURRENT_TIMESTAMP".

      1. SQOOP-364.patch
        2 kB
        Kathleen Ting

        Activity

        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #50 (See https://builds.apache.org/job/Sqoop-jdk-1.6/50/)
        SQOOP-364: Default getCurTimestampQuery() in SqlManager is not working for PostgreSQL

        blee : http://svn.apache.org/viewvc/?view=rev&rev=1195859
        Files :

        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/manager/PostgresqlManager.java
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #50 (See https://builds.apache.org/job/Sqoop-jdk-1.6/50/ ) SQOOP-364 : Default getCurTimestampQuery() in SqlManager is not working for PostgreSQL blee : http://svn.apache.org/viewvc/?view=rev&rev=1195859 Files : /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/manager/PostgresqlManager.java
        Hide
        Bilung Lee added a comment -

        Patch commited. Thanks, Kate!

        Show
        Bilung Lee added a comment - Patch commited. Thanks, Kate!
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2657/#review2980
        -----------------------------------------------------------

        Ship it!

        Look good! Thanks, Kate.

        • Bilung

        On 2011-11-01 07:39:07, Kate Ting wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2657/

        -----------------------------------------------------------

        (Updated 2011-11-01 07:39:07)

        Review request for Sqoop and Bilung Lee.

        Summary

        -------

        Postgres can now return the current timestamp.

        This addresses bug SQOOP-364.

        https://issues.apache.org/jira/browse/SQOOP-364

        Diffs

        -----

        src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 6442908

        src/test/com/cloudera/sqoop/manager/PostgresqlTest.java 574003d

        Diff: https://reviews.apache.org/r/2657/diff

        Testing

        -------

        Unit test added.

        Thanks,

        Kate

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2657/#review2980 ----------------------------------------------------------- Ship it! Look good! Thanks, Kate. Bilung On 2011-11-01 07:39:07, Kate Ting wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2657/ ----------------------------------------------------------- (Updated 2011-11-01 07:39:07) Review request for Sqoop and Bilung Lee. Summary ------- Postgres can now return the current timestamp. This addresses bug SQOOP-364 . https://issues.apache.org/jira/browse/SQOOP-364 Diffs ----- src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 6442908 src/test/com/cloudera/sqoop/manager/PostgresqlTest.java 574003d Diff: https://reviews.apache.org/r/2657/diff Testing ------- Unit test added. Thanks, Kate
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2657/
        -----------------------------------------------------------

        Review request for Sqoop and Bilung Lee.

        Summary
        -------

        Postgres can now return the current timestamp.

        This addresses bug SQOOP-364.
        https://issues.apache.org/jira/browse/SQOOP-364

        Diffs


        src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 6442908
        src/test/com/cloudera/sqoop/manager/PostgresqlTest.java 574003d

        Diff: https://reviews.apache.org/r/2657/diff

        Testing
        -------

        Unit test added.

        Thanks,

        Kate

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2657/ ----------------------------------------------------------- Review request for Sqoop and Bilung Lee. Summary ------- Postgres can now return the current timestamp. This addresses bug SQOOP-364 . https://issues.apache.org/jira/browse/SQOOP-364 Diffs src/java/com/cloudera/sqoop/manager/PostgresqlManager.java 6442908 src/test/com/cloudera/sqoop/manager/PostgresqlTest.java 574003d Diff: https://reviews.apache.org/r/2657/diff Testing ------- Unit test added. Thanks, Kate

          People

          • Assignee:
            Kathleen Ting
            Reporter:
            Bilung Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development