Sqoop
  1. Sqoop
  2. SQOOP-349

A bunch of the fields are wrong in pom.xml

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/1996/
      -----------------------------------------------------------

      Review request for Sqoop.

      Summary
      -------

      It looks like we inherited a lot of our pom.xml from ognl. Some of the fields were never replaced.

      This addresses bug SQOOP-349.
      https://issues.apache.org/jira/browse/SQOOP-349

      Diffs


      pom.xml fd4e7cb

      Diff: https://reviews.apache.org/r/1996/diff

      Testing
      -------

      Made sure ant package still works.

      Thanks,

      Alex

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1996/ ----------------------------------------------------------- Review request for Sqoop. Summary ------- It looks like we inherited a lot of our pom.xml from ognl. Some of the fields were never replaced. This addresses bug SQOOP-349 . https://issues.apache.org/jira/browse/SQOOP-349 Diffs pom.xml fd4e7cb Diff: https://reviews.apache.org/r/1996/diff Testing ------- Made sure ant package still works. Thanks, Alex
      Hide
      jiraposter@reviews.apache.org added a comment -

      -----------------------------------------------------------
      This is an automatically generated e-mail. To reply, visit:
      https://reviews.apache.org/r/1996/#review2074
      -----------------------------------------------------------

      Ship it!

      Thanks for the patch! Look good to me.

      • Bilung

      On 2011-09-21 00:29:20, Alex Newman wrote:

      -----------------------------------------------------------

      This is an automatically generated e-mail. To reply, visit:

      https://reviews.apache.org/r/1996/

      -----------------------------------------------------------

      (Updated 2011-09-21 00:29:20)

      Review request for Sqoop.

      Summary

      -------

      It looks like we inherited a lot of our pom.xml from ognl. Some of the fields were never replaced.

      This addresses bug SQOOP-349.

      https://issues.apache.org/jira/browse/SQOOP-349

      Diffs

      -----

      pom.xml fd4e7cb

      Diff: https://reviews.apache.org/r/1996/diff

      Testing

      -------

      Made sure ant package still works.

      Thanks,

      Alex

      Show
      jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1996/#review2074 ----------------------------------------------------------- Ship it! Thanks for the patch! Look good to me. Bilung On 2011-09-21 00:29:20, Alex Newman wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1996/ ----------------------------------------------------------- (Updated 2011-09-21 00:29:20) Review request for Sqoop. Summary ------- It looks like we inherited a lot of our pom.xml from ognl. Some of the fields were never replaced. This addresses bug SQOOP-349 . https://issues.apache.org/jira/browse/SQOOP-349 Diffs ----- pom.xml fd4e7cb Diff: https://reviews.apache.org/r/1996/diff Testing ------- Made sure ant package still works. Thanks, Alex
      Hide
      Bilung Lee added a comment -

      Patch committed. Thanks, Alex!

      Show
      Bilung Lee added a comment - Patch committed. Thanks, Alex!
      Hide
      Hudson added a comment -

      Integrated in Sqoop-jdk-1.6 #29 (See https://builds.apache.org/job/Sqoop-jdk-1.6/29/)
      SQOOP-349: Fixing fields in pom.xml

      (Alex Newman via Bilung Lee)

      blee : http://svn.apache.org/viewvc/?view=rev&rev=1176120
      Files :

      • /incubator/sqoop/trunk/pom.xml
      Show
      Hudson added a comment - Integrated in Sqoop-jdk-1.6 #29 (See https://builds.apache.org/job/Sqoop-jdk-1.6/29/ ) SQOOP-349 : Fixing fields in pom.xml (Alex Newman via Bilung Lee) blee : http://svn.apache.org/viewvc/?view=rev&rev=1176120 Files : /incubator/sqoop/trunk/pom.xml

        People

        • Assignee:
          Alex Newman
          Reporter:
          Alex Newman
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development