[SQOOP-3308] Mock ConnManager field in TestTableDefWriter

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.0
• Assignee: Vasas Szabolcs
• Reporter: Vasas Szabolcs
• Created: 26/Mar/18 13:50
• Updated: 29/Mar/18 14:34
• Resolved: 29/Mar/18 14:34

Description

TableDefWriter has a dependency on ConnManager to retrieve the names and the types of the table. It also introduces a field called externalColTypes for testing purposes and TestTableDefWriter uses this field to inject the test table column names and types instead of mocking the ConnManager field.

This setup makes it harder to add test cases to TestTableDefWriter and not a good practice so it should be fixed.

Issue Links

• links to: ReviewBoard