[SQOOP-3306] Connection resource related issues in DBOutputFormat and OracleManager

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.4.7
• Fix Version/s: 1.5.0
• Assignee: László Bodor
• Reporter: László Bodor
• Created: 26/Mar/18 11:35
• Updated: 29/Mar/18 09:07

Description

A fortify scan showed 2 possible resource leaks.

Overview : The function getRecordWriter() in DBOutputFormat.java sometimes fails to release a database resource allocated by getConnection() on line 117.
In the file DBOutputFormat.java similar issues were on line numbers 117

 

Connection should be closed before throwing IOException forward.

    try {

      Connection connection = dbConf.getConnection();

      PreparedStatement statement = null;

      statement = connection.prepareStatement(

                    constructQuery(tableName, fieldNames));

      return new org.apache.sqoop.mapreduce.db.DBOutputFormat.DBRecordWriter(

                     connection, statement);

    } catch (Exception ex) {

      throw new IOException(ex);

    }

 

Overview : The function makeConnection() in OracleManager.java sometimes fails to release a database resource allocated by getConnection() on line 321.
In the file OracleManager.java similar issues were on line numbers 321

 

Some connection post setup steps could be extracted to a separate method which could be enclosed by a try/catch.

connection.setTransactionIsolation(Connection.TRANSACTION_READ_COMMITTED);     
setSessionTimeZone(connection);
connection.setAutoCommit(false);

Issue Links

• links to: review request