[SQOOP-3283] MySQL thirdparty tests hang if there's no USER environment variable

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.7
• Fix Version/s: 1.5.0
• Component/s: connectors/mysql, test
• Assignee: Daniel Voros
• Reporter: Daniel Voros
• Created: 06/Feb/18 10:57
• Updated: 15/Feb/18 14:35
• Resolved: 14/Feb/18 18:12

Description

org.apache.sqoop.manager.mysql.MySQLTestUtils#getCurrentUser() executes whoami in a subprocess if there's no USER environment variable (happened to me while running tests from Docker). However, it waits for the Process variable to become null, that never happens:

// wait for whoami to exit.
while (p != null) {
  try {
    int ret = p.waitFor();
    if (0 != ret) {
      LOG.error("whoami exited with error status " + ret);
      // suppress original return value from this method.
      return null;
    }
  } catch (InterruptedException ie) {
    continue; // loop around.
  }
}

We could get rid of the while loop since Process#waitFor() blocks while it completes.

Note, that it's easy to workaround the issue by setting the USER environment variable when running the tests.

Issue Links

• links to: Review