Details

    • Type: Task
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: no-release
    • Component/s: None
    • Labels:
      None
    1. text.html
      3 kB
      Szabó Attila

      Activity

      Hide
      vasas Szabolcs Vasas added a comment -

      Hi Attila Szabo,

      As discussed in the mail chain we should include the following 2 JIRAs in the release as they are fixing some currently failing third party tests:

      https://issues.apache.org/jira/browse/SQOOP-3194
      https://issues.apache.org/jira/browse/SQOOP-3198

      Regards,
      Szabolcs

      Show
      vasas Szabolcs Vasas added a comment - Hi Attila Szabo , As discussed in the mail chain we should include the following 2 JIRAs in the release as they are fixing some currently failing third party tests: https://issues.apache.org/jira/browse/SQOOP-3194 https://issues.apache.org/jira/browse/SQOOP-3198 Regards, Szabolcs
      Hide
      Ying Cao Ying Cao added a comment -

      Hi Attila,

      As discussed in the mail, please include following JIRA in the new release:

      https://issues.apache.org/jira/browse/SQOOP-1905

      Regards,
      Angela

      Show
      Ying Cao Ying Cao added a comment - Hi Attila, As discussed in the mail, please include following JIRA in the new release: https://issues.apache.org/jira/browse/SQOOP-1905 Regards, Angela
      Hide
      BoglarkaEgyed Boglarka Egyed added a comment -

      Hi Attila Szabo,

      Thanks for your efforts on this release!

      I took a look at the CHANGELOG.txt and it seems to contain some Open JIRAs too, for example SQOOP-3052 is still open and no patch has been pushed even for a review so far. As the target date of the release is end of June I would say that this change won't be able to go to 1.4.7.

      Also, SQOOP-3190 is currently under review and is not committed yet, etc.

      Could you please double-check the proposed change set?

      Many thanks,
      Bogi

      Show
      BoglarkaEgyed Boglarka Egyed added a comment - Hi Attila Szabo , Thanks for your efforts on this release! I took a look at the CHANGELOG.txt and it seems to contain some Open JIRAs too, for example SQOOP-3052 is still open and no patch has been pushed even for a review so far. As the target date of the release is end of June I would say that this change won't be able to go to 1.4.7. Also, SQOOP-3190 is currently under review and is not committed yet, etc. Could you please double-check the proposed change set? Many thanks, Bogi
      Hide
      maugli Attila Szabo added a comment - - edited

      Hey Boglarka Egyed,

      Thanks for this invaluable feedback. I'll check this right now.

      Cheers,
      Attila

      p.s.: In the upcoming few days (max 10) I'll be only partially available due to family duties, but I'll try to handle this ASAP of course. Thanks once more!

      Show
      maugli Attila Szabo added a comment - - edited Hey Boglarka Egyed , Thanks for this invaluable feedback. I'll check this right now. Cheers, Attila p.s.: In the upcoming few days (max 10) I'll be only partially available due to family duties, but I'll try to handle this ASAP of course. Thanks once more!
      Hide
      jilani Jilani Shaik added a comment -

      Hi,

      As suggested by Bogi in review request, I am sharing below JIRA issue and review request which is completed recently.

      JIRA Request:
      https://issues.apache.org/jira/browse/SQOOP-3149
      similar one
      https://issues.apache.org/jira/browse/SQOOP-3125

      Review Request:
      https://reviews.apache.org/r/57499/

      Thanks,
      Jilani

      Show
      jilani Jilani Shaik added a comment - Hi, As suggested by Bogi in review request, I am sharing below JIRA issue and review request which is completed recently. JIRA Request: https://issues.apache.org/jira/browse/SQOOP-3149 similar one https://issues.apache.org/jira/browse/SQOOP-3125 Review Request: https://reviews.apache.org/r/57499/ Thanks, Jilani
      Hide
      BoglarkaEgyed Boglarka Egyed added a comment -

      Hi Attila Szabo,

      Just a quick catch-up on the progress of this release - could you please give us a new ETA as we have passed the original one (end of June) already? No pressure, I just think it would be useful to see a new timeline for the release.

      And of course, please let me know if you need any help on this.

      Many thanks,
      Bogi

      Show
      BoglarkaEgyed Boglarka Egyed added a comment - Hi Attila Szabo , Just a quick catch-up on the progress of this release - could you please give us a new ETA as we have passed the original one (end of June) already? No pressure, I just think it would be useful to see a new timeline for the release. And of course, please let me know if you need any help on this. Many thanks, Bogi
      Hide
      maugli Attila Szabo added a comment -

      Hey Boglarka Egyed,

      Thanks for checking the status. I'm back from the family+hospital duties, so I'll be able to fix the grooming+cherry picking on the branch.

      After that I'll definitely need your help, as currently on my dev environment I do only have sandbox DB-s, so I'll kindly ask you to run all the tests on your side as well (just for an additional sanity check). I'll update you still today, when I'm ready with the branch.

      If all the tests will pass on your side, I'll build the first RC.

      Thanks,
      Attila Szabo

      Show
      maugli Attila Szabo added a comment - Hey Boglarka Egyed , Thanks for checking the status. I'm back from the family+hospital duties, so I'll be able to fix the grooming+cherry picking on the branch. After that I'll definitely need your help, as currently on my dev environment I do only have sandbox DB-s, so I'll kindly ask you to run all the tests on your side as well (just for an additional sanity check). I'll update you still today, when I'm ready with the branch. If all the tests will pass on your side, I'll build the first RC. Thanks, Attila Szabo
      Hide
      maugli Attila Szabo added a comment -

      Hey Anna Szonyi, Boglarka Egyed,

      I've finished with some leftover reviews, commits and cherry-picks, so now the branch contains the commits we've wanted as the content of the first RC.

      With the release notes the problem is the following:
      The JIRA generator tool still sees those unresolved tasks, which has to be postponed to 1.5 (or later), but right now I'm not able to create version 1.5 as I'm not a JIRA administrator yet. So I have to ask some of the administrators to solve this issue (meanwhile I'll fix the changes information in the branch manually, but I would like to avoid, that the branch+release and the JIRA would be out of sync).

      This might take some time, due my only channel for the administrators is the email, this might be delayed by next week.

      Until could you please check out the branch-1.4.7 and run all the junit+3rd party tests on your side too? I've done it on my side, but right now my server resources are very limited, and might happen, that because of the "sandbox" DB's some issues are not caught.

      Many thanks in advance for you help,

      Best regards,
      Attila Szabo

      ps: Ying Cao, Szabolcs Vasas, the changes we've agreed about now are part of the branch-1.4.7. Could you please do a sanity check on your side too, if you could also see those commits? Just for the 4 eyes principle. Many thanks!

      Show
      maugli Attila Szabo added a comment - Hey Anna Szonyi , Boglarka Egyed , I've finished with some leftover reviews, commits and cherry-picks, so now the branch contains the commits we've wanted as the content of the first RC. With the release notes the problem is the following: The JIRA generator tool still sees those unresolved tasks, which has to be postponed to 1.5 (or later), but right now I'm not able to create version 1.5 as I'm not a JIRA administrator yet. So I have to ask some of the administrators to solve this issue (meanwhile I'll fix the changes information in the branch manually, but I would like to avoid, that the branch+release and the JIRA would be out of sync). This might take some time, due my only channel for the administrators is the email, this might be delayed by next week. Until could you please check out the branch-1.4.7 and run all the junit+3rd party tests on your side too? I've done it on my side, but right now my server resources are very limited, and might happen, that because of the "sandbox" DB's some issues are not caught. Many thanks in advance for you help, Best regards, Attila Szabo ps: Ying Cao , Szabolcs Vasas , the changes we've agreed about now are part of the branch-1.4.7. Could you please do a sanity check on your side too, if you could also see those commits? Just for the 4 eyes principle. Many thanks!
      Hide
      vasas Szabolcs Vasas added a comment -

      Hi Attila Szabo,

      Thank you!
      I have checked the commits I have seen that SQOOP-3198 is in the release branch but SQOOP-3194 is still missing, without that some third party tests will fail, can you please backport it as well?
      Once it is done I am going to run all the tests on my side too.

      Regards,
      Szabolcs

      Show
      vasas Szabolcs Vasas added a comment - Hi Attila Szabo , Thank you! I have checked the commits I have seen that SQOOP-3198 is in the release branch but SQOOP-3194 is still missing, without that some third party tests will fail, can you please backport it as well? Once it is done I am going to run all the tests on my side too. Regards, Szabolcs
      Hide
      BoglarkaEgyed Boglarka Egyed added a comment -

      Hi Attila Szabo,

      Sure, I will run all the unit and third party tests too on branch 1.4.7.

      Cheers,
      Bogi

      Show
      BoglarkaEgyed Boglarka Egyed added a comment - Hi Attila Szabo , Sure, I will run all the unit and third party tests too on branch 1.4.7. Cheers, Bogi
      Hide
      BoglarkaEgyed Boglarka Egyed added a comment -

      Hey Attila Szabo,

      I ran the tests and I can confirm that without Szabi's patch some 3rd party tests are failing so please do include it as well into the release. Otherwise, branch-1.4.7 looks good to me so far.

      Thanks,
      Bogi

      Show
      BoglarkaEgyed Boglarka Egyed added a comment - Hey Attila Szabo , I ran the tests and I can confirm that without Szabi's patch some 3rd party tests are failing so please do include it as well into the release. Otherwise, branch-1.4.7 looks good to me so far. Thanks, Bogi
      Hide
      BoglarkaEgyed Boglarka Egyed added a comment -

      Hi Attila Szabo,

      I have realized that SQOOP-3174 was not in a Resolved state nor was tagged to 1.4.7 so I have resolved it and set the target version properly. I checked and it has been included into branch-1.4.7 - which is good - but it has not been included into the CHANGELOG.txt

      Could you please correct it?

      Thanks,
      Bogi

      Show
      BoglarkaEgyed Boglarka Egyed added a comment - Hi Attila Szabo , I have realized that SQOOP-3174 was not in a Resolved state nor was tagged to 1.4.7 so I have resolved it and set the target version properly. I checked and it has been included into branch-1.4.7 - which is good - but it has not been included into the CHANGELOG.txt Could you please correct it? Thanks, Bogi
      Hide
      maugli@inf.elte.hu Szabó Attila added a comment -

      Hey Bogi,

      I'll correct it during this evening

      Cheers
      Attila

      On Aug 10, 2017 3:01 PM, "Boglarka Egyed (JIRA)" <jira@apache.org> wrote:

      [ https://issues.apache.org/jira/browse/SQOOP-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121574#comment-16121574 ]

      Boglarka Egyed commented on SQOOP-3199:
      ---------------------------------------

      Hi Attila Szabo,

      I have realized that SQOOP-3174 was not in a Resolved state nor was tagged to 1.4.7 so I have resolved it and set the target version properly. I checked and it has been included into branch-1.4.7 - which is good - but it has not been included into the CHANGELOG.txt

      Could you please correct it?

      Thanks,
      Bogi


      This message was sent by Atlassian JIRA
      (v6.4.14#64029)

      Show
      maugli@inf.elte.hu Szabó Attila added a comment - Hey Bogi, I'll correct it during this evening Cheers Attila On Aug 10, 2017 3:01 PM, "Boglarka Egyed (JIRA)" <jira@apache.org> wrote: [ https://issues.apache.org/jira/browse/SQOOP-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121574#comment-16121574 ] Boglarka Egyed commented on SQOOP-3199 : --------------------------------------- Hi Attila Szabo , I have realized that SQOOP-3174 was not in a Resolved state nor was tagged to 1.4.7 so I have resolved it and set the target version properly. I checked and it has been included into branch-1.4.7 - which is good - but it has not been included into the CHANGELOG.txt Could you please correct it? Thanks, Bogi – This message was sent by Atlassian JIRA (v6.4.14#64029)
      Hide
      anna.szonyi Anna Szonyi added a comment -

      Hi Attila Szabo,

      I know you've been very busy lately, so the delays are of course understandable with the release.
      Do you think you will be able to close off the release by the end of September, if not then we would be happy to take the shepherding of it over. Also, we would be happy to help with anything else (Bogi and Szabi ran the 3rd party tests), if needed.

      There have been a few questions about the content as well, I will direct them to this umbrella jira.

      Thanks,
      Anna

      Show
      anna.szonyi Anna Szonyi added a comment - Hi Attila Szabo , I know you've been very busy lately, so the delays are of course understandable with the release. Do you think you will be able to close off the release by the end of September, if not then we would be happy to take the shepherding of it over. Also, we would be happy to help with anything else (Bogi and Szabi ran the 3rd party tests), if needed. There have been a few questions about the content as well, I will direct them to this umbrella jira. Thanks, Anna
      Hide
      BoglarkaEgyed Boglarka Egyed added a comment -

      Hi Attila Szabo,

      I see that Anna Szonyi's previous question has remained unanswered in the past 3 weeks also that there was no actual progress on this release since the middle of July but I think it would be highly beneficial to have it finished as soon as possible.

      I do understand that you had other important duties lately but this release is going on for 3 months now with still open items and unaddressed requests on this JIRA thus I would like to kindly ask you to let the community know by Wednesday (4th of October) evening if you are able to close it off in the next 2 weeks or not.

      If you are not able or there won't be any answer by Wednesday I would take over the Release Manager role to finish it up shortly.

      Thank you,
      Bogi

      Show
      BoglarkaEgyed Boglarka Egyed added a comment - Hi Attila Szabo , I see that Anna Szonyi 's previous question has remained unanswered in the past 3 weeks also that there was no actual progress on this release since the middle of July but I think it would be highly beneficial to have it finished as soon as possible. I do understand that you had other important duties lately but this release is going on for 3 months now with still open items and unaddressed requests on this JIRA thus I would like to kindly ask you to let the community know by Wednesday (4th of October) evening if you are able to close it off in the next 2 weeks or not. If you are not able or there won't be any answer by Wednesday I would take over the Release Manager role to finish it up shortly. Thank you, Bogi
      Hide
      maugli Attila Szabo added a comment -

      Hey Anna Szonyi, Boglarka Egyed,

      First of all I'd like to thank for your help, efforts and questions around this topic.
      Sadly I've been having continuous health issues in the previous period of time, so didn't have time to put efforts on this front.

      But to move forward:
      I'll build a RC-1 right now, and upload it, and continue with the release process. If I would feel I won't be able to complete it in the upcoming two weeks, or would face any issues again which would hold me back from focusing on this, I will hand it over to you.

      I'll keep you updated,
      Attila

      Show
      maugli Attila Szabo added a comment - Hey Anna Szonyi , Boglarka Egyed , First of all I'd like to thank for your help, efforts and questions around this topic. Sadly I've been having continuous health issues in the previous period of time, so didn't have time to put efforts on this front. But to move forward: I'll build a RC-1 right now, and upload it, and continue with the release process. If I would feel I won't be able to complete it in the upcoming two weeks, or would face any issues again which would hold me back from focusing on this, I will hand it over to you. I'll keep you updated, Attila
      Hide
      BoglarkaEgyed Boglarka Egyed added a comment -

      Hi Attila Szabo,

      All right, thank you for the quick response!

      Before building the RC-1 please take care of some findings which I have found during checking the current status of this release:

      • JIRAs which have been asked to include into 1.4.7 but still not in branch-1.4.7: SQOOP-3194, SQOOP-3149
      • CHANGELOG.txt contains numerous JIRAs which are still in Open state without any patch or commit (e.g. SQOOP-956, SQOOP-3052, etc..) - please run an automatic check to get the full list, there are many unfortunately.
      • SQOOP-3174 is in branch-1.4.7 but doesn't present in CHANGELOG.txt - there may be others as well, please check those also.
      • I am a bit concerned about the scope of this release. In a patch release only backwards-compatible bug fixes should be introduced however I see other items on the CHANGELOG as New Features, etc. - could you please reconsider the scope of 1.4.7 release? Or wouldn't it be more reasonable to make it as 1.5.0? What do you think?

      Thank you in advance,
      Bogi

      Show
      BoglarkaEgyed Boglarka Egyed added a comment - Hi Attila Szabo , All right, thank you for the quick response! Before building the RC-1 please take care of some findings which I have found during checking the current status of this release: JIRAs which have been asked to include into 1.4.7 but still not in branch-1.4.7: SQOOP-3194 , SQOOP-3149 CHANGELOG.txt contains numerous JIRAs which are still in Open state without any patch or commit (e.g. SQOOP-956 , SQOOP-3052 , etc..) - please run an automatic check to get the full list, there are many unfortunately. SQOOP-3174 is in branch-1.4.7 but doesn't present in CHANGELOG.txt - there may be others as well, please check those also. I am a bit concerned about the scope of this release. In a patch release only backwards-compatible bug fixes should be introduced however I see other items on the CHANGELOG as New Features, etc. - could you please reconsider the scope of 1.4.7 release? Or wouldn't it be more reasonable to make it as 1.5.0? What do you think? Thank you in advance, Bogi

        People

        • Assignee:
          maugli Attila Szabo
          Reporter:
          maugli Attila Szabo
        • Votes:
          0 Vote for this issue
          Watchers:
          8 Start watching this issue

          Dates

          • Due:
            Created:
            Updated:

            Development