Sqoop
  1. Sqoop
  2. SQOOP-317

OracleManager should allow working with tables owned by other users.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      The default Oracle connector in Sqoop uses user-specific catalog views for doing metadata lookup queires. This results in failure when the table is not owned by the user that Sqoop connects as.

      1. SQOOP-317.diff
        14 kB
        Arvind Prabhakar
      2. SQOOP-317-1.diff
        16 kB
        Arvind Prabhakar

        Activity

        Hide
        Arvind Prabhakar added a comment -

        Attach patch seems to work. I will be doing more testing in the meantime.

        Show
        Arvind Prabhakar added a comment - Attach patch seems to work. I will be doing more testing in the meantime.
        Hide
        Arvind Prabhakar added a comment -

        Updating patch with some changes found during testing.

        Show
        Arvind Prabhakar added a comment - Updating patch with some changes found during testing.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1579/
        -----------------------------------------------------------

        Review request for Sqoop, jmhsieh and Bilung Lee.

        Summary
        -------

        Modified OracleManager implementation to use global catalog views instead of user-specific views for metadata queries. Also introduced a test case that specifically exercises the functionality in question. Note that if this gets committed, the Oracle test configuration would need to be changed in order to introduce a new user that will be used by the OracleManagerTest.

        This addresses bug SQOOP-317.
        https://issues.apache.org/jira/browse/SQOOP-317

        Diffs


        /src/java/com/cloudera/sqoop/manager/OracleManager.java 1158963
        /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1158963
        /src/test/com/cloudera/sqoop/manager/OracleUtils.java 1158963

        Diff: https://reviews.apache.org/r/1579/diff

        Testing
        -------

        All unit and thirdparty tests along with some manual testing.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1579/ ----------------------------------------------------------- Review request for Sqoop, jmhsieh and Bilung Lee. Summary ------- Modified OracleManager implementation to use global catalog views instead of user-specific views for metadata queries. Also introduced a test case that specifically exercises the functionality in question. Note that if this gets committed, the Oracle test configuration would need to be changed in order to introduce a new user that will be used by the OracleManagerTest. This addresses bug SQOOP-317 . https://issues.apache.org/jira/browse/SQOOP-317 Diffs /src/java/com/cloudera/sqoop/manager/OracleManager.java 1158963 /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1158963 /src/test/com/cloudera/sqoop/manager/OracleUtils.java 1158963 Diff: https://reviews.apache.org/r/1579/diff Testing ------- All unit and thirdparty tests along with some manual testing. Thanks, Arvind
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1579/#review1533
        -----------------------------------------------------------

        Ship it!

        Look good to me.

        • Bilung

        On 2011-08-18 00:15:54, Arvind Prabhakar wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/1579/

        -----------------------------------------------------------

        (Updated 2011-08-18 00:15:54)

        Review request for Sqoop, jmhsieh and Bilung Lee.

        Summary

        -------

        Modified OracleManager implementation to use global catalog views instead of user-specific views for metadata queries. Also introduced a test case that specifically exercises the functionality in question. Note that if this gets committed, the Oracle test configuration would need to be changed in order to introduce a new user that will be used by the OracleManagerTest.

        This addresses bug SQOOP-317.

        https://issues.apache.org/jira/browse/SQOOP-317

        Diffs

        -----

        /src/java/com/cloudera/sqoop/manager/OracleManager.java 1158963

        /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1158963

        /src/test/com/cloudera/sqoop/manager/OracleUtils.java 1158963

        Diff: https://reviews.apache.org/r/1579/diff

        Testing

        -------

        All unit and thirdparty tests along with some manual testing.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1579/#review1533 ----------------------------------------------------------- Ship it! Look good to me. Bilung On 2011-08-18 00:15:54, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1579/ ----------------------------------------------------------- (Updated 2011-08-18 00:15:54) Review request for Sqoop, jmhsieh and Bilung Lee. Summary ------- Modified OracleManager implementation to use global catalog views instead of user-specific views for metadata queries. Also introduced a test case that specifically exercises the functionality in question. Note that if this gets committed, the Oracle test configuration would need to be changed in order to introduce a new user that will be used by the OracleManagerTest. This addresses bug SQOOP-317 . https://issues.apache.org/jira/browse/SQOOP-317 Diffs ----- /src/java/com/cloudera/sqoop/manager/OracleManager.java 1158963 /src/test/com/cloudera/sqoop/manager/OracleManagerTest.java 1158963 /src/test/com/cloudera/sqoop/manager/OracleUtils.java 1158963 Diff: https://reviews.apache.org/r/1579/diff Testing ------- All unit and thirdparty tests along with some manual testing. Thanks, Arvind
        Hide
        Arvind Prabhakar added a comment -

        Patch committed.

        Show
        Arvind Prabhakar added a comment - Patch committed.
        Hide
        Hudson added a comment -

        Integrated in Sqoop-jdk-1.6 #13 (See https://builds.apache.org/job/Sqoop-jdk-1.6/13/)
        SQOOP-317. Allow working with tables owned by other users in Oracle.

        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1159491
        Files :

        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleUtils.java
        • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleManagerTest.java
        • /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/manager/OracleManager.java
        Show
        Hudson added a comment - Integrated in Sqoop-jdk-1.6 #13 (See https://builds.apache.org/job/Sqoop-jdk-1.6/13/ ) SQOOP-317 . Allow working with tables owned by other users in Oracle. arvind : http://svn.apache.org/viewvc/?view=rev&rev=1159491 Files : /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleUtils.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleManagerTest.java /incubator/sqoop/trunk/src/java/com/cloudera/sqoop/manager/OracleManager.java

          People

          • Assignee:
            Arvind Prabhakar
            Reporter:
            Arvind Prabhakar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development