Uploaded image for project: 'Sqoop (Retired)'
  1. Sqoop (Retired)
  2. SQOOP-2326

Fix Netezza trunc-string option handling and unnecessary log directory during imports

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.6
    • 1.4.7
    • None
    • None

    Description

      SQOOP-2164 enhanced a few netezza functions.

      But it looks like the last patch I uploaded has the following lines duplicated. Sorry about that.

      +    conf.setBoolean(NETEZZA_CTRL_CHARS_OPT,
      +      cmdLine.hasOption(NETEZZA_CTRL_CHARS_LONG_ARG));
      

      instead of handling the --trunc-string option.

      Moreover, trunc-string, ctrl-chars and log-dir do not apply to external table imports, so we need to cleanup creation of unnecessary directories for the imports.

      Attachments

        1. SQOOP-2326.diff
          4 kB
          Venkat Ranganathan

        Issue Links

          Activity

            I have not put fix version for this. If there is a new RC for Sqoop 1.4.6, please try to include this in that RC. Otherwise we can push this to 1.4.7

            venkatnrangan Venkat Ranganathan added a comment - I have not put fix version for this. If there is a new RC for Sqoop 1.4.6, please try to include this in that RC. Otherwise we can push this to 1.4.7

            Commit d54dddf0b81d1d196788b4e6422b14b88c2a05ac in sqoop's branch refs/heads/trunk from jarcec
            [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=d54dddf ]

            SQOOP-2326: Fix Netezza trunc-string option handling and unnecessary log directory during imports

            (Venkat Ranganathan via Jarek Jarcec Cecho)

            jira-bot ASF subversion and git services added a comment - Commit d54dddf0b81d1d196788b4e6422b14b88c2a05ac in sqoop's branch refs/heads/trunk from jarcec [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=d54dddf ] SQOOP-2326 : Fix Netezza trunc-string option handling and unnecessary log directory during imports (Venkat Ranganathan via Jarek Jarcec Cecho)

            Thank you venkatnrangan for your contribution!

            jarcec Jarek Jarcec Cecho added a comment - Thank you venkatnrangan for your contribution!
            hudson Hudson added a comment -

            FAILURE: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #959 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/959/)
            SQOOP-2326: Fix Netezza trunc-string option handling and unnecessary log directory during imports (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d54dddf0b81d1d196788b4e6422b14b88c2a05ac)

            • src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java
            • src/java/org/apache/sqoop/manager/DirectNetezzaManager.java
            hudson Hudson added a comment - FAILURE: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #959 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/959/ ) SQOOP-2326 : Fix Netezza trunc-string option handling and unnecessary log directory during imports (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d54dddf0b81d1d196788b4e6422b14b88c2a05ac ) src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java src/java/org/apache/sqoop/manager/DirectNetezzaManager.java
            hudson Hudson added a comment -

            FAILURE: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #992 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/992/)
            SQOOP-2326: Fix Netezza trunc-string option handling and unnecessary log directory during imports (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d54dddf0b81d1d196788b4e6422b14b88c2a05ac)

            • src/java/org/apache/sqoop/manager/DirectNetezzaManager.java
            • src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java
            hudson Hudson added a comment - FAILURE: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #992 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/992/ ) SQOOP-2326 : Fix Netezza trunc-string option handling and unnecessary log directory during imports (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d54dddf0b81d1d196788b4e6422b14b88c2a05ac ) src/java/org/apache/sqoop/manager/DirectNetezzaManager.java src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java
            hudson Hudson added a comment -

            FAILURE: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #999 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/999/)
            SQOOP-2326: Fix Netezza trunc-string option handling and unnecessary log directory during imports (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d54dddf0b81d1d196788b4e6422b14b88c2a05ac)

            • src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java
            • src/java/org/apache/sqoop/manager/DirectNetezzaManager.java
            hudson Hudson added a comment - FAILURE: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #999 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/999/ ) SQOOP-2326 : Fix Netezza trunc-string option handling and unnecessary log directory during imports (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d54dddf0b81d1d196788b4e6422b14b88c2a05ac ) src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java src/java/org/apache/sqoop/manager/DirectNetezzaManager.java
            hudson Hudson added a comment -

            FAILURE: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1195 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1195/)
            SQOOP-2326: Fix Netezza trunc-string option handling and unnecessary log directory during imports (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d54dddf0b81d1d196788b4e6422b14b88c2a05ac)

            • src/java/org/apache/sqoop/manager/DirectNetezzaManager.java
            • src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java
            hudson Hudson added a comment - FAILURE: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1195 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1195/ ) SQOOP-2326 : Fix Netezza trunc-string option handling and unnecessary log directory during imports (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=d54dddf0b81d1d196788b4e6422b14b88c2a05ac ) src/java/org/apache/sqoop/manager/DirectNetezzaManager.java src/java/org/apache/sqoop/mapreduce/db/netezza/NetezzaExternalTableImportMapper.java

            Thanks for your review and commit jarcec

            venkatnrangan Venkat Ranganathan added a comment - Thanks for your review and commit jarcec

            People

              venkatnrangan Venkat Ranganathan
              venkatnrangan Venkat Ranganathan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: