Uploaded image for project: 'Sqoop (Retired)'
  1. Sqoop (Retired)
  2. SQOOP-2132

Remove test TestMainframeImportTool.testPrintHelp

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.5
    • 1.4.6
    • None
    • None

    Description

      I've noticed that test TestMainframeImportTool.testPrintHelp fails if run with Hadoop 2.6:

      ant clean test -Dtestcase=TestMainframeImportTool
      

      The reason is that Hadoop changed the default "help" text and this tool is checking output of that command character by character:

      Testcase: testPrintHelp took 0.025 sec
      	FAILED
      expected:<...namenode
      -jt <local|[jobtracker:port>    specify a job track]er
      -files <comma sep...> but was:<...namenode
      -jt <local|[resourcemanager:port>    specify a ResourceManag]er
      -files <comma sep...>
      junit.framework.ComparisonFailure: expected:<...namenode
      -jt <local|[jobtracker:port>    specify a job track]er
      -files <comma sep...> but was:<...namenode
      -jt <local|[resourcemanager:port>    specify a ResourceManag]er
      -files <comma sep...>
      	at org.apache.sqoop.tool.TestMainframeImportTool.testPrintHelp(TestMainframeImportTool.java:99)
      

      I don't see particular value in testing content of help message as it's mostly a static code, so I would like to suggest to simply drop this test.

      Attachments

        1. SQOOP-2132.patch
          3 kB
          Jarek Jarcec Cecho

        Activity

          People

            jarcec Jarek Jarcec Cecho
            jarcec Jarek Jarcec Cecho
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment