Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-1986 Sqoop2: Schema matching improvements
  3. SQOOP-1988

Sqoop2: isNull handling should be moved to CSVIntermediateDataFormat

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.99.5
    • Component/s: None
    • Labels:
      None

      Description

      The Matcher.getMatchingData method is expected to rearrange record fields according to the FROM and TO schema. Currently here is an extra step in the implementation, which will reset any null "NULL" "null" "'null'" or "" field to null.

      As there is no comment or documentation about this, I guess it is some undocumented special handling. Here is some discussion.

      I think this check should not belong here. I propose to remove it. As the method will be called very frequently, the code removal will have performance advance. Thanks Haifeng Chen

        Attachments

        1. SQOOP-1988.3.patch
          5 kB
          Qian Xu
        2. SQOOP-1988.patch
          7 kB
          Qian Xu

          Issue Links

            Activity

              People

              • Assignee:
                stanleyxu2005 Qian Xu
                Reporter:
                stanleyxu2005 Qian Xu
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: