[SQOOP-1811] Sqoop2: IDF API changes

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.99.5
• Component/s: sqoop2-framework
• Assignee: Veena Basavaraj
• Reporter: Veena Basavaraj
• Created: 25/Nov/14 17:44
• Updated: 09/Jan/15 16:51
• Resolved: 10/Dec/14 18:32

Description

1. update the java docs for IDF apis.

2. Make the getTextData final and call it getCSV and setCSV, so it is obvious that we want to enforce CSV format

the following code can move to the base class IntermediateDataFormat and made final, so there is no way to override this and we can enforce all to return String instead of generic T

// hold the string in IDF base class

 private final String text.
 
  public final String getCSVTextData() {
    return text;
  }

 
  public final void setCSVTextData(String text) {
    this.text = text;
  }

There is code in CSVIDF implementation that has the rules for CSV parsing that can be pulled out into CSV Utils so that the connectors can use
The T in CSV happens to String, which is just a coincidence, If I write a new IDF implementation T can be a custom object that could encapsulate the whole row.
Third, getData and setData can have custom implementation so they can be overriden to return the generic type T

Correction :

// hold the string in IDF base class, is !final

 private String text.
 
  public final String getCSVTextData() {
    return text;
  }

 
  public final void setCSVTextData(String text) {
    this.text = text;
  }

Issue Links

• links to: RB