Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-1412

Text splitter should also consider NCHAR and NVARCHAR fields

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.4, 1.4.5
    • Fix Version/s: 1.4.6
    • Component/s: None
    • Labels:
      None

      Description

      Some of the databases have a NCHAR type for storing data as UCS2 characters. Since our text splitter is already handling the UCS2 range, we can add these two datatypes to be valid split by columns.

      1. SQOOP-1412.diff
        0.6 kB
        Venkat Ranganathan

        Issue Links

          Activity

          Hide
          venkatnrangan Venkat Ranganathan added a comment -

          I have added the two type CHAR and NCHAR as valid splittable types. The general idea that text columns should not be used for split columns applies

          Show
          venkatnrangan Venkat Ranganathan added a comment - I have added the two type CHAR and NCHAR as valid splittable types. The general idea that text columns should not be used for split columns applies
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 11b1c917398517568451c1923f4116a0a446ee3a in sqoop's branch refs/heads/trunk from Jarek Jarcec Cecho
          [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=11b1c91 ]

          SQOOP-1412: Text splitter should also consider NCHAR and NVARCHAR fields

          (Venkat Ranganathan via Jarek Jarcec Cecho)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 11b1c917398517568451c1923f4116a0a446ee3a in sqoop's branch refs/heads/trunk from Jarek Jarcec Cecho [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=11b1c91 ] SQOOP-1412 : Text splitter should also consider NCHAR and NVARCHAR fields (Venkat Ranganathan via Jarek Jarcec Cecho)
          Hide
          jarcec Jarek Jarcec Cecho added a comment -

          Thank you for your contribution [~nrv] and for the review Gwen Shapira!

          Show
          jarcec Jarek Jarcec Cecho added a comment - Thank you for your contribution [~nrv] and for the review Gwen Shapira !
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #917 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/917/)
          SQOOP-1412: Text splitter should also consider NCHAR and NVARCHAR fields (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=11b1c917398517568451c1923f4116a0a446ee3a)

          • src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #917 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/917/ ) SQOOP-1412 : Text splitter should also consider NCHAR and NVARCHAR fields (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=11b1c917398517568451c1923f4116a0a446ee3a ) src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #911 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/911/)
          SQOOP-1412: Text splitter should also consider NCHAR and NVARCHAR fields (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=11b1c917398517568451c1923f4116a0a446ee3a)

          • src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #911 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/911/ ) SQOOP-1412 : Text splitter should also consider NCHAR and NVARCHAR fields (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=11b1c917398517568451c1923f4116a0a446ee3a ) src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1114 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1114/)
          SQOOP-1412: Text splitter should also consider NCHAR and NVARCHAR fields (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=11b1c917398517568451c1923f4116a0a446ee3a)

          • src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1114 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1114/ ) SQOOP-1412 : Text splitter should also consider NCHAR and NVARCHAR fields (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=11b1c917398517568451c1923f4116a0a446ee3a ) src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #875 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/875/)
          SQOOP-1412: Text splitter should also consider NCHAR and NVARCHAR fields (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=11b1c917398517568451c1923f4116a0a446ee3a)

          • src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #875 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/875/ ) SQOOP-1412 : Text splitter should also consider NCHAR and NVARCHAR fields (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=11b1c917398517568451c1923f4116a0a446ee3a ) src/java/org/apache/sqoop/mapreduce/db/DataDrivenDBInputFormat.java
          Hide
          venkatnrangan Venkat Ranganathan added a comment -

          Thanks Gwen Shapira for reviewing it and Jarek Jarcec Cecho for committing it

          Show
          venkatnrangan Venkat Ranganathan added a comment - Thanks Gwen Shapira for reviewing it and Jarek Jarcec Cecho for committing it

            People

            • Assignee:
              venkatnrangan Venkat Ranganathan
              Reporter:
              venkatnrangan Venkat Ranganathan
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development