Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-1268

Sqoop tarballs do not contain .gitignore and .gitattribute files

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.4.4
    • Fix Version/s: 1.4.5
    • Component/s: None
    • Labels:
      None

      Description

      It seems that both source and binary tarballs are missing .gitignore and .gitattributes files. Even thought that we are not shipping the git repository itself the files are part of our source code and thus I believe that we should ship them as well. Users might find them handy.

      1. SQOOP-1268.patch
        0.9 kB
        Jarek Jarcec Cecho

        Activity

        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        The files are part of ant's default exclude list, so I had to disable it. I've generated both binary and source tarball with the patch and confirmed that the files are there while checking that no other unnecessary files are pulled in.

        Show
        jarcec Jarek Jarcec Cecho added a comment - The files are part of ant's default exclude list, so I had to disable it. I've generated both binary and source tarball with the patch and confirmed that the files are there while checking that no other unnecessary files are pulled in.
        Hide
        venkatnrangan Venkat Ranganathan added a comment -

        LGTM but do we need .gitignore and .gitattribute for binary packages also?

        Show
        venkatnrangan Venkat Ranganathan added a comment - LGTM but do we need .gitignore and .gitattribute for binary packages also?
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Thank you for taking a look into the patch Venkat Ranganathan, appreciated!

        LGTM but do we need .gitignore and .gitattribute for binary packages also?

        Excellent question. Currently the binary package is actually a super set of a source package, e.g. entire source package is included in the binary package. It seemed natural to keep that still valid by adding the files to the binary packages as well.

        Show
        jarcec Jarek Jarcec Cecho added a comment - Thank you for taking a look into the patch Venkat Ranganathan , appreciated! LGTM but do we need .gitignore and .gitattribute for binary packages also? Excellent question. Currently the binary package is actually a super set of a source package, e.g. entire source package is included in the binary package. It seemed natural to keep that still valid by adding the files to the binary packages as well.
        Hide
        venkatnrangan Venkat Ranganathan added a comment -

        Thanks Jarek Jarcec Cecho. Looks good. Will commit after validation

        Show
        venkatnrangan Venkat Ranganathan added a comment - Thanks Jarek Jarcec Cecho . Looks good. Will commit after validation
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 55c5f27f9eb3965ef35640c1bbee8df382aac3f0 in branch refs/heads/trunk from [~nrv]
        [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=55c5f27 ]

        SQOOP-1268: Sqoop tarballs do not contain .gitignore and .gitattribute files
        (Jarec Jarcec Cecho via Venkat Ranganathan)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 55c5f27f9eb3965ef35640c1bbee8df382aac3f0 in branch refs/heads/trunk from [~nrv] [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=55c5f27 ] SQOOP-1268 : Sqoop tarballs do not contain .gitignore and .gitattribute files (Jarec Jarcec Cecho via Venkat Ranganathan)
        Hide
        venkatnrangan Venkat Ranganathan added a comment -

        Thanks for your contribution Jarek Jarcec Cecho.

        Show
        venkatnrangan Venkat Ranganathan added a comment - Thanks for your contribution Jarek Jarcec Cecho .
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #836 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/836/)
        SQOOP-1268: Sqoop tarballs do not contain .gitignore and .gitattribute files (venkat: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=55c5f27f9eb3965ef35640c1bbee8df382aac3f0)

        • build.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #836 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/836/ ) SQOOP-1268 : Sqoop tarballs do not contain .gitignore and .gitattribute files (venkat: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=55c5f27f9eb3965ef35640c1bbee8df382aac3f0 ) build.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #877 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/877/)
        SQOOP-1268: Sqoop tarballs do not contain .gitignore and .gitattribute files (venkat: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=55c5f27f9eb3965ef35640c1bbee8df382aac3f0)

        • build.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #877 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/877/ ) SQOOP-1268 : Sqoop tarballs do not contain .gitignore and .gitattribute files (venkat: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=55c5f27f9eb3965ef35640c1bbee8df382aac3f0 ) build.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #871 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/871/)
        SQOOP-1268: Sqoop tarballs do not contain .gitignore and .gitattribute files (venkat: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=55c5f27f9eb3965ef35640c1bbee8df382aac3f0)

        • build.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #871 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/871/ ) SQOOP-1268 : Sqoop tarballs do not contain .gitignore and .gitattribute files (venkat: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=55c5f27f9eb3965ef35640c1bbee8df382aac3f0 ) build.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1073 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1073/)
        SQOOP-1268: Sqoop tarballs do not contain .gitignore and .gitattribute files (venkat: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=55c5f27f9eb3965ef35640c1bbee8df382aac3f0)

        • build.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1073 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1073/ ) SQOOP-1268 : Sqoop tarballs do not contain .gitignore and .gitattribute files (venkat: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=55c5f27f9eb3965ef35640c1bbee8df382aac3f0 ) build.xml

          People

          • Assignee:
            jarcec Jarek Jarcec Cecho
            Reporter:
            jarcec Jarek Jarcec Cecho
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development