Sqoop
  1. Sqoop
  2. SQOOP-1212

Do not print usage on wrong command line

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.4
    • Fix Version/s: 1.4.5
    • Component/s: None
    • Labels:
      None

      Description

      Currently when user enter an incorrect command line, Sqoop will print in order:

      • Useful error message what has been entered wrong
      • At least 200 lines long usage guide

      As the usage guide will scroll the shell, the most useful information will get moved away, resulting in user confusion. I think that it will be more user friendly to stop printing the usage in case of a wrong input and display it only explicitly when user will ask for it (e.g. on sqoop import --help call).

      1. SQOOP-1212.patch
        0.6 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #891 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/891/)
          SQOOP-1212. Do not print usage on wrong command line. (harishreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=efda8ddca4f2ae52d5a1c999e193a5063965a0fc)

          • src/java/org/apache/sqoop/Sqoop.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #891 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/891/ ) SQOOP-1212 . Do not print usage on wrong command line. (harishreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=efda8ddca4f2ae52d5a1c999e193a5063965a0fc ) src/java/org/apache/sqoop/Sqoop.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1094 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1094/)
          SQOOP-1212. Do not print usage on wrong command line. (harishreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=efda8ddca4f2ae52d5a1c999e193a5063965a0fc)

          • src/java/org/apache/sqoop/Sqoop.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1094 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1094/ ) SQOOP-1212 . Do not print usage on wrong command line. (harishreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=efda8ddca4f2ae52d5a1c999e193a5063965a0fc ) src/java/org/apache/sqoop/Sqoop.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #897 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/897/)
          SQOOP-1212. Do not print usage on wrong command line. (harishreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=efda8ddca4f2ae52d5a1c999e193a5063965a0fc)

          • src/java/org/apache/sqoop/Sqoop.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #897 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/897/ ) SQOOP-1212 . Do not print usage on wrong command line. (harishreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=efda8ddca4f2ae52d5a1c999e193a5063965a0fc ) src/java/org/apache/sqoop/Sqoop.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #856 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/856/)
          SQOOP-1212. Do not print usage on wrong command line. (harishreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=efda8ddca4f2ae52d5a1c999e193a5063965a0fc)

          • src/java/org/apache/sqoop/Sqoop.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #856 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/856/ ) SQOOP-1212 . Do not print usage on wrong command line. (harishreedharan: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=efda8ddca4f2ae52d5a1c999e193a5063965a0fc ) src/java/org/apache/sqoop/Sqoop.java
          Hide
          Hari Shreedharan added a comment -

          Committed! Thanks Jarcec!

          Show
          Hari Shreedharan added a comment - Committed! Thanks Jarcec!
          Hide
          ASF subversion and git services added a comment -

          Commit efda8ddca4f2ae52d5a1c999e193a5063965a0fc in sqoop's branch refs/heads/trunk from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=efda8dd ]

          SQOOP-1212. Do not print usage on wrong command line.

          (Jarcec via Hari)

          Show
          ASF subversion and git services added a comment - Commit efda8ddca4f2ae52d5a1c999e193a5063965a0fc in sqoop's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=efda8dd ] SQOOP-1212 . Do not print usage on wrong command line. (Jarcec via Hari)
          Hide
          Hari Shreedharan added a comment -

          +1. Committing!

          Show
          Hari Shreedharan added a comment - +1. Committing!

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development