Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-1203

Add another default case for finding *_HOME when not explicitly defined

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.4
    • Fix Version/s: 1.4.5
    • Component/s: tools
    • Labels:
      None

      Description

      Currently, the configure-sqoop scripts that checks the value of various _HOME variables (e.g. HADOOP_MAPRED_HOME, HCAT_HOME, etc.) has the following heuristic:
      1. Use the *_HOME variable's value, if defined.
      2. If not, assign /usr/lib/<relevant location> to the variable.
      3. If /usr/lib/<relevant location> doesn't exist, error out

      I would like to propose to modify this to add one more case before we error out.
      1. Use the *_HOME variable's value, if defined.
      2. If not, assign /usr/lib/<relevant location> to the *_HOME variable.
      3. If /usr/lib/<relevant location> doesn't exist, check for hadoop and hcat at the same directory level as sqoop
      4. If #3 fails as well, error out.

      This is backwards compatible because it wouldn't be touching any of the existing cases. It will just add more location to check for presence of hadoop, hcat etc. before erroring out.

        Activity

        Hide
        mgrover Mark Grover added a comment -

        Attaching patch

        Show
        mgrover Mark Grover added a comment - Attaching patch
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        +1

        Show
        jarcec Jarek Jarcec Cecho added a comment - +1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e187f454c550081687f72bedbd88d0a1d3d92f14 in branch refs/heads/trunk from Jarek Jarcec Cecho
        [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=e187f45 ]

        SQOOP-1203: Add another default case for finding *_HOME when not explicitly defined

        (Mark Grover via Jarek Jarcec Cecho)

        Show
        jira-bot ASF subversion and git services added a comment - Commit e187f454c550081687f72bedbd88d0a1d3d92f14 in branch refs/heads/trunk from Jarek Jarcec Cecho [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=e187f45 ] SQOOP-1203 : Add another default case for finding *_HOME when not explicitly defined (Mark Grover via Jarek Jarcec Cecho)
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Thank you Mark Grover for your contribution!

        Show
        jarcec Jarek Jarcec Cecho added a comment - Thank you Mark Grover for your contribution!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #814 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/814/)
        SQOOP-1203: Add another default case for finding *_HOME when not explicitly defined (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=e187f454c550081687f72bedbd88d0a1d3d92f14)

        • bin/configure-sqoop
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #814 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/814/ ) SQOOP-1203 : Add another default case for finding *_HOME when not explicitly defined (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=e187f454c550081687f72bedbd88d0a1d3d92f14 ) bin/configure-sqoop
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #858 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/858/)
        SQOOP-1203: Add another default case for finding *_HOME when not explicitly defined (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=e187f454c550081687f72bedbd88d0a1d3d92f14)

        • bin/configure-sqoop
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #858 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/858/ ) SQOOP-1203 : Add another default case for finding *_HOME when not explicitly defined (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=e187f454c550081687f72bedbd88d0a1d3d92f14 ) bin/configure-sqoop
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #853 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/853/)
        SQOOP-1203: Add another default case for finding *_HOME when not explicitly defined (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=e187f454c550081687f72bedbd88d0a1d3d92f14)

        • bin/configure-sqoop
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #853 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/853/ ) SQOOP-1203 : Add another default case for finding *_HOME when not explicitly defined (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=e187f454c550081687f72bedbd88d0a1d3d92f14 ) bin/configure-sqoop
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1052 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1052/)
        SQOOP-1203: Add another default case for finding *_HOME when not explicitly defined (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=e187f454c550081687f72bedbd88d0a1d3d92f14)

        • bin/configure-sqoop
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1052 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1052/ ) SQOOP-1203 : Add another default case for finding *_HOME when not explicitly defined (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=e187f454c550081687f72bedbd88d0a1d3d92f14 ) bin/configure-sqoop

          People

          • Assignee:
            mgrover Mark Grover
            Reporter:
            mgrover Mark Grover
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development