Sqoop
  1. Sqoop
  2. SQOOP-1170

Can't import columns with name "public"

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.4
    • Fix Version/s: 1.4.5
    • Component/s: codegen
    • Labels:
      None

      Description

      sqoop fails to generate a proper class for tables with a column named public. Possible reason: public is not included in JAVA_RESERVED_WORDS in ClassWriter.java.

      Reproduce by:
      1. Create table with column named public
      2. Attempt to import table.

        Issue Links

          Activity

          Erik Selin created issue -
          Erik Selin made changes -
          Field Original Value New Value
          Affects Version/s 1.3.0 [ 12317344 ]
          Affects Version/s 1.4.0-incubating [ 12317345 ]
          Affects Version/s 1.4.1-incubating [ 12318902 ]
          Affects Version/s 1.4.2 [ 12320141 ]
          Affects Version/s 1.4.3 [ 12322644 ]
          Hide
          Erik Selin added a comment -

          This should fix it.

          Show
          Erik Selin added a comment - This should fix it.
          Erik Selin made changes -
          Attachment bugSQOOP-1170.patch [ 12598647 ]
          Erik Selin made changes -
          Remote Link This issue links to "review request (Web Link)" [ 12518 ]
          Hide
          Erik Selin added a comment -

          Added a review request for dealing with columns named "public"

          Show
          Erik Selin added a comment - Added a review request for dealing with columns named "public"
          Erik Selin made changes -
          Attachment bugSQOOP-1170.patch [ 12599871 ]
          Erik Selin made changes -
          Attachment bugSQOOP-1170.patch [ 12598647 ]
          Hide
          Erik Selin added a comment -

          Added updated patch.

          Show
          Erik Selin added a comment - Added updated patch.
          Hide
          ASF subversion and git services added a comment -

          Commit 1b41c9a6d25e8bbe2a9c35c5ed3deb4530a67f28 in branch refs/heads/trunk from Jarek Jarcec Cecho
          [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=1b41c9a ]

          SQOOP-1170: Can't import columns with name "public"

          (Erik Selin via Jarek Jarcec Cecho)

          Show
          ASF subversion and git services added a comment - Commit 1b41c9a6d25e8bbe2a9c35c5ed3deb4530a67f28 in branch refs/heads/trunk from Jarek Jarcec Cecho [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=1b41c9a ] SQOOP-1170 : Can't import columns with name "public" (Erik Selin via Jarek Jarcec Cecho)
          Hide
          Jarek Jarcec Cecho added a comment -

          Thank you Erik Selin for resolving this issue!

          Show
          Jarek Jarcec Cecho added a comment - Thank you Erik Selin for resolving this issue!
          Jarek Jarcec Cecho made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Eric Wadsworth [ wad ]
          Fix Version/s 1.4.5 [ 12324765 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #844 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/844/)
          SQOOP-1170: Can't import columns with name "public" (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=1b41c9a6d25e8bbe2a9c35c5ed3deb4530a67f28)

          • src/java/org/apache/sqoop/orm/ClassWriter.java
          • src/test/com/cloudera/sqoop/orm/TestClassWriter.java
          • src/java/com/cloudera/sqoop/orm/ClassWriter.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop20 #844 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/844/ ) SQOOP-1170 : Can't import columns with name "public" (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=1b41c9a6d25e8bbe2a9c35c5ed3deb4530a67f28 ) src/java/org/apache/sqoop/orm/ClassWriter.java src/test/com/cloudera/sqoop/orm/TestClassWriter.java src/java/com/cloudera/sqoop/orm/ClassWriter.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1042 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1042/)
          SQOOP-1170: Can't import columns with name "public" (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=1b41c9a6d25e8bbe2a9c35c5ed3deb4530a67f28)

          • src/java/org/apache/sqoop/orm/ClassWriter.java
          • src/java/com/cloudera/sqoop/orm/ClassWriter.java
          • src/test/com/cloudera/sqoop/orm/TestClassWriter.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop23 #1042 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/1042/ ) SQOOP-1170 : Can't import columns with name "public" (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=1b41c9a6d25e8bbe2a9c35c5ed3deb4530a67f28 ) src/java/org/apache/sqoop/orm/ClassWriter.java src/java/com/cloudera/sqoop/orm/ClassWriter.java src/test/com/cloudera/sqoop/orm/TestClassWriter.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #803 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/803/)
          SQOOP-1170: Can't import columns with name "public" (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=1b41c9a6d25e8bbe2a9c35c5ed3deb4530a67f28)

          • src/java/com/cloudera/sqoop/orm/ClassWriter.java
          • src/test/com/cloudera/sqoop/orm/TestClassWriter.java
          • src/java/org/apache/sqoop/orm/ClassWriter.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop100 #803 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/803/ ) SQOOP-1170 : Can't import columns with name "public" (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=1b41c9a6d25e8bbe2a9c35c5ed3deb4530a67f28 ) src/java/com/cloudera/sqoop/orm/ClassWriter.java src/test/com/cloudera/sqoop/orm/TestClassWriter.java src/java/org/apache/sqoop/orm/ClassWriter.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #847 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/847/)
          SQOOP-1170: Can't import columns with name "public" (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=1b41c9a6d25e8bbe2a9c35c5ed3deb4530a67f28)

          • src/java/com/cloudera/sqoop/orm/ClassWriter.java
          • src/java/org/apache/sqoop/orm/ClassWriter.java
          • src/test/com/cloudera/sqoop/orm/TestClassWriter.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Sqoop-ant-jdk-1.6-hadoop200 #847 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/847/ ) SQOOP-1170 : Can't import columns with name "public" (jarcec: https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=1b41c9a6d25e8bbe2a9c35c5ed3deb4530a67f28 ) src/java/com/cloudera/sqoop/orm/ClassWriter.java src/java/org/apache/sqoop/orm/ClassWriter.java src/test/com/cloudera/sqoop/orm/TestClassWriter.java
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          14d 8h 46m 1 Jarek Jarcec Cecho 26/Aug/13 17:02

            People

            • Assignee:
              Eric Wadsworth
              Reporter:
              Erik Selin
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development